diff mbox series

arm64: dts: imx8mm-venice-gw7: Fix pci sub-nodes

Message ID 20231030183213.615162-1-festevam@gmail.com (mailing list archive)
State New, archived
Headers show
Series arm64: dts: imx8mm-venice-gw7: Fix pci sub-nodes | expand

Commit Message

Fabio Estevam Oct. 30, 2023, 6:32 p.m. UTC
From: Fabio Estevam <festevam@denx.de>

Several schema warnings are seen when running:

make dtbs_check DT_SCHEMA_FILES=pci-bus.yaml

Fix them.

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 .../dts/freescale/imx8mm-venice-gw72xx.dtsi   | 30 ++++++++++++-------
 .../dts/freescale/imx8mm-venice-gw73xx.dtsi   | 30 ++++++++++++-------
 .../dts/freescale/imx8mm-venice-gw7902.dts    | 14 +++++----
 3 files changed, 47 insertions(+), 27 deletions(-)

Comments

Tim Harvey Oct. 30, 2023, 7:35 p.m. UTC | #1
On Mon, Oct 30, 2023 at 11:32 AM Fabio Estevam <festevam@gmail.com> wrote:
>
> From: Fabio Estevam <festevam@denx.de>
>
> Several schema warnings are seen when running:
>
> make dtbs_check DT_SCHEMA_FILES=pci-bus.yaml
>
> Fix them.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
>  .../dts/freescale/imx8mm-venice-gw72xx.dtsi   | 30 ++++++++++++-------
>  .../dts/freescale/imx8mm-venice-gw73xx.dtsi   | 30 ++++++++++++-------
>  .../dts/freescale/imx8mm-venice-gw7902.dts    | 14 +++++----
>  3 files changed, 47 insertions(+), 27 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi
> index 3a0a10e835a2..02807c5fc979 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi
> @@ -152,23 +152,31 @@ &pcie0 {
>
>         pcie@0,0 {
>                 reg = <0x0000 0 0 0 0>;
> -               #address-cells = <1>;
> -               #size-cells = <0>;
> +               device_type = "pci";
> +               #address-cells = <3>;
> +               #size-cells = <2>;
> +               ranges;
>
> -               pcie@1,0 {
> +               pcie@0,0 {
>                         reg = <0x0000 0 0 0 0>;
> -                       #address-cells = <1>;
> -                       #size-cells = <0>;
> +                       device_type = "pci";
> +                       #address-cells = <3>;
> +                       #size-cells = <2>;
> +                       ranges;
>
> -                       pcie@2,3 {
> +                       pcie@3,0 {
>                                 reg = <0x1800 0 0 0 0>;
> -                               #address-cells = <1>;
> -                               #size-cells = <0>;
> +                               device_type = "pci";
> +                               #address-cells = <3>;
> +                               #size-cells = <2>;
> +                               ranges;
>
> -                               eth1: pcie@5,0 {
> +                               eth1: pcie@0,0 {
>                                         reg = <0x0000 0 0 0 0>;
> -                                       #address-cells = <1>;
> -                                       #size-cells = <0>;
> +                                       device_type = "pci";
> +                                       #address-cells = <3>;
> +                                       #size-cells = <2>;
> +                                       ranges;
>
>                                         local-mac-address = [00 00 00 00 00 00];
>                                 };
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi
> index 4f859d0fec69..7830b724ccd8 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi
> @@ -172,23 +172,31 @@ &pcie0 {
>
>         pcie@0,0 {
>                 reg = <0x0000 0 0 0 0>;
> -               #address-cells = <1>;
> -               #size-cells = <0>;
> +               device_type = "pci";
> +               #address-cells = <3>;
> +               #size-cells = <2>;
> +               ranges;
>
> -               pcie@1,0 {
> +               pcie@0,0 {
>                         reg = <0x0000 0 0 0 0>;
> -                       #address-cells = <1>;
> -                       #size-cells = <0>;
> +                       device_type = "pci";
> +                       #address-cells = <3>;
> +                       #size-cells = <2>;
> +                       ranges;
>
> -                       pcie@2,4 {
> +                       pcie@4,0 {
>                                 reg = <0x2000 0 0 0 0>;
> -                               #address-cells = <1>;
> -                               #size-cells = <0>;
> +                               device_type = "pci";
> +                               #address-cells = <3>;
> +                               #size-cells = <2>;
> +                               ranges;
>
> -                               eth1: pcie@6,0 {
> +                               eth1: pcie@0,0 {
>                                         reg = <0x0000 0 0 0 0>;
> -                                       #address-cells = <1>;
> -                                       #size-cells = <0>;
> +                                       device_type = "pci";
> +                                       #address-cells = <3>;
> +                                       #size-cells = <2>;
> +                                       ranges;
>
>                                         local-mac-address = [00 00 00 00 00 00];
>                                 };
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts
> index 06a394a41d7c..7ef17c2b0e9d 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts
> @@ -635,13 +635,17 @@ &pcie0 {
>
>         pcie@0,0 {
>                 reg = <0x0000 0 0 0 0>;
> -               #address-cells = <1>;
> -               #size-cells = <0>;
> +               device_type = "pci";
> +               #address-cells = <3>;
> +               #size-cells = <2>;
> +               ranges;
>
> -               eth1: pcie@1,0 {
> +               eth1: pcie@0,0 {
>                         reg = <0x0000 0 0 0 0>;
> -                       #address-cells = <1>;
> -                       #size-cells = <0>;
> +                       device_type = "pci";
> +                       #address-cells = <3>;
> +                       #size-cells = <2>;
> +                       ranges;
>
>                         local-mac-address = [00 00 00 00 00 00];
>                 };
> --
> 2.34.1
>

Acked-by: Tim Harvey <tharvey@gateworks.com>

Best Regards,

Tim
Shawn Guo Nov. 27, 2023, 3:20 a.m. UTC | #2
On Mon, Oct 30, 2023 at 03:32:13PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Several schema warnings are seen when running:
> 
> make dtbs_check DT_SCHEMA_FILES=pci-bus.yaml
> 
> Fix them.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Applied, thanks!
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi
index 3a0a10e835a2..02807c5fc979 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi
@@ -152,23 +152,31 @@  &pcie0 {
 
 	pcie@0,0 {
 		reg = <0x0000 0 0 0 0>;
-		#address-cells = <1>;
-		#size-cells = <0>;
+		device_type = "pci";
+		#address-cells = <3>;
+		#size-cells = <2>;
+		ranges;
 
-		pcie@1,0 {
+		pcie@0,0 {
 			reg = <0x0000 0 0 0 0>;
-			#address-cells = <1>;
-			#size-cells = <0>;
+			device_type = "pci";
+			#address-cells = <3>;
+			#size-cells = <2>;
+			ranges;
 
-			pcie@2,3 {
+			pcie@3,0 {
 				reg = <0x1800 0 0 0 0>;
-				#address-cells = <1>;
-				#size-cells = <0>;
+				device_type = "pci";
+				#address-cells = <3>;
+				#size-cells = <2>;
+				ranges;
 
-				eth1: pcie@5,0 {
+				eth1: pcie@0,0 {
 					reg = <0x0000 0 0 0 0>;
-					#address-cells = <1>;
-					#size-cells = <0>;
+					device_type = "pci";
+					#address-cells = <3>;
+					#size-cells = <2>;
+					ranges;
 
 					local-mac-address = [00 00 00 00 00 00];
 				};
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi
index 4f859d0fec69..7830b724ccd8 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi
@@ -172,23 +172,31 @@  &pcie0 {
 
 	pcie@0,0 {
 		reg = <0x0000 0 0 0 0>;
-		#address-cells = <1>;
-		#size-cells = <0>;
+		device_type = "pci";
+		#address-cells = <3>;
+		#size-cells = <2>;
+		ranges;
 
-		pcie@1,0 {
+		pcie@0,0 {
 			reg = <0x0000 0 0 0 0>;
-			#address-cells = <1>;
-			#size-cells = <0>;
+			device_type = "pci";
+			#address-cells = <3>;
+			#size-cells = <2>;
+			ranges;
 
-			pcie@2,4 {
+			pcie@4,0 {
 				reg = <0x2000 0 0 0 0>;
-				#address-cells = <1>;
-				#size-cells = <0>;
+				device_type = "pci";
+				#address-cells = <3>;
+				#size-cells = <2>;
+				ranges;
 
-				eth1: pcie@6,0 {
+				eth1: pcie@0,0 {
 					reg = <0x0000 0 0 0 0>;
-					#address-cells = <1>;
-					#size-cells = <0>;
+					device_type = "pci";
+					#address-cells = <3>;
+					#size-cells = <2>;
+					ranges;
 
 					local-mac-address = [00 00 00 00 00 00];
 				};
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts
index 06a394a41d7c..7ef17c2b0e9d 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts
@@ -635,13 +635,17 @@  &pcie0 {
 
 	pcie@0,0 {
 		reg = <0x0000 0 0 0 0>;
-		#address-cells = <1>;
-		#size-cells = <0>;
+		device_type = "pci";
+		#address-cells = <3>;
+		#size-cells = <2>;
+		ranges;
 
-		eth1: pcie@1,0 {
+		eth1: pcie@0,0 {
 			reg = <0x0000 0 0 0 0>;
-			#address-cells = <1>;
-			#size-cells = <0>;
+			device_type = "pci";
+			#address-cells = <3>;
+			#size-cells = <2>;
+			ranges;
 
 			local-mac-address = [00 00 00 00 00 00];
 		};