diff mbox series

[04/10] dt-bindings: pwm: samsung: add exynosautov9 compatible

Message ID 20231031094852.118677-5-jaewon02.kim@samsung.com (mailing list archive)
State New, archived
Headers show
Series Introduce ExynosAutov920 SoC and SADK board | expand

Commit Message

Jaewon Kim Oct. 31, 2023, 9:47 a.m. UTC
Add samsung,exynosautov920-pwm compatible string to binding document.

Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
---
 Documentation/devicetree/bindings/pwm/pwm-samsung.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Uwe Kleine-König Nov. 9, 2023, 6:28 a.m. UTC | #1
Hello,

On Tue, Oct 31, 2023 at 06:47:46PM +0900, Jaewon Kim wrote:
> Add samsung,exynosautov920-pwm compatible string to binding document.
> 
> Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
> ---
>  Documentation/devicetree/bindings/pwm/pwm-samsung.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml b/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml
> index 2162f661ed5a..b6beca2ae81e 100644
> --- a/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml
> +++ b/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml
> @@ -30,6 +30,7 @@ properties:
>        - items:
>            - enum:
>                - samsung,exynosautov9-pwm
> +              - samsung,exynosautov920-pwm
>            - const: samsung,exynos4210-pwm

Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

What is the merge plan here? Should this go via the pwm tree, or can it
better go via some exynos tree together with the dts files?

Best regards
Uwe
Krzysztof Kozlowski Nov. 9, 2023, 8:23 a.m. UTC | #2
On 09/11/2023 07:28, Uwe Kleine-König wrote:
> Hello,
> 
> On Tue, Oct 31, 2023 at 06:47:46PM +0900, Jaewon Kim wrote:
>> Add samsung,exynosautov920-pwm compatible string to binding document.
>>
>> Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
>> ---
>>  Documentation/devicetree/bindings/pwm/pwm-samsung.yaml | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml b/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml
>> index 2162f661ed5a..b6beca2ae81e 100644
>> --- a/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml
>> +++ b/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml
>> @@ -30,6 +30,7 @@ properties:
>>        - items:
>>            - enum:
>>                - samsung,exynosautov9-pwm
>> +              - samsung,exynosautov920-pwm
>>            - const: samsung,exynos4210-pwm
> 
> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> 
> What is the merge plan here? Should this go via the pwm tree, or can it
> better go via some exynos tree together with the dts files?

I propose I will take it. I will have conflicting change and keeping
bindings with DTS together allows smooth dtbs_check.

Best regards,
Krzysztof
Jaewon Kim Nov. 9, 2023, 8:36 a.m. UTC | #3
On 23. 11. 9. 17:23, Krzysztof Kozlowski wrote:
> On 09/11/2023 07:28, Uwe Kleine-König wrote:
>> Hello,
>>
>> On Tue, Oct 31, 2023 at 06:47:46PM +0900, Jaewon Kim wrote:
>>> Add samsung,exynosautov920-pwm compatible string to binding document.
>>>
>>> Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
>>> ---
>>>   Documentation/devicetree/bindings/pwm/pwm-samsung.yaml | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml b/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml
>>> index 2162f661ed5a..b6beca2ae81e 100644
>>> --- a/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml
>>> +++ b/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml
>>> @@ -30,6 +30,7 @@ properties:
>>>         - items:
>>>             - enum:
>>>                 - samsung,exynosautov9-pwm
>>> +              - samsung,exynosautov920-pwm
>>>             - const: samsung,exynos4210-pwm
>> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>>
>> What is the merge plan here? Should this go via the pwm tree, or can it
>> better go via some exynos tree together with the dts files?
> I propose I will take it. I will have conflicting change and keeping
> bindings with DTS together allows smooth dtbs_check.
>
> Best regards,
> Krzysztof
>
>

I also agree it would be better to enter the exynos tree.

Thanks Krzysztof.


Thanks,

Jaewon Kim
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml b/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml
index 2162f661ed5a..b6beca2ae81e 100644
--- a/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml
+++ b/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml
@@ -30,6 +30,7 @@  properties:
       - items:
           - enum:
               - samsung,exynosautov9-pwm
+              - samsung,exynosautov920-pwm
           - const: samsung,exynos4210-pwm
 
   reg: