diff mbox series

ARM: dts: imx6ul-pico: Describe the Ethernet PHY clock

Message ID 20231105133219.954696-1-festevam@gmail.com (mailing list archive)
State New, archived
Headers show
Series ARM: dts: imx6ul-pico: Describe the Ethernet PHY clock | expand

Commit Message

Fabio Estevam Nov. 5, 2023, 1:32 p.m. UTC 
From: Fabio Estevam <festevam@denx.de>

Since commit c7e73b5051d6 ("ARM: imx: mach-imx6ul: remove 14x14 EVK
specific PHY fixup")thet Ethernet PHY is no longer configured via code
in board file.

This caused Ethernet to stop working.

Fix this problem by describing the clocks and clock-names to the
Ethernet PHY node so that the KSZ8081 chip can be clocked correctly.

Fixes: c7e73b5051d6 ("ARM: imx: mach-imx6ul: remove 14x14 EVK specific PHY fixup")
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm/boot/dts/nxp/imx/imx6ul-pico.dtsi | 2 ++
 1 file changed, 2 insertions(+)

Comments

Andrew Lunn Nov. 5, 2023, 3:28 p.m. UTC | #1 
On Sun, Nov 05, 2023 at 10:32:19AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Since commit c7e73b5051d6 ("ARM: imx: mach-imx6ul: remove 14x14 EVK
> specific PHY fixup")thet Ethernet PHY is no longer configured via code
> in board file.
> 
> This caused Ethernet to stop working.
> 
> Fix this problem by describing the clocks and clock-names to the
> Ethernet PHY node so that the KSZ8081 chip can be clocked correctly.
> 
> Fixes: c7e73b5051d6 ("ARM: imx: mach-imx6ul: remove 14x14 EVK specific PHY fixup")
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
Shawn Guo Dec. 5, 2023, 12:29 p.m. UTC | #2 
On Sun, Nov 05, 2023 at 10:32:19AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Since commit c7e73b5051d6 ("ARM: imx: mach-imx6ul: remove 14x14 EVK
> specific PHY fixup")thet Ethernet PHY is no longer configured via code
> in board file.
> 
> This caused Ethernet to stop working.
> 
> Fix this problem by describing the clocks and clock-names to the
> Ethernet PHY node so that the KSZ8081 chip can be clocked correctly.
> 
> Fixes: c7e73b5051d6 ("ARM: imx: mach-imx6ul: remove 14x14 EVK specific PHY fixup")
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Applied, thanks!
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/nxp/imx/imx6ul-pico.dtsi b/arch/arm/boot/dts/nxp/imx/imx6ul-pico.dtsi
index 4ffe99ed55ca..07dcecbe485d 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6ul-pico.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6ul-pico.dtsi
@@ -121,6 +121,8 @@  ethphy1: ethernet-phy@1 {
 			max-speed = <100>;
 			interrupt-parent = <&gpio5>;
 			interrupts = <6 IRQ_TYPE_LEVEL_LOW>;
+			clocks = <&clks IMX6UL_CLK_ENET_REF>;
+			clock-names = "rmii-ref";
 		};
 	};
 };