| Message ID | 20231113-j7200-usb-suspend-v1-6-ad1ee714835c@bootlin.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | usb: cdns: fix suspend on J7200 by assuming reset on resume | expand |
Hello Théo, > On our platform, suspend-to-idle or suspend-to-RAM turn the controller > off thanks to a power-domain. This compatible triggers reset on resume > behavior to reconfigure the hardware. > > Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com> > --- > arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi > index 709081cd1e7f..581905d9199e 100644 > --- a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi > @@ -788,7 +788,7 @@ pcie1_ep: pcie-ep@2910000 { > }; > > usbss0: cdns-usb@4104000 { > - compatible = "ti,j721e-usb"; > + compatible = "ti,j7200-usb"; What about keeping the old compatible as fallback in the unlikley case we have a new dtb with an old kernel ? Gregory > reg = <0x00 0x4104000 0x00 0x100>; > dma-coherent; > power-domains = <&k3_pds 288 TI_SCI_PD_EXCLUSIVE>; > > -- > 2.41.0 > >
Hello, On Tue Nov 14, 2023 at 11:01 AM CET, Gregory CLEMENT wrote: > > --- > > diff --git a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi > > index 709081cd1e7f..581905d9199e 100644 > > --- a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi > > +++ b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi > > @@ -788,7 +788,7 @@ pcie1_ep: pcie-ep@2910000 { > > }; > > > > usbss0: cdns-usb@4104000 { > > - compatible = "ti,j721e-usb"; > > + compatible = "ti,j7200-usb"; > > What about keeping the old compatible as fallback in the unlikley case > we have a new dtb with an old kernel ? I see the usecase; that will be done in V2. Thanks, -- Théo Lebrun, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
diff --git a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi index 709081cd1e7f..581905d9199e 100644 --- a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi +++ b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi @@ -788,7 +788,7 @@ pcie1_ep: pcie-ep@2910000 { }; usbss0: cdns-usb@4104000 { - compatible = "ti,j721e-usb"; + compatible = "ti,j7200-usb"; reg = <0x00 0x4104000 0x00 0x100>; dma-coherent; power-domains = <&k3_pds 288 TI_SCI_PD_EXCLUSIVE>;
On our platform, suspend-to-idle or suspend-to-RAM turn the controller off thanks to a power-domain. This compatible triggers reset on resume behavior to reconfigure the hardware. Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com> --- arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)