From patchwork Mon Nov 13 18:56:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Quinlan X-Patchwork-Id: 13454338 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D6264C4167B for ; Mon, 13 Nov 2023 18:56:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: MIME-Version:List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe :List-Id:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3HM9zJF5W5TapSa+lUtLxOnXtwDnAl6g8jNSQKsUIJQ=; b=H64pXuDhkpHG2/G6846QY66LMy 8HtH143r3tMbj3IJu7fBY67C28myJR9cUClH4rWSiB8Qx9aNISJqWbHLUmXuKmCagMWyzeGJWtmDt K5pyOy0sK/Y3OF3Sb8HBsahi4N3aPXcYcZqO/1vhO2vsuS7aJEO9ZQIwHxloeQ756vSzgr3fis5nG zGwTs37aW22B+7oRgr7cujQBPapioXGmplIxQDmalyayZ3bD3CkKn7iEpx2+rS23vIl9mQPSsLClt TkP85K0k7AdrdqhrRauYIGoN49L8PNvuh7bPFXD+GcuohLelxcTKr27NM99xqQ4jzyrv0T6OWjCNl gV25Ab3Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r2c6i-00EWYD-0F; Mon, 13 Nov 2023 18:56:24 +0000 Received: from mail-ot1-x32b.google.com ([2607:f8b0:4864:20::32b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r2c6d-00EWUu-14 for linux-arm-kernel@lists.infradead.org; Mon, 13 Nov 2023 18:56:20 +0000 Received: by mail-ot1-x32b.google.com with SMTP id 46e09a7af769-6cd09663b1cso3060314a34.3 for ; Mon, 13 Nov 2023 10:56:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1699901776; x=1700506576; darn=lists.infradead.org; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=lhIjgyAcD6l4bsfC59X5640tPmdEw/opJiuJaut0pEo=; b=cLQDYgQ7F3u1HA7TCSsR/96I8/dLcvISrdJsaQVziE58gogJtETB/lMC1Pgt/mUAgW kHaEyx9PpxwGTFnS7S/M8wXWjCFEzgjoTMhoFoPNfQmGHaRsXS+rAbocJ2L8YpOXIqkx pkd6gYEcYmVANfBUpmIMKGvO9EmO+SjDGynWo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699901776; x=1700506576; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lhIjgyAcD6l4bsfC59X5640tPmdEw/opJiuJaut0pEo=; b=bjK6JYIEE8oO1gItVj0PLjsWUvaRSJzhDqIu9K5CLXGdG3Mzs06PxzRxdERpG61iXV APoX14kytGKFPjRmJN2Y/0RASG/NM0L1WVU9tUM5FyKYLzexxHGlvFNt+txB7HSrQy/A FmitwSDw1Kdbl0C8CsSfCxZq2Oo4N53/yoZJYCX0UuX4OKV+hiW2xIibeshiDo1ZYMSx yDHEDkqg2WGEeNsEhD5ZIBPbriHLbbXj+eukOb5GjcqAMD0c+wo0cXRlPT60yHraB0ZV EpXcq8OnQTXuxNpCzalwhfbg5lAdrBIDEM/Tz7vT/oBfFjz86ZPsWBf7JbSJfPJRZNU/ Bazg== X-Gm-Message-State: AOJu0YynSMMnAF+U/vycTagVFNwXxY23hck9s4PUFEsRyVqg4E39HsmK qk/6Y6gAxW4PlHusk+BqPgDnYQ== X-Google-Smtp-Source: AGHT+IErjmkWNhMqOy4IBy2kxoU1xMlFc0sDuIp2ZP8QVqKkUQerQ7XTcAR6YKddBeX2rXPtd+IUIw== X-Received: by 2002:a9d:7e91:0:b0:6bf:1e78:cc52 with SMTP id m17-20020a9d7e91000000b006bf1e78cc52mr8877640otp.25.1699901776721; Mon, 13 Nov 2023 10:56:16 -0800 (PST) Received: from stbsrv-and-01.and.broadcom.net ([192.19.144.250]) by smtp.gmail.com with ESMTPSA id b187-20020a6334c4000000b0056b27af8715sm4366421pga.43.2023.11.13.10.56.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Nov 2023 10:56:16 -0800 (PST) From: Jim Quinlan To: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Phil Elwell , bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com Cc: Florian Fainelli , Jim Quinlan , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84?= =?utf-8?q?ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-rpi-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v8 1/2] dt-bindings: PCI: brcmstb: Add property "brcm,clkreq-mode" Date: Mon, 13 Nov 2023 13:56:05 -0500 Message-Id: <20231113185607.1756-2-james.quinlan@broadcom.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20231113185607.1756-1-james.quinlan@broadcom.com> References: <20231113185607.1756-1-james.quinlan@broadcom.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231113_105619_368378_6089D6F1 X-CRM114-Status: GOOD ( 13.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The Broadcom STB/CM PCIe HW -- a core that is also used by RPi SOCs -- requires the driver to deliberately place the RC HW one of three CLKREQ# modes. The "brcm,clkreq-mode" property allows the user to override the default setting. If this property is omitted, the default mode shall be "default". Signed-off-by: Jim Quinlan Acked-by: Conor Dooley Reviewed-by: Rob Herring --- .../devicetree/bindings/pci/brcm,stb-pcie.yaml | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml index 7e15aae7d69e..22491f7f8852 100644 --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml @@ -64,6 +64,24 @@ properties: aspm-no-l0s: true + brcm,clkreq-mode: + description: A string that determines the operating + clkreq mode of the PCIe RC HW with respect to controlling the refclk + signal. There are three different modes -- "safe", which drives the + refclk signal unconditionally and will work for all devices but does + not provide any power savings; "no-l1ss" -- which provides Clock + Power Management, L0s, and L1, but cannot provide L1 substate (L1SS) + power savings. If the downstream device connected to the RC is L1SS + capable AND the OS enables L1SS, all PCIe traffic may abruptly halt, + potentially hanging the system; "default" -- which provides L0s, L1, + and L1SS, but not compliant to provide Clock Power Management; + specifically, may not be able to meet the T_CLRon max timing of 400ns + as specified in "Dynamic Clock Control", section 3.2.5.2.2 PCI + Express Mini CEM 2.1 specification. This situation is atypical and + should happen only with older devices. + $ref: /schemas/types.yaml#/definitions/string + enum: [ safe, no-l1ss, default ] + brcm,scb-sizes: description: u64 giving the 64bit PCIe memory viewport size of a memory controller. There may be up to