diff mbox series

arm64: dts: mediatek: mt7986: drop crypto's unneeded/invalid clock name

Message ID 20231116132411.7665-1-zajec5@gmail.com (mailing list archive)
State New, archived
Headers show
Series arm64: dts: mediatek: mt7986: drop crypto's unneeded/invalid clock name | expand

Commit Message

Rafał Miłecki Nov. 16, 2023, 1:24 p.m. UTC
From: Rafał Miłecki <rafal@milecki.pl>

According to the "inside-secure,safexcel-eip97" binding "clock-names" is
required only if there are two clocks specified. If present the first
name must by "core".

Name "infra_eip97_ck" is invalid and was probably just a typo. Drop it.

Fixes: ecc5287cfe53 ("arm64: dts: mt7986: add crypto related device nodes")
Cc: Sam Shih <sam.shih@mediatek.com>
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 arch/arm64/boot/dts/mediatek/mt7986a.dtsi | 1 -
 1 file changed, 1 deletion(-)

Comments

AngeloGioacchino Del Regno Jan. 3, 2024, 1:57 p.m. UTC | #1
Il 16/11/23 14:24, Rafał Miłecki ha scritto:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> According to the "inside-secure,safexcel-eip97" binding "clock-names" is
> required only if there are two clocks specified. If present the first
> name must by "core".
> 
> Name "infra_eip97_ck" is invalid and was probably just a typo. Drop it.
> 
> Fixes: ecc5287cfe53 ("arm64: dts: mt7986: add crypto related device nodes")
> Cc: Sam Shih <sam.shih@mediatek.com>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Matthias Brugger Jan. 22, 2024, 9:07 a.m. UTC | #2
On 16/11/2023 14:24, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> According to the "inside-secure,safexcel-eip97" binding "clock-names" is
> required only if there are two clocks specified. If present the first
> name must by "core".
> 
> Name "infra_eip97_ck" is invalid and was probably just a typo. Drop it.
> 
> Fixes: ecc5287cfe53 ("arm64: dts: mt7986: add crypto related device nodes")
> Cc: Sam Shih <sam.shih@mediatek.com>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>

Applied, thanks.

> ---
>   arch/arm64/boot/dts/mediatek/mt7986a.dtsi | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
> index 24eda00e320d..017168453ec5 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
> @@ -234,7 +234,6 @@ crypto: crypto@10320000 {
>   				     <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>;
>   			interrupt-names = "ring0", "ring1", "ring2", "ring3";
>   			clocks = <&infracfg CLK_INFRA_EIP97_CK>;
> -			clock-names = "infra_eip97_ck";
>   			assigned-clocks = <&topckgen CLK_TOP_EIP_B_SEL>;
>   			assigned-clock-parents = <&apmixedsys CLK_APMIXED_NET2PLL>;
>   			status = "disabled";
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
index 24eda00e320d..017168453ec5 100644
--- a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
@@ -234,7 +234,6 @@  crypto: crypto@10320000 {
 				     <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>;
 			interrupt-names = "ring0", "ring1", "ring2", "ring3";
 			clocks = <&infracfg CLK_INFRA_EIP97_CK>;
-			clock-names = "infra_eip97_ck";
 			assigned-clocks = <&topckgen CLK_TOP_EIP_B_SEL>;
 			assigned-clock-parents = <&apmixedsys CLK_APMIXED_NET2PLL>;
 			status = "disabled";