From patchwork Wed Nov 29 21:28:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13473487 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2D607C4167B for ; Wed, 29 Nov 2023 21:29:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=goI1+ChyYl75GMtGfsJg8a2harG03X99Sj4fAqIa+mc=; b=HLJIvP1f18Aoy8 0YeAVuV80LHkZDT/KmgW1JTwE8JeWuODFZffGKS5+Mzkm7qAv50waIy8HicVAZL52COYPxCdT4qBz xmZREIQYK3RsYtUZ0DrwL71udK4MxbsXHPySclzOcHxkX2tguF5moBmDNBYUig4MTLZsBzEUGrez3 9QKuCp+Q7ILiwUiJREKbqsuVDikV7R1FtiC4TOMnoNv2q7K9Lh9AgEzIBtpURQRTFWpcb/b6dkLKf 1GpyQI5KRvfP1fFTH3IBENVHI5wUYjNGMhFkkuEUZSF0C49rsqC7dkHiqfNCbDWaLM8pVUeFDLqzD kP0jVBi3dtjFIrOzF+xA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r8S74-009KSF-0q; Wed, 29 Nov 2023 21:28:54 +0000 Received: from mail-lj1-x22d.google.com ([2a00:1450:4864:20::22d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r8S6x-009KNg-33 for linux-arm-kernel@lists.infradead.org; Wed, 29 Nov 2023 21:28:49 +0000 Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2c9b77be7ceso3800161fa.2 for ; Wed, 29 Nov 2023 13:28:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701293323; x=1701898123; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=w98h2S9ziwqYlZ5eRbk63Kp1zoQv2lCTleH6DrVq65w=; b=emgQdUJPvo+6iyjlTiSq43SSzvxl5tA2kmdM8IJKv4YOVoYAd+wWNJpH21fHby+Qda Z+gNXsXccObbiEqFLMQP1IkavRWjux4PmLngvMQ5l3wIyH0Qm8tLKbfo7SgTaKWKRhcj Ol2Eri5L2bvTJN1FzYr3PpRGshdPiAUWmufmDmPOuCqxD6mx3a6/77HaRU/cBPfeQFe1 hxMh3KrQBXFlv/noUegnSEQlcH7jKrI9aMZI7ib10qU/XxwAKVowH+T6ZOKqx7QHSLxh PHY7Ldp+AwzPxFzB70pOd1EDeYRyVhlNH91hhtOdrcsZ10iXSK6AS+dxqSPtxpPE2afo f43g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701293323; x=1701898123; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=w98h2S9ziwqYlZ5eRbk63Kp1zoQv2lCTleH6DrVq65w=; b=EeW1BdZDVUjSjXResBGT6LBex/qvZvmL7BR6RnQZsytTjhDPvH/R6cU0eGGJ2zrI9W LOVumws/M+oP1zytHmVkfA9pjW/I7l12bz+8r/pEWIr7IIh4CUGE7Y9MeYFLpYjBm0Dd ChrU0XDMua7IYtQY/e1+vnjSO6tWcFB4ZeNvMzyupKkqAN0dNwzPTbDlTntlcelstWPU LSSPF/FzLf0/0tv8c+3vHwcksZq7IXt0veNAmdizmDnzHZUJ5ggYjY0UJmHVT5kCEerR yovBnSQjzscoJn4COXBic9FcPhur3ZLU6gq4q/X9lbzR3uavLqObDHlMgFlMsMx8TXE+ lZcw== X-Gm-Message-State: AOJu0YxgO/xCBzmjH0imxVdiq5UEVoQVv1MxNUv5A+0TJpUQeaDbVl5t 3O0iOE1WfqHI0zrBMVAGLWKZYg== X-Google-Smtp-Source: AGHT+IEC56sw8UX2ii4LX1W7ed8InaZsSu/jcEIqr13PU5ZEBtax1tJX/hGuJk6YOIA9moirDg3WrA== X-Received: by 2002:a2e:874b:0:b0:2c9:c58a:b2f4 with SMTP id q11-20020a2e874b000000b002c9c58ab2f4mr1049900ljj.41.1701293323490; Wed, 29 Nov 2023 13:28:43 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id b5-20020a05651c032500b002bcdbfe36b9sm2106196ljp.111.2023.11.29.13.28.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 13:28:43 -0800 (PST) From: Linus Walleij Date: Wed, 29 Nov 2023 22:28:38 +0100 Subject: [PATCH 02/10] ASoC: cs35l33: Fix GPIO name and drop legacy include MIME-Version: 1.0 Message-Id: <20231129-descriptors-sound-cirrus-v1-2-31aa74425ff8@linaro.org> References: <20231129-descriptors-sound-cirrus-v1-0-31aa74425ff8@linaro.org> In-Reply-To: <20231129-descriptors-sound-cirrus-v1-0-31aa74425ff8@linaro.org> To: Paul Handrigan , James Schulman , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Hartley Sweeten , Alexander Sverdlin , Nikita Shubin Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231129_132847_991027_5D0A9C3E X-CRM114-Status: GOOD ( 16.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This driver includes the legacy GPIO APIs and but does not use any symbols from any of them. Drop the includes. Further the driver is requesting "reset-gpios" rather than just "gpios" from the GPIO framework. This is wrong because the gpiolib core will add "-gpios" before processing the request from e.g. device tree. Drop the suffix. The last problem means that the optional RESET GPIO has never been properly retrieved and used even if it existed, but nobody noticed. Fixes: 3333cb7187b9 ("ASoC: cs35l33: Initial commit of the cs35l33 CODEC driver.") Signed-off-by: Linus Walleij --- sound/soc/codecs/cs35l33.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/codecs/cs35l33.c b/sound/soc/codecs/cs35l33.c index 4010a2d33a33..a19a2bafb37c 100644 --- a/sound/soc/codecs/cs35l33.c +++ b/sound/soc/codecs/cs35l33.c @@ -22,13 +22,11 @@ #include #include #include -#include #include #include #include #include #include -#include #include #include "cs35l33.h" @@ -1165,7 +1163,7 @@ static int cs35l33_i2c_probe(struct i2c_client *i2c_client) /* We could issue !RST or skip it based on AMP topology */ cs35l33->reset_gpio = devm_gpiod_get_optional(&i2c_client->dev, - "reset-gpios", GPIOD_OUT_HIGH); + "reset", GPIOD_OUT_HIGH); if (IS_ERR(cs35l33->reset_gpio)) { dev_err(&i2c_client->dev, "%s ERROR: Can't get reset GPIO\n", __func__);