| Message ID | 20231130154229.22334-2-wahrenst@gmx.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM: dts: bcm2711: Add generic xHCI | expand |
On 11/30/23 07:42, Stefan Wahren wrote: > BCM2711 SoC use a power domain for the xHCI. So allow supplying this > domain in bindings. > > Signed-off-by: Stefan Wahren <wahrenst@gmx.net> > Acked-by: Conor Dooley <conor.dooley@microchip.com> > --- > Documentation/devicetree/bindings/usb/generic-xhci.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/generic-xhci.yaml b/Documentation/devicetree/bindings/usb/generic-xhci.yaml > index 594ebb3ee432..e48beaff7d0d 100644 > --- a/Documentation/devicetree/bindings/usb/generic-xhci.yaml > +++ b/Documentation/devicetree/bindings/usb/generic-xhci.yaml > @@ -49,6 +49,9 @@ properties: > - const: core > - const: reg > > + power-domains: > + maxItems: 1 That works, I am not sure whether we want to key off based upon the compatible string, but either way: Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
On Thu, Nov 30, 2023 at 09:50:17AM -0800, Florian Fainelli wrote: > On 11/30/23 07:42, Stefan Wahren wrote: > > BCM2711 SoC use a power domain for the xHCI. So allow supplying this > > domain in bindings. > > > > Signed-off-by: Stefan Wahren <wahrenst@gmx.net> > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > --- > > Documentation/devicetree/bindings/usb/generic-xhci.yaml | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/usb/generic-xhci.yaml b/Documentation/devicetree/bindings/usb/generic-xhci.yaml > > index 594ebb3ee432..e48beaff7d0d 100644 > > --- a/Documentation/devicetree/bindings/usb/generic-xhci.yaml > > +++ b/Documentation/devicetree/bindings/usb/generic-xhci.yaml > > @@ -49,6 +49,9 @@ properties: > > - const: core > > - const: reg > > > > + power-domains: > > + maxItems: 1 > > That works, I am not sure whether we want to key off based upon the > compatible string, but either way: If by "key it off" you mean selectively permit "power-domains" based on the compatible, I think that would be a good idea. There is no bcm2711 specific compatible though at present and I figured there could well be god-knows-how-many other users of generic-xhci out there that also make use of power domains, which is why I did not request it of Stefan.
diff --git a/Documentation/devicetree/bindings/usb/generic-xhci.yaml b/Documentation/devicetree/bindings/usb/generic-xhci.yaml index 594ebb3ee432..e48beaff7d0d 100644 --- a/Documentation/devicetree/bindings/usb/generic-xhci.yaml +++ b/Documentation/devicetree/bindings/usb/generic-xhci.yaml @@ -49,6 +49,9 @@ properties: - const: core - const: reg + power-domains: + maxItems: 1 + unevaluatedProperties: false required: