diff mbox series

arm64: dts: imx8mm-venice-gw7: Adjust PCI Ethernet nodes

Message ID 20231130225242.988336-1-festevam@gmail.com (mailing list archive)
State New, archived
Headers show
Series arm64: dts: imx8mm-venice-gw7: Adjust PCI Ethernet nodes | expand

Commit Message

Fabio Estevam Nov. 30, 2023, 10:52 p.m. UTC 
From: Fabio Estevam <festevam@denx.de>

As per Rob Herring's feedback:

"The ethernet device should have a node name of
'ethernet'. The 'pcie' node name and 'device_type = "pci"' is for PCI
buses/bridges only."

Do it as suggested.

Fixes: d61c5068729a ("arm64: dts: imx8mm-venice-gw7: Fix pci sub-nodes")
Suggested-by: Rob Herring <robh@kernel.org>
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi | 3 +--
 arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi | 3 +--
 arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts  | 3 +--
 3 files changed, 3 insertions(+), 6 deletions(-)

Comments

Shawn Guo Dec. 6, 2023, 3:07 a.m. UTC | #1 
On Thu, Nov 30, 2023 at 07:52:42PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> As per Rob Herring's feedback:
> 
> "The ethernet device should have a node name of
> 'ethernet'. The 'pcie' node name and 'device_type = "pci"' is for PCI
> buses/bridges only."
> 
> Do it as suggested.
> 
> Fixes: d61c5068729a ("arm64: dts: imx8mm-venice-gw7: Fix pci sub-nodes")
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Applied, thanks!
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi
index a337e8f20441..3f3f2a2c89cd 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi
@@ -178,9 +178,8 @@  pcie@3,0 {
 				#size-cells = <2>;
 				ranges;
 
-				eth1: pcie@0,0 {
+				eth1: ethernet@0,0 {
 					reg = <0x0000 0 0 0 0>;
-					device_type = "pci";
 					#address-cells = <3>;
 					#size-cells = <2>;
 					ranges;
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi
index 2247d1c4e2af..06fed9376996 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi
@@ -198,9 +198,8 @@  pcie@4,0 {
 				#size-cells = <2>;
 				ranges;
 
-				eth1: pcie@0,0 {
+				eth1: ethernet@0,0 {
 					reg = <0x0000 0 0 0 0>;
-					device_type = "pci";
 					#address-cells = <3>;
 					#size-cells = <2>;
 					ranges;
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts
index 7ef17c2b0e9d..c11260c26d0b 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts
@@ -640,9 +640,8 @@  pcie@0,0 {
 		#size-cells = <2>;
 		ranges;
 
-		eth1: pcie@0,0 {
+		eth1: ethernet@0,0 {
 			reg = <0x0000 0 0 0 0>;
-			device_type = "pci";
 			#address-cells = <3>;
 			#size-cells = <2>;
 			ranges;