From patchwork Thu Dec 7 08:38:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 13482943 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E8DA3C4167B for ; Thu, 7 Dec 2023 08:39:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WdBz2nv3hssTt7Izp3lmb7FWq1pMRe/zGf0jl4sZAZc=; b=s9r2tF2dImgvhw /bVPCAFt+tItoZUkGYWljXQhi7jFzoxFiobFCkzv9EQF22zS5ZxPKXSDzygmYQR8vBrmYq2SK49a5 /8WOB0cZEZXE3pWy5WtEg4x1JKQ647rhgooNWF2GdUAPIPBGHNI/lfV0NjHZULafytJxBz2ZLbKxe /PfrOT/hGKRjNvA44r9/atgpP1raCycKFfZ8kWHEHuGlyssg0F4aTGyDGuep7jNWnqkCDHddCm9F2 Id1QCBnYAXQ3NrSqBTkigmf9dZ96UKIMH0UF3e+OK9lyqnJPbkbjlE9/r5uUVDicuh9el0DTunxFi Zd7xNOMqzipqA676hGuA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rB9uF-00CFTa-1r; Thu, 07 Dec 2023 08:38:51 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rB9uC-00CFR6-0H; Thu, 07 Dec 2023 08:38:50 +0000 Received: from umang.jain (unknown [103.251.226.79]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E3A7CB90; Thu, 7 Dec 2023 09:38:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1701938285; bh=GuGw+LT7WjP9W1RXq84kTQWeC0YJnXrkQxHOAgp1UF0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IzW5iYKB+18Ayv59v7KMgX4dmzXmB56MQnzIcXtJdKBKt+39cl7HysP8nBynNU/wh RmG9Z74ukJpa3Y6Ebftl0HwrGguhoAiSx/iSLLNqI9S7wOcwLSJOv/ieWDVhnbibUz /oR3CDV/Qt811a8OriSz9bqpT69fOyn+uPI1A+5c= From: Umang Jain To: linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Stefan Wahren , Greg Kroah-Hartman , Dan Carpenter , Kieran Bingham , "Ricardo B . Marliere" , Umang Jain Subject: [PATCH v3 1/2] staging: vc04_services: vchiq_arm: Use %p to log pointer address Date: Thu, 7 Dec 2023 14:08:36 +0530 Message-ID: <20231207083837.153843-2-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231207083837.153843-1-umang.jain@ideasonboard.com> References: <20231207083837.153843-1-umang.jain@ideasonboard.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231207_003848_263392_B0CB9A43 X-CRM114-Status: UNSURE ( 8.12 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Solves the following Smatch warnings: service_callback() warn: argument 7 to %lx specifier is cast from pointer service_callback() warn: argument 11 to %lx specifier is cast from pointer service_callback() warn: argument 12 to %lx specifier is cast from pointer service_callback() warn: argument 13 to %lx specifier is cast from pointer %p will print the hashed pointer to dynamic debug. In order to print the unmodified pointer address, one can use the `no_hash_pointers` via kernel parameters. Signed-off-by: Umang Jain --- .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c index 4b4ff469d3a3..1579bd4e5263 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c @@ -1088,10 +1088,9 @@ service_callback(struct vchiq_instance *instance, enum vchiq_reason reason, rcu_read_unlock(); dev_dbg(service->state->dev, - "arm: service %lx(%d,%p), reason %d, header %lx, instance %lx, bulk_userdata %lx\n", - (unsigned long)user_service, service->localport, - user_service->userdata, reason, (unsigned long)header, - (unsigned long)instance, (unsigned long)bulk_userdata); + "arm: service %p(%d,%p), reason %d, header %p, instance %p, bulk_userdata %p\n", + user_service, service->localport, user_service->userdata, + reason, header, instance, bulk_userdata); if (header && user_service->is_vchi) { spin_lock(&msg_queue_spinlock);