| Message ID | 20231207185543.2699697-3-festevam@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/3] arm64: dts: imx8mp-verdin: Fix USB connector description | expand |
Hi Fabio, Am Donnerstag, 7. Dezember 2023, 19:55:43 CET schrieb Fabio Estevam: > From: Fabio Estevam <festevam@denx.de> > > The USB connector should not be placed under the dwc3 node. > > Move the USB connector out of the SoC level and use port to describe > the connection to the dwc3 controller. > > This fixes the following dt-schema warning: > > imx8mp-tqma8mpql-mba8mpxl.dtb: usb@38100000: Unevaluated properties are not > allowed ('connector' was unexpected) from schema $id: > http://devicetree.org/schemas/usb/snps,dwc3.yaml# > > Signed-off-by: Fabio Estevam <festevam@denx.de> Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com> Tested-by: Alexander Stein <alexander.stein@ew.tq-group.com> Thanks Alexander > --- > .../freescale/imx8mp-tqma8mpql-mba8mpxl.dts | 26 ++++++++++++++----- > 1 file changed, 19 insertions(+), 7 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts > b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts index > 4b161564a284..505b70cb2bd7 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts > @@ -55,6 +55,21 @@ clk_xtal25: clk-xtal25 { > clock-frequency = <25000000>; > }; > > + connector { > + compatible = "gpio-usb-b-connector", "usb-b-connector"; > + type = "micro"; > + label = "X29"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_usbcon0>; > + id-gpios = <&gpio1 10 GPIO_ACTIVE_HIGH>; > + > + port { > + usb_dr_connector: endpoint { > + remote-endpoint = <&usb3_dwc>; > + }; > + }; > + }; > + > fan0: pwm-fan { > compatible = "pwm-fan"; > pinctrl-names = "default"; > @@ -625,13 +640,10 @@ &usb_dwc3_0 { > role-switch-default-mode = "peripheral"; > status = "okay"; > > - connector { > - compatible = "gpio-usb-b-connector", "usb-b-connector"; > - type = "micro"; > - label = "X29"; > - pinctrl-names = "default"; > - pinctrl-0 = <&pinctrl_usbcon0>; > - id-gpios = <&gpio1 10 GPIO_ACTIVE_HIGH>; > + port { > + usb3_dwc: endpoint { > + remote-endpoint = <&usb_dr_connector>; > + }; > }; > };
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts index 4b161564a284..505b70cb2bd7 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts +++ b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts @@ -55,6 +55,21 @@ clk_xtal25: clk-xtal25 { clock-frequency = <25000000>; }; + connector { + compatible = "gpio-usb-b-connector", "usb-b-connector"; + type = "micro"; + label = "X29"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usbcon0>; + id-gpios = <&gpio1 10 GPIO_ACTIVE_HIGH>; + + port { + usb_dr_connector: endpoint { + remote-endpoint = <&usb3_dwc>; + }; + }; + }; + fan0: pwm-fan { compatible = "pwm-fan"; pinctrl-names = "default"; @@ -625,13 +640,10 @@ &usb_dwc3_0 { role-switch-default-mode = "peripheral"; status = "okay"; - connector { - compatible = "gpio-usb-b-connector", "usb-b-connector"; - type = "micro"; - label = "X29"; - pinctrl-names = "default"; - pinctrl-0 = <&pinctrl_usbcon0>; - id-gpios = <&gpio1 10 GPIO_ACTIVE_HIGH>; + port { + usb3_dwc: endpoint { + remote-endpoint = <&usb_dr_connector>; + }; }; };