diff mbox series

ASoC: wm1250-ev1: Fix uninitialized ret

Message ID 20231209-descriptors-sound-wlf-v1-1-5b885ce43ae1@linaro.org (mailing list archive)
State New, archived
Headers show
Series ASoC: wm1250-ev1: Fix uninitialized ret | expand

Commit Message

Linus Walleij Dec. 9, 2023, 10:01 p.m. UTC
The GPIO descriptor conversion patch left an unitialized ret behind
by mistake, fix it by getting rid of the variable altogether.

Fixes: 10a366f36e2a ("ASoC: wm1250-ev1: Convert to GPIO descriptors")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202312090953.DiUo3mue-lkp@intel.com/
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 sound/soc/codecs/wm1250-ev1.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)


---
base-commit: e0fa2154a7f46ca49105025d118261d34f7dfa7e
change-id: 20231205-descriptors-sound-wlf-e6caec3cc642

Best regards,

Comments

Mark Brown Dec. 10, 2023, 9:10 p.m. UTC | #1
On Sat, 09 Dec 2023 23:01:27 +0100, Linus Walleij wrote:
> The GPIO descriptor conversion patch left an unitialized ret behind
> by mistake, fix it by getting rid of the variable altogether.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: wm1250-ev1: Fix uninitialized ret
      commit: 5012f9d8acd411bc86229d75c0bb9517f84a60ec

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/sound/soc/codecs/wm1250-ev1.c b/sound/soc/codecs/wm1250-ev1.c
index a2a8b2a4b19b..9fa6df48799b 100644
--- a/sound/soc/codecs/wm1250-ev1.c
+++ b/sound/soc/codecs/wm1250-ev1.c
@@ -129,7 +129,6 @@  static int wm1250_ev1_pdata(struct i2c_client *i2c)
 {
 	struct wm1250_ev1_pdata *pdata = dev_get_platdata(&i2c->dev);
 	struct wm1250_priv *wm1250;
-	int ret;
 
 	if (!pdata)
 		return 0;
@@ -165,7 +164,7 @@  static int wm1250_ev1_pdata(struct i2c_client *i2c)
 
 	dev_set_drvdata(&i2c->dev, wm1250);
 
-	return ret;
+	return 0;
 }
 
 static int wm1250_ev1_probe(struct i2c_client *i2c)