From patchwork Sat Dec 9 22:01:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13486114 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5223DC4167B for ; Sat, 9 Dec 2023 22:02:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Message-Id:MIME-Version:Subject: Date:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=ogJMioGOm/CNJoIcRa50WKXUd5Nl2gCZfCLY+BwSpqo=; b=S8xqmD0nwL1Gej yw4fBWWelUxmaeD2p1EmfJAuoxGNJ4tZRVxX7Gw+9zkMWZGZtnkf1Rf7XbviV79AdGDkRUgP3T1aH xajPMpxWGNpYlQj8Ia4TQVhqGoSanxcFgZygRJ4lgmGn557ejD5rgsnUiWai2zqNzHhEs3Mx9PYVa NpRbc11AKx9XGOk0VCXY3yT6x8VTh7H9pIXcjRymnLHhSLEkJpUzotOA/qmoszLfNS+ASa63TfeIZ vP0i/gRkxRwnr/eRtzAJEAikukffCn6u7MGl1McxGU/TF17mBf1g7VdC7f0YpVvTY226cjCDzo1Rb SDYehfYzCcoScaUaKRfw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rC5OL-000aya-05; Sat, 09 Dec 2023 22:01:45 +0000 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rC5OG-000axt-2b for linux-arm-kernel@lists.infradead.org; Sat, 09 Dec 2023 22:01:42 +0000 Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-50be4f03b06so3146092e87.0 for ; Sat, 09 Dec 2023 14:01:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702159297; x=1702764097; darn=lists.infradead.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=Rf6kxtFYggdfbxJYCVZWg+cgkdXOPlRkn+YTuzn4osc=; b=G4AyZuiymKpIDvdqk9CbJEGaJF2k63Rt0n1Uvo0N6I2Yw2OvNF7jxDbVyTRbPiV7yr WpeYvX78hVitTf9dSZskMRrLMd6Ah9IOsEjM50Yr9nIiUdYt2yK5m3Anp3vuVhoMtN+b OYbezZ1vqILKTvLzzXmHVET2oOuYS5cAdkJR3XLClMlPd/GnFqT0W5v9NZESFtcrdbwQ lUjhkQffttLFgyor0CUuoCv3FeRnEhSYGGQNtMStbqTF+rP4GBdwmKvYiyW9iQC1PO9k HWgjYlXaZLJO+oeCo3nbTGzl4eMYyNh5+46MJaCV29FPkAJSV+fxNcpLLKZz9n4/zszu Ybjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702159297; x=1702764097; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Rf6kxtFYggdfbxJYCVZWg+cgkdXOPlRkn+YTuzn4osc=; b=ohl7XaMfpvxKPZGqCycs4uK9xM+AyxR9/+hR8tOjoTAxGOJNMXoBZa5JuhWsMDCay/ dEWokl5bnMonq/tlbrUUqjetVhx8gLAH65WXmRT1SFT0zGPWRpQoJ+9gDEc4mU/kmNU4 SIOASiJg5KvFfTABEksIhRwDF5RW3xjB8FuP2s+s8XHjqrf+E64excCWLfKflWIMrBuL 4v4JTdWim6qVhq/t3YrLvOs6GygdmchrQaaEFxPKVKlMnmWzvouPS8YaaEmJKfTglY6c TLRMWsy0Y7Batj/KwKByDIKwMFhHGj5XRmD5U6e96qCPJaP0hwcVw3yz0R1ZlUL5/+p9 QFcA== X-Gm-Message-State: AOJu0YyO8Xad33mRlZPkEUahVH1eKmvprxO5K+opUk6VZKRkZDeA767+ xiNFOr3Rp280qb0ndsf3wWB3VA== X-Google-Smtp-Source: AGHT+IFBUEVjY+K4P0Zha/3JhCUnzGdXx6Cwpnkna/C2qd7ZWtdFCT0oVacrclwVM5TqPh0T2pmeTQ== X-Received: by 2002:a05:6512:3282:b0:50c:9e1:bf76 with SMTP id p2-20020a056512328200b0050c09e1bf76mr514417lfe.9.1702159297223; Sat, 09 Dec 2023 14:01:37 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id s16-20020a056512215000b0050be73a1c27sm626098lfr.258.2023.12.09.14.01.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Dec 2023 14:01:36 -0800 (PST) From: Linus Walleij Date: Sat, 09 Dec 2023 23:01:27 +0100 Subject: [PATCH] ASoC: wm1250-ev1: Fix uninitialized ret MIME-Version: 1.0 Message-Id: <20231209-descriptors-sound-wlf-v1-1-5b885ce43ae1@linaro.org> X-B4-Tracking: v=1; b=H4sIALbjdGUC/3WNywrCMBBFf6XM2pEmfSCu/A/pIk6m7UBJykSrU vrvxoJLl+fCOXeFxCqc4FysoLxIkhgymEMBNLowMIrPDLa0lbFlg54Tqcz3qAlTfASPz6lHbsk xVURtbSG7s3Ivr7177TKPkrLx3m8W811/xdOf4mKwRKq9u7V9Yw3TZZLgNB6jDtBt2/YBUB6db rsAAAA= To: Krzysztof Kozlowski , Alim Akhtar , Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Mark Brown Cc: patches@opensource.cirrus.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-sound@vger.kernel.org, kernel test robot , Linus Walleij X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231209_140141_281657_EFF6899E X-CRM114-Status: GOOD ( 11.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The GPIO descriptor conversion patch left an unitialized ret behind by mistake, fix it by getting rid of the variable altogether. Fixes: 10a366f36e2a ("ASoC: wm1250-ev1: Convert to GPIO descriptors") Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202312090953.DiUo3mue-lkp@intel.com/ Signed-off-by: Linus Walleij --- sound/soc/codecs/wm1250-ev1.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- base-commit: e0fa2154a7f46ca49105025d118261d34f7dfa7e change-id: 20231205-descriptors-sound-wlf-e6caec3cc642 Best regards, diff --git a/sound/soc/codecs/wm1250-ev1.c b/sound/soc/codecs/wm1250-ev1.c index a2a8b2a4b19b..9fa6df48799b 100644 --- a/sound/soc/codecs/wm1250-ev1.c +++ b/sound/soc/codecs/wm1250-ev1.c @@ -129,7 +129,6 @@ static int wm1250_ev1_pdata(struct i2c_client *i2c) { struct wm1250_ev1_pdata *pdata = dev_get_platdata(&i2c->dev); struct wm1250_priv *wm1250; - int ret; if (!pdata) return 0; @@ -165,7 +164,7 @@ static int wm1250_ev1_pdata(struct i2c_client *i2c) dev_set_drvdata(&i2c->dev, wm1250); - return ret; + return 0; } static int wm1250_ev1_probe(struct i2c_client *i2c)