diff mbox series

[v2,3/3] arm64: dts: imx8mp-dhcom-pdk3: Describe the USB-C connector

Message ID 20231212174847.759164-3-festevam@gmail.com (mailing list archive)
State New, archived
Headers show
Series [v2,1/3] dt-bindings: extcon: ptn5150: Describe the USB connector | expand

Commit Message

Fabio Estevam Dec. 12, 2023, 5:48 p.m. UTC 
From: Fabio Estevam <festevam@denx.de>

Describe the PTN5150 USB-C connector to improve the devicetree description
and fix the following dt-schema warning:

imx8mp-dhcom-pdk3.dtb: typec@3d: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/extcon/extcon-ptn5150.yaml#
	
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
Changes since v1:
- None

 arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dts | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

Comments

Shawn Guo Dec. 14, 2023, 3:07 a.m. UTC | #1 
On Tue, Dec 12, 2023 at 02:48:47PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Describe the PTN5150 USB-C connector to improve the devicetree description
> and fix the following dt-schema warning:
> 
> imx8mp-dhcom-pdk3.dtb: typec@3d: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
> 	from schema $id: http://devicetree.org/schemas/extcon/extcon-ptn5150.yaml#
> 	
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Applied, thanks!
Marek Vasut Jan. 13, 2024, 9:30 p.m. UTC | #2 
On 12/14/23 04:07, Shawn Guo wrote:
> On Tue, Dec 12, 2023 at 02:48:47PM -0300, Fabio Estevam wrote:
>> From: Fabio Estevam <festevam@denx.de>
>>
>> Describe the PTN5150 USB-C connector to improve the devicetree description
>> and fix the following dt-schema warning:
>>
>> imx8mp-dhcom-pdk3.dtb: typec@3d: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
>> 	from schema $id: http://devicetree.org/schemas/extcon/extcon-ptn5150.yaml#
>> 	
>> Signed-off-by: Fabio Estevam <festevam@denx.de>
> 
> Applied, thanks!

This patch breaks USB-C port on this board.

If I plug in USB-C storage device, it is not detected. If I revert this 
patch, it is detected.

Please drop this patch for now.
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dts b/arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dts
index b749e28e5ede..fea67a9282f0 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dts
@@ -175,10 +175,14 @@  typec@3d {
 				pinctrl-names = "default";
 				pinctrl-0 = <&pinctrl_ptn5150>;
 
-				port {
-
-					ptn5150_out_ep: endpoint {
-						remote-endpoint = <&dwc3_0_ep>;
+				connector {
+					compatible = "usb-c-connector";
+					label = "USB-C";
+
+					port {
+						ptn5150_out_ep: endpoint {
+							remote-endpoint = <&dwc3_0_ep>;
+						};
 					};
 				};
 			};