diff mbox series

[v2,1/3] arm64: dts: imx8mp-verdin: Fix USB connector description

Message ID 20231213211847.1096033-1-festevam@gmail.com (mailing list archive)
State New, archived
Headers show
Series [v2,1/3] arm64: dts: imx8mp-verdin: Fix USB connector description | expand

Commit Message

Fabio Estevam Dec. 13, 2023, 9:18 p.m. UTC 
From: Fabio Estevam <festevam@denx.de>

The USB connector should not be placed under the dwc3 node.

Move the USB connector out of the SoC level and use port to describe
the connection to the dwc3 controller.

This fixes the following dt-schema warning:

imx8mp-verdin-wifi-mallow.dtb: usb@32f10100: usb@38100000: Unevaluated properties are not allowed ('connector' was unexpected)
	from schema $id: http://devicetree.org/schemas/usb/fsl,imx8mp-dwc3.yaml#
	
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
Changes since v1:
- None

 .../boot/dts/freescale/imx8mp-verdin.dtsi     | 30 +++++++++++++------
 1 file changed, 21 insertions(+), 9 deletions(-)

Comments

Shawn Guo Dec. 14, 2023, 3:06 a.m. UTC | #1 
On Wed, Dec 13, 2023 at 06:18:45PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> The USB connector should not be placed under the dwc3 node.
> 
> Move the USB connector out of the SoC level and use port to describe
> the connection to the dwc3 controller.
> 
> This fixes the following dt-schema warning:
> 
> imx8mp-verdin-wifi-mallow.dtb: usb@32f10100: usb@38100000: Unevaluated properties are not allowed ('connector' was unexpected)
> 	from schema $id: http://devicetree.org/schemas/usb/fsl,imx8mp-dwc3.yaml#
> 	
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Applied all, thanks!
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
index 04f2083c4ab2..c3305f0d4001 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
@@ -45,6 +45,23 @@  backlight_mezzanine: backlight-mezzanine {
 		status = "disabled";
 	};
 
+	connector {
+		compatible = "gpio-usb-b-connector", "usb-b-connector";
+		id-gpios = <&gpio2 10 GPIO_ACTIVE_HIGH>;
+		label = "Type-C";
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_usb_1_id>;
+		self-powered;
+		type = "micro";
+		vbus-supply = <&reg_usb1_vbus>;
+
+		port {
+			usb_dr_connector: endpoint {
+				remote-endpoint = <&usb3_dwc>;
+			};
+		};
+	};
+
 	gpio-keys {
 		compatible = "gpio-keys";
 		pinctrl-names = "default";
@@ -835,15 +852,10 @@  &usb_dwc3_0 {
 	srp-disable;
 	usb-role-switch;
 
-	connector {
-		compatible = "gpio-usb-b-connector", "usb-b-connector";
-		id-gpios = <&gpio2 10 GPIO_ACTIVE_HIGH>;
-		label = "Type-C";
-		pinctrl-names = "default";
-		pinctrl-0 = <&pinctrl_usb_1_id>;
-		self-powered;
-		type = "micro";
-		vbus-supply = <&reg_usb1_vbus>;
+	port {
+		usb3_dwc: endpoint {
+			remote-endpoint = <&usb_dr_connector>;
+		};
 	};
 };