From patchwork Mon Dec 18 10:57:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Stein X-Patchwork-Id: 13496612 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A9F0BC35274 for ; Mon, 18 Dec 2023 10:58:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cMVuJQSxBD7ZZGFdkTTEQ9ihiN+DnXvP3+DsS4zYFjg=; b=m+/IxpVeZSiV6v siH1iwPVgpDyHPpaQ6lMwMM19PnGFxUJUnOOJO0WhTrJyjqcD//30q4QOhOFXAbd3Zq6UJs7rg5xz DoCvPMxpUL+zEDsD8iVZqKBS4nAJMGvH80E4cvzKZ7WycovijVnvsoFUF+scajUCvFiIUuR9dA4gC IlQOCRWozCCQbRvXVfRxuHvEhZ89SE5Iw+7GKs5ifEF8FCAdWMcOVE4gO20/XK0ROTd57uh2vmqnB jtIb7lEgSfvdJpqtfuEMgz2PdE1XNtT2pUGRKeSJy1EO5ePjwA7xGVBrFJY3QfmWA2EajorqTCuKC fFNkz3w6u0X14GNctvaQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rFBJb-009wke-31; Mon, 18 Dec 2023 10:57:39 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rFBJP-009waQ-0T for linux-arm-kernel@lists.infradead.org; Mon, 18 Dec 2023 10:57:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1702897047; x=1734433047; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=2lv189ze1HjPcTpyti3gs1HfX3zuxk+ObuRHYy8a0Yc=; b=LvZrt/fBZKJtYKzLq+QgB6+Spm2bpfqDn8YPoIytW49HqaO+Q9JkWyLv W0ITv/d0CN/pGZqlukffX3tpC51zYYYaclmez3ZbKv508P2j2lQBlubSp RQZ69UwKouA/7es9Wj5gy61EjNqnjCg3yu2EwvbJVXEibGgSaObfkUiSn PXPAHN6ljL+HMZIsi7Mia8Hu4xBH7Ufb5Y91hYrkCGgKz+GUMLELPEULc 2H5adVunz+psrAoB+2FSKW74g9HHDZwgWNztGbnr6kgvzNf7cjsxse3wW d9CMtBDP5gQGCEcuLQqj57J8sGBcgcBKrF76rfJabYQVmgsvaalrZP2BN w==; X-IronPort-AV: E=Sophos;i="6.04,285,1695679200"; d="scan'208";a="34559832" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 18 Dec 2023 11:57:21 +0100 Received: from steina-w.tq-net.de (steina-w.tq-net.de [10.123.53.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 71814280084; Mon, 18 Dec 2023 11:57:21 +0100 (CET) From: Alexander Stein To: Liu Ying , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Shawn Guo , Sascha Hauer , Fabio Estevam Cc: Alexander Stein , Pengutronix Kernel Team , NXP Linux Team , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 3/6] drm/bridge: imx: imx-ldb-helper: Use dev_err_probe Date: Mon, 18 Dec 2023 11:57:15 +0100 Message-Id: <20231218105718.2445136-4-alexander.stein@ew.tq-group.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231218105718.2445136-1-alexander.stein@ew.tq-group.com> References: <20231218105718.2445136-1-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231218_025727_479872_E16C8DA8 X-CRM114-Status: GOOD ( 12.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This simplifies the code and gives additional information upon deferral. Signed-off-by: Alexander Stein Reviewed-by: Francesco Dolcini --- drivers/gpu/drm/bridge/imx/imx-ldb-helper.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/bridge/imx/imx-ldb-helper.c b/drivers/gpu/drm/bridge/imx/imx-ldb-helper.c index 6967325cd8ee..9b872cfb849c 100644 --- a/drivers/gpu/drm/bridge/imx/imx-ldb-helper.c +++ b/drivers/gpu/drm/bridge/imx/imx-ldb-helper.c @@ -172,7 +172,7 @@ int ldb_find_next_bridge_helper(struct ldb *ldb) { struct device *dev = ldb->dev; struct ldb_channel *ldb_ch; - int ret, i; + int i; for (i = 0; i < MAX_LDB_CHAN_NUM; i++) { ldb_ch = ldb->channel[i]; @@ -182,14 +182,9 @@ int ldb_find_next_bridge_helper(struct ldb *ldb) ldb_ch->next_bridge = devm_drm_of_get_bridge(dev, ldb_ch->np, 1, 0); - if (IS_ERR(ldb_ch->next_bridge)) { - ret = PTR_ERR(ldb_ch->next_bridge); - if (ret != -EPROBE_DEFER) - DRM_DEV_ERROR(dev, - "failed to get next bridge: %d\n", - ret); - return ret; - } + if (IS_ERR(ldb_ch->next_bridge)) + return dev_err_probe(dev, PTR_ERR(ldb_ch->next_bridge), + "failed to find next bridge\n"); } return 0;