From patchwork Mon Dec 18 12:54:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Stein X-Patchwork-Id: 13496881 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 82D0EC35274 for ; Mon, 18 Dec 2023 12:55:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TwCn4aHy3XEW5tYi2FqTVlBl18mVdhPtl+fZFO69JFw=; b=EyG6/pynxzHka5 RN25Z5glB70DvB8YWqNUytan1kJJ55ZT/z839Lxh9av4tXUIEKkWGR2wksF8EprT/PdpjP4Ahjxt1 2/PrlQoavcdjqHfaHFBUWcovL8tCFeUDc4O5DG70fae7zdSd3oKvysLyT9f9tYOxeEnlLEvKgG9Tv 4j2bfI0NUFxUwJ+1zT3ugJnd9xmjlz/po50PMJ4xiENM8mmdP6vsDXBIeQ1/Wtun0+UxrrwzhaiWR zDl2aSYUZlyWz/CBpHrXHD3Pn1F+eDlhJ9KJ7zQh88bjk9Bu+8m5c1OJ8Eh7DgOlZz7BOARVdDSNd iELaGTY0LrslioUPCMAw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rFD9K-00Aie2-2i; Mon, 18 Dec 2023 12:55:10 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rFD9C-00AiXa-2i for linux-arm-kernel@lists.infradead.org; Mon, 18 Dec 2023 12:55:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1702904103; x=1734440103; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=PyWZK/EiK2Ut49JIy/z+GCFcoRIygV/H7/Sxoqg51rI=; b=fsMJrkZrldUnOZYDc4A0zG0vlvmdTKqH1kiAteyRKYgPIilS1qhwmdWZ /YTwAjOroMkdzo7YaqDhBeknWjaiOZ+cE0Ws68dPRBPVv0z/3INZNI36k DGnNl+DIM+GXhrfPpMBHYoKFvaTTZ73xlc8O0TfvTiDmL2Q7eiJtCKOTM ei3qe9zDWjVxZu0DjuNxa6WiBij5BCJNtXBXIiymjkxztrcaRd6A2mZc9 NmSkvfLJhf9d6tlxrn5keb8kNlPFk3BVuHQwU85j9qP174AjRU1buJnWR onLt0k111sAbYLQ7l2q/LTFWKZ+1XM6cjbtB/yqeXJyGWis/xtmAcANpC Q==; X-IronPort-AV: E=Sophos;i="6.04,285,1695679200"; d="scan'208";a="34562690" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 18 Dec 2023 13:54:59 +0100 Received: from steina-w.tq-net.de (steina-w.tq-net.de [10.123.53.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 435AF280085; Mon, 18 Dec 2023 13:54:59 +0100 (CET) From: Alexander Stein To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Fabio Estevam Cc: Alexander Stein , Pengutronix Kernel Team , NXP Linux Team , linux@ew.tq-group.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 02/23] ARM: dts: imx7[d]-mba7: Move ethernet PHY reset into PHY node Date: Mon, 18 Dec 2023 13:54:38 +0100 Message-Id: <20231218125459.2769733-3-alexander.stein@ew.tq-group.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231218125459.2769733-1-alexander.stein@ew.tq-group.com> References: <20231218125459.2769733-1-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231218_045503_181554_51F77F3C X-CRM114-Status: GOOD ( 10.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Split pinctrl as well. 'reset-deassert-us' is added with a small safe margin. Signed-off-by: Alexander Stein --- arch/arm/boot/dts/nxp/imx/imx7-mba7.dtsi | 13 ++++++++++--- arch/arm/boot/dts/nxp/imx/imx7d-mba7.dts | 13 ++++++++++--- 2 files changed, 20 insertions(+), 6 deletions(-) diff --git a/arch/arm/boot/dts/nxp/imx/imx7-mba7.dtsi b/arch/arm/boot/dts/nxp/imx/imx7-mba7.dtsi index 2e406cc7d292..c2be1a75f70d 100644 --- a/arch/arm/boot/dts/nxp/imx/imx7-mba7.dtsi +++ b/arch/arm/boot/dts/nxp/imx/imx7-mba7.dtsi @@ -214,8 +214,6 @@ &fec1 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_enet1>; phy-mode = "rgmii-id"; - phy-reset-gpios = <&gpio7 15 GPIO_ACTIVE_LOW>; - phy-reset-duration = <1>; phy-supply = <®_fec1_pwdn>; phy-handle = <ðphy1_0>; fsl,magic-packet; @@ -228,10 +226,15 @@ mdio { ethphy1_0: ethernet-phy@0 { compatible = "ethernet-phy-ieee802.3-c22"; reg = <0>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_enet1_phy>; ti,rx-internal-delay = ; ti,tx-internal-delay = ; ti,fifo-depth = ; ti,clk-output-sel = ; + reset-gpios = <&gpio7 15 GPIO_ACTIVE_LOW>; + reset-assert-us = <1000>; + reset-deassert-us = <500>; }; }; }; @@ -366,7 +369,11 @@ pinctrl_enet1: enet1grp { , , , - , + ; + }; + + pinctrl_enet1_phy: enet1phygrp { + fsl,pins = /* Reset: SION, 100kPU, SRE_FAST, DSE_X1 */ , /* INT/PWDN: SION, 100kPU, HYS, SRE_FAST, DSE_X1 */ diff --git a/arch/arm/boot/dts/nxp/imx/imx7d-mba7.dts b/arch/arm/boot/dts/nxp/imx/imx7d-mba7.dts index 79a6d82b453a..4ea1801a7aed 100644 --- a/arch/arm/boot/dts/nxp/imx/imx7d-mba7.dts +++ b/arch/arm/boot/dts/nxp/imx/imx7d-mba7.dts @@ -21,8 +21,6 @@ &fec2 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_enet2>; phy-mode = "rgmii-id"; - phy-reset-gpios = <&gpio2 28 GPIO_ACTIVE_LOW>; - phy-reset-duration = <1>; phy-supply = <®_fec2_pwdn>; phy-handle = <ðphy2_0>; fsl,magic-packet; @@ -35,10 +33,15 @@ mdio { ethphy2_0: ethernet-phy@0 { compatible = "ethernet-phy-ieee802.3-c22"; reg = <0>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_enet2_phy>; ti,rx-internal-delay = ; ti,tx-internal-delay = ; ti,fifo-depth = ; ti,clk-output-sel = ; + reset-gpios = <&gpio2 28 GPIO_ACTIVE_LOW>; + reset-assert-us = <1000>; + reset-deassert-us = <500>; }; }; }; @@ -62,7 +65,11 @@ pinctrl_enet2: enet2grp { , , , - , + ; + }; + + pinctrl_enet2_phy: enet2phygrp { + fsl,pins = /* Reset: SION, 100kPU, SRE_FAST, DSE_X1 */ , /* INT/PWDN: SION, 100kPU, HYS, SRE_FAST, DSE_X1 */