From patchwork Tue Dec 19 17:00:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alex Bee X-Patchwork-Id: 13498600 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 537A8C41535 for ; Tue, 19 Dec 2023 17:03:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/ylaN4vKeDMx8ggmkBcAmmvkc+POsQgebQSbY4Yu514=; b=Us3Lt9X7eEQYse 679Okf1I/Hl28ADgK8R8qTbioKrfrWD55OT924690RzpeAU/JdhNcIfUn8Ltwg0M6DUVWGjEQJ9sY Z4O6zfGVYt8dYigILcR+qOX2n3fc9OLXJMDpgfGSNqz4Xj/iX0lSJe6xWHzfJxhN60/cI2Osudn2K H3qcQdif8hI0rDye8SonFFkuMUjXOe6bSc7I2cnfFzSDnRz0PMQ0SPfNN12TMUxElK3jjnfbJoHMU IyiUNSzGRhtfiP1a4CUumfMFmujr4yxgJvPuF/lT7hA7XmSAKgmOyTSHnUwnTgbOn+dJzXNRzwxh3 gQwWIUJyuSk40V22LE+A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rFdUY-00Epg3-04; Tue, 19 Dec 2023 17:02:50 +0000 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rFdTE-00EoFW-15; Tue, 19 Dec 2023 17:01:31 +0000 Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-33677fb38a3so110956f8f.0; Tue, 19 Dec 2023 09:01:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703005286; x=1703610086; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=h8JOWn9GU9Nla83BWtTSRAknxxtN8+L8TovD6+V8Mi4=; b=nR5RC1OZoAg2sDh8WqgMXq5zY4EduZPTh5NAWq0IjQf+QCXlWpfgNnXJxFIDgeJVta 3diU7hqMgIQYgcWcC01Jk/G/Asr/tXlKPDVO2pZsXRferjEYoAmd1e5HfeKMnwyu52Nl gpz1MtzSv6OXgxw3Hl3sTkQojJL6Gd3jyE1F48THilEErCCZOsLSnla+TTqjqcDbuD0J lZSnzaj65E6BNkGF2gAKTBL7vN3cXadIoKuXLOEmQlq3vpk8YqQphiyHbA/DVoIeMApW 4Abo5GrVKDQuShboA8fSt1qF7t/+YojGFzJGYH0kHLy3HcwZYYNp6ycqycqct1JOZpEO qaZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703005286; x=1703610086; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h8JOWn9GU9Nla83BWtTSRAknxxtN8+L8TovD6+V8Mi4=; b=QFWyIFctAzeKZFDNPKTIxt6VnsJj3vK4rvkL3gBZSHST5ZhiioLOdEyXR0iZ0iVjJt beCas1DYyQQ9qSaP2M5yDac+ZWlXv4rlXhIFj59zCnwE+zIG1gOUBtmEb3b+RQtnUNsc rEmWLhtEeEPe97WpPOmYXH+XWkn8bFBH57fpXEJqJ0DKjbnoD3G9f6b3DCMbBusYyR94 zhK7HHTZxOm3ITnMCSB3ECKXlQdXLjV8BT2SwUZyAlaEMY7PBcC5Zyf0ER2ek5jBfZZ4 Rb4DSyxrsW9zMATuPolKPWwIG/GCOv1udyye7JT99l6/EIEvKAFeqJ6IsUhKUlUdW6Fz AAzw== X-Gm-Message-State: AOJu0YyRq+XgKhagyoTLOPEelpoq1PaOPMoJvrxfgciIapRNhn5XgGqi SmMExOxFI8AFHENKxSMD/A== X-Google-Smtp-Source: AGHT+IFvESFKFDDj+P6Hp56SjNt5xISbZzFocZziXX7FumH32R2Au9gUTKsNb6b63EcE9fIlyJTiZg== X-Received: by 2002:a05:600c:2492:b0:40c:5583:c6b7 with SMTP id 18-20020a05600c249200b0040c5583c6b7mr6324639wms.109.1703005286360; Tue, 19 Dec 2023 09:01:26 -0800 (PST) Received: from U4.lan ([2a02:810b:f40:4300:7ae5:3e:d1c6:a138]) by smtp.gmail.com with ESMTPSA id i7-20020a05600c354700b0040d2805d158sm3225878wmq.48.2023.12.19.09.01.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 09:01:26 -0800 (PST) From: Alex Bee To: Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Alex Bee Subject: [PATCH v3 21/29] drm/rockchip: inno_hdmi: Don't power up the phy after resetting Date: Tue, 19 Dec 2023 18:00:51 +0100 Message-ID: <20231219170100.188800-22-knaerzche@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231219170100.188800-1-knaerzche@gmail.com> References: <20231219170100.188800-1-knaerzche@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231219_090128_403436_F87EE949 X-CRM114-Status: GOOD ( 14.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org inno_hdmi_reset is only ever called when initializing the controller. At this point it’s completely uneccessary to power up the PHY, since all what has to work at this point is the DDC bus. The phy will be powered up correctly when a mode is set in inno_hdmi_encoder_enable and disabled in inno_hdmi_encoder_disable. Set it to LOWER_PWR after resetting the controller. Signed-off-by: Alex Bee --- changes in v3: - new patch drivers/gpu/drm/rockchip/inno_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c index e6d37772500c..9fea464b6234 100644 --- a/drivers/gpu/drm/rockchip/inno_hdmi.c +++ b/drivers/gpu/drm/rockchip/inno_hdmi.c @@ -202,7 +202,7 @@ static void inno_hdmi_reset(struct inno_hdmi *hdmi) val = v_REG_CLK_INV | v_REG_CLK_SOURCE_SYS | v_PWR_ON | v_INT_POL_HIGH; hdmi_modb(hdmi, HDMI_SYS_CTRL, msk, val); - inno_hdmi_set_pwr_mode(hdmi, NORMAL); + inno_hdmi_set_pwr_mode(hdmi, LOWER_PWR); } static void inno_hdmi_disable_frame(struct inno_hdmi *hdmi,