From patchwork Wed Dec 20 20:35:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Jernej_=C5=A0krabec?= X-Patchwork-Id: 13500440 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35F46C3DA6E for ; Wed, 20 Dec 2023 20:36:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2XU8QCxlt/M9Qi6zvBcscvGURamcnYBDWhhhtMg8hG0=; b=LHAE7uMsCvm3bP ae+z+AllMSskJiIytjvCArhoTj2fz/PPxDIDFnMiugoCuqhl6lqUcUE2X3qccYIx3Aw9rji2NMq8g 0gUrAdCnDWWICtro2weQQtJ+71xyWCDriK1Pq32HlLzzMSYCz118KaFsqEH35rVwyaLtsxPHMsNAL PP/a/q7cqZzw9EKr/8oyJgeivQL08PAXwMjIqZIprHHpcOpe8BXwfYRauAENawhAzBhuBwzpv0Z0d aBCmAKxJmo5EjeSgDDTQG0FgTXiV2Zl6SSY50H0o7knENj1C0YAZzlZqIWEpKndXKRPxiQZ9VU3tX aw0h1yIDE6R8vHf3mO5w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rG3Im-000qvL-17; Wed, 20 Dec 2023 20:36:24 +0000 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rG3Ie-000qs4-31 for linux-arm-kernel@lists.infradead.org; Wed, 20 Dec 2023 20:36:18 +0000 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-40c2308faedso1328905e9.1 for ; Wed, 20 Dec 2023 12:36:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703104573; x=1703709373; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fAeNatgENX3HfSxaqLZ4jbMgumQ+tBQiP8BhXetmc10=; b=k7fs86rFB/JBrzkfa7eChPEucVjSwT8gMJNqyUyVbMTslZbPGRsL961eCCRJHjopwq qlaCu5+WKU+nN/nmHpRJUbYkjTyTPzTxMZePWVZuFxoW+BSSlRWkR5KgLL29L0pM65cs X/5AAJtb1NtELyGXWZQfkbi+wrc70AO4BqszIF7rTrkjxOLy/4mUM3G1yRMNElIzt8tq Il9SOCuGysDBNvpOWWFGGG9jV3iUU0sSu8Zap2iN46bAY89gc6XP/6NUL2JJI0ZaKXYI BfE+vZFA8BkRsqP9yT9MNgO6zfZEXRSievRwG2UrpE4Lz1jJjSjgwT63ZqXOsj/wruRN L1oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703104573; x=1703709373; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fAeNatgENX3HfSxaqLZ4jbMgumQ+tBQiP8BhXetmc10=; b=NKrClWDsWORp+XNkk2qAao8/iD2gVmu2KVBGK+7pCLqo7l1ET2KTzWkuk3GZOAUyYN rKq2Z8siWQIswGP3Ymo7ESuulQTtNXt6lDUsgsfhUe7OYiS00leouUu/vdj+YFCTLeNJ ivfwRnySgb3c0gh+0XndxsDSZb6D+YGIwaJ7dOnixpLwKsBzGxxFjK6orgLY/1z6L1in FvTeZnEUc9EBiXzXb+zFdr1gBZPQG77RbsG7xOEJoPHvRU5ENajlNU8eD1iA1QeBTehh Ab7Su0ab4j/rQqRT9zBLbw/+K+t5RpmSc7Kpq+hNCD9Utr7RCYzEThR8fmeqdrfyX6Xj 1fiw== X-Gm-Message-State: AOJu0YzlHC2H5+NLqag2Y7SNQ6RhZizN9aneIeRe1R6DxbWTXU36+VMQ gR6Nx5sztLElDHpbjpDNnyM= X-Google-Smtp-Source: AGHT+IG8O/e8IeFMn3xNIU6oCdHt0cDdgg6cfuGKM3ycqPI/asSdTF9PcYT8bYSKYB/qauPHaDDUKQ== X-Received: by 2002:a05:600c:ad4:b0:40c:711:f492 with SMTP id c20-20020a05600c0ad400b0040c0711f492mr146701wmr.181.1703104572845; Wed, 20 Dec 2023 12:36:12 -0800 (PST) Received: from localhost.localdomain (82-149-12-148.dynamic.telemach.net. [82.149.12.148]) by smtp.gmail.com with ESMTPSA id v14-20020a05600c444e00b0040c58e410a3sm8703224wmn.14.2023.12.20.12.36.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Dec 2023 12:36:12 -0800 (PST) From: Jernej Skrabec To: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, wens@csie.org, samuel@sholland.org, andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Ondrej Jirman , Corentin Labbe , Jernej Skrabec Subject: [PATCH v5 2/3] arm64: dts: allwinner: orange-pi-3: Enable ethernet Date: Wed, 20 Dec 2023 21:35:36 +0100 Message-ID: <20231220203537.83479-3-jernej.skrabec@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231220203537.83479-1-jernej.skrabec@gmail.com> References: <20231220203537.83479-1-jernej.skrabec@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231220_123616_980013_F9FBCD67 X-CRM114-Status: GOOD ( 13.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Ondrej Jirman Orange Pi 3 has two regulators that power the Realtek RTL8211E PHY. According to the datasheet, both regulators need to be enabled at the same time, or that "phy-io" should be enabled slightly earlier than "ephy" regulator. RTL8211E/RTL8211EG datasheet says: Note 4: 2.5V (or 1.8/1.5V) RGMII power should be risen simultaneously or slightly earlier than 3.3V power. Rising 2.5V (or 1.8/1.5V) power later than 3.3V power may lead to errors. Signed-off-by: Ondrej Jirman Signed-off-by: Corentin Labbe Signed-off-by: Jernej Skrabec --- .../dts/allwinner/sun50i-h6-orangepi-3.dts | 40 +++++++++++++++++++ 1 file changed, 40 insertions(+) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts index 6fc65e8db220..6ed8613a3169 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts @@ -13,6 +13,7 @@ / { compatible = "xunlong,orangepi-3", "allwinner,sun50i-h6"; aliases { + ethernet0 = &emac; serial0 = &uart0; serial1 = &uart1; }; @@ -55,6 +56,17 @@ led-1 { }; }; + reg_gmac_2v5: gmac-2v5 { + compatible = "regulator-fixed"; + regulator-name = "gmac-2v5"; + regulator-min-microvolt = <2500000>; + regulator-max-microvolt = <2500000>; + enable-active-high; + gpio = <&pio 3 6 GPIO_ACTIVE_HIGH>; /* PD6 */ + off-on-delay-us = <100000>; + vin-supply = <®_vcc5v>; + }; + reg_vcc5v: vcc5v { /* board wide 5V supply directly from the DC jack */ compatible = "regulator-fixed"; @@ -113,6 +125,33 @@ &ehci3 { status = "okay"; }; +&emac { + pinctrl-names = "default"; + pinctrl-0 = <&ext_rgmii_pins>; + phy-mode = "rgmii-id"; + phy-handle = <&ext_rgmii_phy>; + status = "okay"; +}; + +&mdio { + ext_rgmii_phy: ethernet-phy@1 { + compatible = "ethernet-phy-ieee802.3-c22"; + reg = <1>; + /* + * The board uses 2.5V RGMII signalling. Power sequence to enable + * the phy is to enable GMAC-2V5 and GMAC-3V (aldo2) power rails + * at the same time and to wait 100ms. The driver enables phy-io + * first. Delay is achieved with enable-ramp-delay on reg_aldo2. + */ + phy-io-supply = <®_gmac_2v5>; + ephy-supply = <®_aldo2>; + + reset-gpios = <&pio 3 14 GPIO_ACTIVE_LOW>; /* PD14 */ + reset-assert-us = <15000>; + reset-deassert-us = <40000>; + }; +}; + &gpu { mali-supply = <®_dcdcc>; status = "okay"; @@ -211,6 +250,7 @@ reg_aldo2: aldo2 { regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; regulator-name = "vcc33-audio-tv-ephy-mac"; + regulator-enable-ramp-delay = <100000>; }; /* ALDO3 is shorted to CLDO1 */