From patchwork Fri Dec 22 17:42:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alex Bee X-Patchwork-Id: 13503662 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BADA7C41535 for ; Fri, 22 Dec 2023 17:45:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hiBjRW3k3BLIzXk9rY8eb5nDlUD9zpOGMf0SA8Qq+/8=; b=yzWbcCRJeDfARe ueS6yBOSpoMSMLDwJtcIdcNB2dJTo0bS7Le/Q5STtr+lXo5eE3JO2YrNbysVeDg/9H46RHYR2LEmB F17jJOGszvmtjLSQvKMmIkegIRdcXQjfpWX+MlQfNXtuPxWlKSiRZO0q8jHqDSRjIvvpxNNtZ+6dL VWznNv4hznLgJhoREo4AkyAZfizPZgDh6SjV/5I7UoejmnAvRhzDM5FwNWzk0bKMTVUNspOE6lmob +VX19GhqI1p/fh+04PrK0Xm3s/Z8rlmlwrL/bmYFG9WRf4Bspg2svNfx51K+6VTAz/yqHz4lEphiR wTVw6o/cXyFrSQU1qVJw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rGjZo-006YTM-0F; Fri, 22 Dec 2023 17:44:48 +0000 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rGjXk-006WUK-1x; Fri, 22 Dec 2023 17:42:42 +0000 Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-33666fb9318so1833407f8f.2; Fri, 22 Dec 2023 09:42:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703266957; x=1703871757; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3qEiW87NdWMqG1i3IC5TsTsEJY+4saJvfxd4Py7tBWk=; b=cg6jF0yU9BWwIDJ5UnXNCQaEpmphNSg03plxTl8IZpVevtcDvZBwHQMzwUhk/WqJQu Fvq7umFTTJecWg7UqyTfRW5OCNCbBPUEy9H1yv+XPWYgOyXQiwiDXcmlg2RsXhc7SNqc 4gHNyRRmX4iH5yX487nbmrhuLIYhrz3bgznWfLT8CNdzzNXHwT5vfeH3ariqZ4wkHOSZ 4NJvM6IYlGBUxVacOBZPu+xpYOzQHVIlPDxdSACbUTcdIe8W/tefVwC9jZEoeLsWJr3s KoOv6+o/pVkaLdNskOpzwXowvAh4D6NsYQq0MQTW6I4jw7SxioBWasqL1U7sv7R2cto3 EBCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703266957; x=1703871757; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3qEiW87NdWMqG1i3IC5TsTsEJY+4saJvfxd4Py7tBWk=; b=ASDZCkXsvn0B8PMTL6JOFs83cMi6RagdKY2t2LWNGrkJsLDnURHMCD2TfTsQ5H/sQ3 u8q4SllsInT7aOl/8ukvgNZZjGxCYBKqDXei/ut8HEu9zHyULDnJqcAkaxErQFlEe55L pfH79ryqbELNrbA5KfQRdFx3UheVDwBN6KQ6ziMgrKweeK9VXj6sxe7lyburnvFGFu4f d0ZDqBLwhcfZKPyxr8yaKRtXynT8ZPdpd2UaLXPUV6k97w3MdxxDGV0IHtDfhsTjF+NH KopA/vV0VGrOqsnrnizja4m/jBRo1GFRrk6NGRwMj0GgGB5D0Te2lYWzAsRZULdTwrzu Q1qw== X-Gm-Message-State: AOJu0Yw2kvfEz908sWoMo44pPemfGRsLJ4TfIPOzjhGzMJKU6bI78yOZ NJIHB6dbsyjmVaylPet7sA== X-Google-Smtp-Source: AGHT+IF/ILntBURjV10Ff56yN/onR9KNU6i4awRUbCKr+V/5OKfVGrXyAKwoOVxh00kqNwRL7i24VQ== X-Received: by 2002:adf:dd8b:0:b0:336:8940:c4dd with SMTP id x11-20020adfdd8b000000b003368940c4ddmr968833wrl.8.1703266957184; Fri, 22 Dec 2023 09:42:37 -0800 (PST) Received: from U4.lan ([2a02:810b:f40:4300:f3ae:2788:7e03:f44]) by smtp.gmail.com with ESMTPSA id w10-20020adfec4a000000b00336670abdcasm4777116wrn.40.2023.12.22.09.42.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Dec 2023 09:42:36 -0800 (PST) From: Alex Bee To: Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Alex Bee Subject: [PATCH v4 21/29] drm/rockchip: inno_hdmi: Don't power up the phy after resetting Date: Fri, 22 Dec 2023 18:42:12 +0100 Message-ID: <20231222174220.55249-22-knaerzche@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231222174220.55249-1-knaerzche@gmail.com> References: <20231222174220.55249-1-knaerzche@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231222_094240_669319_4B9D3C53 X-CRM114-Status: GOOD ( 14.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org inno_hdmi_reset is only ever called when initializing the controller. At this point it’s completely uneccessary to power up the PHY, since all what has to work at this point is the DDC bus. The phy will be powered up correctly when a mode is set in inno_hdmi_encoder_enable and disabled in inno_hdmi_encoder_disable. Set it to LOWER_PWR after resetting the controller. Signed-off-by: Alex Bee --- changes in v3: - new patch changes in v4: - none drivers/gpu/drm/rockchip/inno_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c index f3b90b479ab9..52b49f44a4f4 100644 --- a/drivers/gpu/drm/rockchip/inno_hdmi.c +++ b/drivers/gpu/drm/rockchip/inno_hdmi.c @@ -202,7 +202,7 @@ static void inno_hdmi_reset(struct inno_hdmi *hdmi) val = v_REG_CLK_INV | v_REG_CLK_SOURCE_SYS | v_PWR_ON | v_INT_POL_HIGH; hdmi_modb(hdmi, HDMI_SYS_CTRL, msk, val); - inno_hdmi_set_pwr_mode(hdmi, NORMAL); + inno_hdmi_set_pwr_mode(hdmi, LOWER_PWR); } static void inno_hdmi_disable_frame(struct inno_hdmi *hdmi,