From patchwork Sat Jan 6 22:39:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adam Ford X-Patchwork-Id: 13512836 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B873C47074 for ; Sat, 6 Jan 2024 22:40:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OuGk4OPkOfzcpa5XM9ADAhtHZgm2VBwCJHY8x+19m/g=; b=MZ52n4Q27xN/qN 10HxBvWsy7KAms2PXpvSsnaIDhc3xQDxJ0SFmk4p0kpcf3nzSPlJ6zMHWgdNTlSphvwV+KwodnNMN AI+UnQYwDj4gT4IMYsA9CJp3kJ+nWAEEBbgbgMuYb9oLxPabzzVJb5KHUpD3ORUW2k9KK5WEH0OdB /RsMl+c6KJAAFv48IHF1mJwt7baoAgv6JjmxPaiIa6y1N9EV7H4Ve/kDJwCwNjRLvy0LD4xHS3Lbl iH3+MPuNkP+j5VhhlQgYrrPq5Hsw2NZLPZgidOOsuyK/XzMUnd7Y8ftfedexAPVxKhIPece7zh4iO qsUjC9lGe6hgXNyBOB/Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rMFKs-001yvg-1D; Sat, 06 Jan 2024 22:40:10 +0000 Received: from mail-il1-x129.google.com ([2607:f8b0:4864:20::129]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rMFKp-001yup-0X for linux-arm-kernel@lists.infradead.org; Sat, 06 Jan 2024 22:40:08 +0000 Received: by mail-il1-x129.google.com with SMTP id e9e14a558f8ab-3606f57e08aso4068445ab.3 for ; Sat, 06 Jan 2024 14:40:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704580806; x=1705185606; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pjMgdeRpctwTJ7F3CFnuysHXKhIpRAp8TwJ6AUfLDG4=; b=Q1hfezjsItKUBbq4B6qk0eOmOlAnknGTEIWXqdKEz1wO69QWuzWi7ZRxVDX/1i6kSC 43zWjpufQ21hIVg6pOvvuGtpGUHV6rX9tpFaHx2k4JJNfneLiM1i7pDNMVVSpDLnBHeM 5YJ8rdPNmJAGYUWVSDjrwHHBLqNL4QvxrywNHN+FxokJn2iT8tYHO395UFBf1Q1V+XMY zs4aUCWgzU9PBdw2/GX025AZDgONLb9o8DqNLNl0n+j0pcNvoTlHJarQY24QniDZ8ttZ idvnwpvnK5TODLF5hj4Hj0+7eFo58XvAKZzqgS6PjRd+YApsUYvAXUB0SpEcGfW109ym 44bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704580806; x=1705185606; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pjMgdeRpctwTJ7F3CFnuysHXKhIpRAp8TwJ6AUfLDG4=; b=HyveRdUgPpM0av9Z5QY5dC94KVnty4CtuqBXVII1R9TeQ/Fa7SaclQWsqIWD/tcBMm L8/UVcv1rXGFnAjuqFZDwTHoPtxUx5SvGYiTFbHf91vcE3Chnx7n95y1FGy4AX9D+BBY 7Q/Oh4qBfS5RpV+CbbtZiec2WTzg9CjOcPyzupwBLqYJzJ0mdetH/3m0WQJKoL/cnSb6 1iegHKyxAh/IkpyH8sriZwkswcymjUuaMLoS8NDryJJ7GQnPbv0Hn+Z8wAfX1Is38H2k uMF2Rr6IyRIiOB/JAGe5oKrLDI/ZltaXpm0bg7REM9jG/a/c8v7t/plX+DYn6AQtJVIq euJQ== X-Gm-Message-State: AOJu0YxhurMUAshPpuLM7OR8s0r5cBJ/HAsIynHUuLFLurpfBkC/kp+7 43ZegFWzVl3mS0CHAA9b4VY= X-Google-Smtp-Source: AGHT+IH6sL6lYSC6STeoHI+PeiaWMCl/uvrhXHbpVW3sbXBLqzbyLho0XvENXWhiIPVRFPYJCUkyuA== X-Received: by 2002:a05:6e02:2402:b0:360:8928:2170 with SMTP id bs2-20020a056e02240200b0036089282170mr507707ilb.26.1704580805888; Sat, 06 Jan 2024 14:40:05 -0800 (PST) Received: from aford-System-Version.lan ([2601:447:d002:5be:af2f:17f0:33a3:d6fe]) by smtp.gmail.com with ESMTPSA id l13-20020a056e021c0d00b0035ffe828182sm735346ilh.37.2024.01.06.14.40.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jan 2024 14:40:05 -0800 (PST) From: Adam Ford To: linux-pm@vger.kernel.org Cc: Adam Ford , Sandor Yu , Jacky Bai , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Ulf Hansson , Lucas Stach , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] pmdomain: imx8mp-blk-ctrl: imx8mp_blk: Add fdcc clock to hdmimix domain Date: Sat, 6 Jan 2024 16:39:49 -0600 Message-ID: <20240106223951.387067-2-aford173@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240106223951.387067-1-aford173@gmail.com> References: <20240106223951.387067-1-aford173@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240106_144007_203807_E9E48555 X-CRM114-Status: GOOD ( 13.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org According to i.MX8MP RM and HDMI ADD, the fdcc clock is part of hdmi rx verification IP that should not enable for HDMI TX. But actually if the clock is disabled before HDMI/LCDIF probe, LCDIF will not get pixel clock from HDMI PHY and print the error logs: [CRTC:39:crtc-2] vblank wait timed out WARNING: CPU: 2 PID: 9 at drivers/gpu/drm/drm_atomic_helper.c:1634 drm_atomic_helper_wait_for_vblanks.part.0+0x23c/0x260 Add fdcc clock to LCDIF and HDMI TX power domains to fix the issue. Signed-off-by: Sandor Yu Reviewed-by: Jacky Bai Signed-off-by: Adam Ford --- The original work was from Sandor on the NXP Down-stream kernel diff --git a/drivers/pmdomain/imx/imx8mp-blk-ctrl.c b/drivers/pmdomain/imx/imx8mp-blk-ctrl.c index e3203eb6a022..a56f7f92d091 100644 --- a/drivers/pmdomain/imx/imx8mp-blk-ctrl.c +++ b/drivers/pmdomain/imx/imx8mp-blk-ctrl.c @@ -55,7 +55,7 @@ struct imx8mp_blk_ctrl_domain_data { const char *gpc_name; }; -#define DOMAIN_MAX_CLKS 2 +#define DOMAIN_MAX_CLKS 3 #define DOMAIN_MAX_PATHS 3 struct imx8mp_blk_ctrl_domain { @@ -457,8 +457,8 @@ static const struct imx8mp_blk_ctrl_domain_data imx8mp_hdmi_domain_data[] = { }, [IMX8MP_HDMIBLK_PD_LCDIF] = { .name = "hdmiblk-lcdif", - .clk_names = (const char *[]){ "axi", "apb" }, - .num_clks = 2, + .clk_names = (const char *[]){ "axi", "apb", "fdcc" }, + .num_clks = 3, .gpc_name = "lcdif", .path_names = (const char *[]){"lcdif-hdmi"}, .num_paths = 1, @@ -483,8 +483,8 @@ static const struct imx8mp_blk_ctrl_domain_data imx8mp_hdmi_domain_data[] = { }, [IMX8MP_HDMIBLK_PD_HDMI_TX] = { .name = "hdmiblk-hdmi-tx", - .clk_names = (const char *[]){ "apb", "ref_266m" }, - .num_clks = 2, + .clk_names = (const char *[]){ "apb", "ref_266m", "fdcc" }, + .num_clks = 3, .gpc_name = "hdmi-tx", }, [IMX8MP_HDMIBLK_PD_HDMI_TX_PHY] = {