From patchwork Mon Jan 8 13:48:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vincent Guittot X-Patchwork-Id: 13513511 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 555B8C3DA6E for ; Mon, 8 Jan 2024 13:49:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YcRKL2zi5Ay+lWAC3Zw42MbBBNKbBwE9chpDVwDxdGA=; b=4gxMy7LsT6ZMEr f3I5jTs/6Rw6o3M0+WugilqG6gbCwAtFp0vqVGi4X3IBupenSJBeVVfs1gPIDJ+CT7qy2p0CUH1Xl m3AHTt5Gu83yPhWDkWI8xQ1whRoqsXKy8vaPX6ASnYFTkC9FJ2r4InSz8H3RrQNn0ZLvBpjXgJvcD SIOH1Pd0S8EDeqrLPRI8dembOzSnwADMxCYz9a7wrATEUcCBCM0MGLzJJLcoe6a2fiTimn/FOIGMf 1y0UuCwVbn3aCXXQ4SBB0JVuI8wNNAgFCun7kHLTVAEo0Zw9Kg1GjT+90od183SYiIoHRO5sSz1jf k6rDUUVUCdF0zI+h/myg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rMq0A-005G1m-2M; Mon, 08 Jan 2024 13:49:14 +0000 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rMq03-005Fr5-07 for linux-arm-kernel@lists.infradead.org; Mon, 08 Jan 2024 13:49:10 +0000 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-40e43e4890cso14779665e9.1 for ; Mon, 08 Jan 2024 05:48:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704721731; x=1705326531; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OJN21V1bop2AoQQK03hl+NSFZtBSAxp4abYemrkmzIE=; b=EtETj9eegbZHIsgno6p/qsyWyuKwusDmXAcZrdtrcjJbApc+Eiz0vkBS3VtgTQFxTu ZjMmYVdf8x6YJomGge49jqcKCKtWp4PeoqbgFA0zKOkzRthw+diAkvQi+mYSrB1jMRXz 7Wk+IRw/nYODJMMcb9p4m3rYAAO2UfFpHrbcAfyfHJxJtrdX4XIMTTg38Gbm6HbbdSJU 9OAkX+92GQ6SZw9tCwSXxTKCdTaLfnCLrr1jpYnuvgWGAEZ+QFzBEzBbIFdOQqrbsoCL z3JEV93sooctaRNeZyQxwMXa/eZdpRYiqLeVA+Y5xET/ir9i3MiTPBlFlIH7sVPCBOlJ UgWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704721731; x=1705326531; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OJN21V1bop2AoQQK03hl+NSFZtBSAxp4abYemrkmzIE=; b=AuFJicixwA94QfO7on54nxi559VMO5nfJmagQ5PdJtMJ99EfgFQib4tWkDqQ0HCltm GaL7pBI7HO+v8VfYk8jfsOrc6zCtCgGIe9rP05Tf/tkDIHPgmRhZq9AXJL+C2EkGKUXd pM4bLJIMEnLUPWaSbeICLa2NVeCzC9PfziApkFr5s6gE4Ry52GWtmo15U5g8mvdTblha O6PeZn7X1sBtsVCbobqo2U3FBrNld/skTQbY/Nm/sHGk1lPeidnLly8CMn93FbQThz9N aoevARSfCb63O7y49zgkmoi/4JilA2UjKvq+nj2HyTrUiBFIECowryf1WqpCmZ8jpXjD zbfg== X-Gm-Message-State: AOJu0YxL6eDnFUC4L7WMwdkzOTQv4P5beoFEG7IFJGnfUmbTCYd/v0oZ trt5r+FC6rEiWqv5I5xf78atKCAh2biOCA== X-Google-Smtp-Source: AGHT+IFs585/T72EchvOGQyxErrlQA+vkBx+XnjFO06KpF6r3sFwHsV0pXDbwX3BrYTLnyZ+Iur3YA== X-Received: by 2002:a05:600c:601d:b0:40e:49c7:aca2 with SMTP id az29-20020a05600c601d00b0040e49c7aca2mr220462wmb.146.1704721731089; Mon, 08 Jan 2024 05:48:51 -0800 (PST) Received: from vingu-book.. ([2a01:e0a:f:6020:53aa:59bc:34ea:bb2c]) by smtp.gmail.com with ESMTPSA id n34-20020a05600c3ba200b0040d5b984668sm11165003wms.9.2024.01.08.05.48.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jan 2024 05:48:50 -0800 (PST) From: Vincent Guittot To: linux@armlinux.org.uk, catalin.marinas@arm.com, will@kernel.org, sudeep.holla@arm.com, rafael@kernel.org, viresh.kumar@linaro.org, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, lukasz.luba@arm.com, rui.zhang@intel.com, mhiramat@kernel.org, daniel.lezcano@linaro.org, amit.kachhap@gmail.com, corbet@lwn.net, gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org Cc: qyousef@layalina.io, Vincent Guittot Subject: [PATCH v3 3/5] thermal/cpufreq: Remove arch_update_thermal_pressure() Date: Mon, 8 Jan 2024 14:48:41 +0100 Message-Id: <20240108134843.429769-4-vincent.guittot@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240108134843.429769-1-vincent.guittot@linaro.org> References: <20240108134843.429769-1-vincent.guittot@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240108_054907_156300_AAD7C1E9 X-CRM114-Status: GOOD ( 11.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org arch_update_thermal_pressure() aims to update fast changing signal which should be averaged using PELT filtering before being provided to the scheduler which can't make smart use of fast changing signal. cpufreq now provides the maximum freq_qos pressure on the capacity to the scheduler, which includes cpufreq cooling device. Remove the call to arch_update_thermal_pressure() in cpufreq cooling device as this is handled by cpufreq_get_pressure(). Signed-off-by: Vincent Guittot Reviewed-by: Lukasz Luba Acked-by: Viresh Kumar --- drivers/thermal/cpufreq_cooling.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/thermal/cpufreq_cooling.c b/drivers/thermal/cpufreq_cooling.c index e2cc7bd30862..e77d3b44903e 100644 --- a/drivers/thermal/cpufreq_cooling.c +++ b/drivers/thermal/cpufreq_cooling.c @@ -448,7 +448,6 @@ static int cpufreq_set_cur_state(struct thermal_cooling_device *cdev, unsigned long state) { struct cpufreq_cooling_device *cpufreq_cdev = cdev->devdata; - struct cpumask *cpus; unsigned int frequency; int ret; @@ -465,8 +464,6 @@ static int cpufreq_set_cur_state(struct thermal_cooling_device *cdev, ret = freq_qos_update_request(&cpufreq_cdev->qos_req, frequency); if (ret >= 0) { cpufreq_cdev->cpufreq_state = state; - cpus = cpufreq_cdev->policy->related_cpus; - arch_update_thermal_pressure(cpus, frequency); ret = 0; }