diff mbox series

[net-next,10/10] net: fill in MODULE_DESCRIPTION()s for PCS Layer

Message ID 20240108181610.2697017-11-leitao@debian.org (mailing list archive)
State New, archived
Headers show
Series None | expand

Commit Message

Breno Leitao Jan. 8, 2024, 6:16 p.m. UTC 
W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the LynxI PCS MediaTek's SoC.

Signed-off-by: Breno Leitao <leitao@debian.org>
---
 drivers/net/pcs/pcs-mtk-lynxi.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Andrew Lunn Jan. 8, 2024, 7:21 p.m. UTC | #1 
On Mon, Jan 08, 2024 at 10:16:10AM -0800, Breno Leitao wrote:
> W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> Add descriptions to the LynxI PCS MediaTek's SoC.

Does pcs-lynx.c also have this issue? It can be built at a module.

     Andrew
Breno Leitao Jan. 10, 2024, 11:48 a.m. UTC | #2 
On Mon, Jan 08, 2024 at 08:21:03PM +0100, Andrew Lunn wrote:
> On Mon, Jan 08, 2024 at 10:16:10AM -0800, Breno Leitao wrote:
> > W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> > Add descriptions to the LynxI PCS MediaTek's SoC.
> 
> Does pcs-lynx.c also have this issue? It can be built at a module.

Absolutely. I can see the warning in pcs-lynx and pcs-pts.

WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/net/pcs/pcs_xpcs.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/net/pcs/pcs-lynx.o
diff mbox series

Patch

diff --git a/drivers/net/pcs/pcs-mtk-lynxi.c b/drivers/net/pcs/pcs-mtk-lynxi.c
index 8501dd365279..4f63abe638c4 100644
--- a/drivers/net/pcs/pcs-mtk-lynxi.c
+++ b/drivers/net/pcs/pcs-mtk-lynxi.c
@@ -303,4 +303,5 @@  void mtk_pcs_lynxi_destroy(struct phylink_pcs *pcs)
 }
 EXPORT_SYMBOL(mtk_pcs_lynxi_destroy);
 
+MODULE_DESCRIPTION("MediaTek SGMII library for LynxI");
 MODULE_LICENSE("GPL");