From patchwork Tue Jan 9 16:46:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vincent Guittot X-Patchwork-Id: 13515087 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B42AC47079 for ; Tue, 9 Jan 2024 16:47:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=e83iFLcoTw7Je5MggbOvmz+EzA8fTm3Q8Lo1SLr81M0=; b=CAjF/IxUgteIgD BWBU2/P7RTU1bYIYTwqBi+A51Nhl+NFEcEio4o1fiZ6XnG89Nci+n3f2NJbgJFkA4NswbO3pzJT2q ZIIwm4uoD+bimc/qUv15wkQIZ9I4J8oGbRR+NvD+LW19Qj94wJuzgKLdENepB17vyI4XBeBm6aQZF eaIExcspjRllconA2VmKI0j/lYB6Z3X3cJnp5VGNdfHAd2zti71DteeqhHBvHR/Tn4EkcUEX/l5PU o3TG0oNwp5gyF1kQX47uEueTLA4mgBeat1AXkLxx1+mlKCrzXkwdLJABrdO5rLOe+reIAvybtJrZQ vNte4eAVLMq8MrOVjeIg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rNFFv-008tL9-2T; Tue, 09 Jan 2024 16:47:11 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rNFFo-008tEH-1A for linux-arm-kernel@lists.infradead.org; Tue, 09 Jan 2024 16:47:06 +0000 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-40e4f1f519aso8991075e9.0 for ; Tue, 09 Jan 2024 08:47:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704818820; x=1705423620; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1VSqPsC352z1+DaREu/L/y/EnPhhSVHlvyMYIWruXUU=; b=uTePk3wYroBR/hBjAq+EllTIy1xnFfMfoLXw8rN+Disk2XvDHeEQ3J1weMVcrZf1RG 8i23VkezrJpGBJ1hfqhfEDEg16vtjUKTdH6x1AuPp78v2M4dMXcYVtepkBPkNYaRWA2n 7c8ED7itIqFpQKCZssHBTf12zWwPUkSClyKDwevlfluLOfiDQCt5QdaPyHJnisATl+5D QkoGy8QEcLBgEjQIUAIgMFAk3GXaSOe7cm+bpLcNqi8gQoZXpalRHyHaIVg93pV+4bzm q/5fjV4OmjF9vVX0DvYxFnv60mWQJDpg5jJs3hfpjYf5TzigCMksWvUGVYc7vigydztc Zfaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704818820; x=1705423620; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1VSqPsC352z1+DaREu/L/y/EnPhhSVHlvyMYIWruXUU=; b=n96ndF4xYpZUKDp8sppkcVcyg3vmHc7i6LzYgv9v2qYxIkA+2ViaenfLo0UGHHBIri GOKW4wDrnV4+amGTWDP9p4We6f6/tB58rwOMwHQM0hpZoTtXoGP597w0ohXDMegGqJA7 lKyY2uD5mCCo8sna1rCETY+gLNYbgLzNZrQtGDfB4eHa0llhgsHe+dTdeU72YILbYfIT MjnLtlCrlB5tlqFl5JZr5rl5SZlDUhY5Vayph93l/spbXX7HhVgIKxFpG6wxRVJFRbcW mf7BARR3xU42haA39dE5UiRMndL+tIIOIP19dgPteVaNZo/hL4MRRW4QW5I6tv0ivysa 0dAw== X-Gm-Message-State: AOJu0YzTloSw8ooFJL++iFiAwUZrrg8iSMKlxRjrXjmU67oUqjXR9vxL LYpkPAHUqHIAqPwK+sKXfnBUijL4kvFgLg== X-Google-Smtp-Source: AGHT+IH8EOAQKPftixCHH1GthJR9dBP1bpJsaA2TFNHFIEiMPDXcYKLKrfP75H6radooSSpQr9f0vg== X-Received: by 2002:a7b:c043:0:b0:40d:38ba:544e with SMTP id u3-20020a7bc043000000b0040d38ba544emr3404193wmc.60.1704818820623; Tue, 09 Jan 2024 08:47:00 -0800 (PST) Received: from vingu-book.. ([2a01:e0a:f:6020:378:51f6:d46e:8457]) by smtp.gmail.com with ESMTPSA id r4-20020adff104000000b00336a0c083easm2847845wro.53.2024.01.09.08.46.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jan 2024 08:46:59 -0800 (PST) From: Vincent Guittot To: linux@armlinux.org.uk, catalin.marinas@arm.com, will@kernel.org, sudeep.holla@arm.com, rafael@kernel.org, viresh.kumar@linaro.org, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, lukasz.luba@arm.com, rui.zhang@intel.com, mhiramat@kernel.org, daniel.lezcano@linaro.org, amit.kachhap@gmail.com, corbet@lwn.net, gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org Cc: qyousef@layalina.io, Vincent Guittot Subject: [PATCH v4 1/5] cpufreq: Add a cpufreq pressure feedback for the scheduler Date: Tue, 9 Jan 2024 17:46:51 +0100 Message-Id: <20240109164655.626085-2-vincent.guittot@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240109164655.626085-1-vincent.guittot@linaro.org> References: <20240109164655.626085-1-vincent.guittot@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240109_084704_403847_EE999A1F X-CRM114-Status: GOOD ( 14.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Provide to the scheduler a feedback about the temporary max available capacity. Unlike arch_update_thermal_pressure, this doesn't need to be filtered as the pressure will happen for dozens ms or more. Signed-off-by: Vincent Guittot Acked-by: Rafael J. Wysocki Acked-by: Viresh Kumar Reviewed-by: Qais Yousef --- drivers/cpufreq/cpufreq.c | 36 ++++++++++++++++++++++++++++++++++++ include/linux/cpufreq.h | 10 ++++++++++ 2 files changed, 46 insertions(+) diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 44db4f59c4cc..f4eee3d107f1 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -2563,6 +2563,40 @@ int cpufreq_get_policy(struct cpufreq_policy *policy, unsigned int cpu) } EXPORT_SYMBOL(cpufreq_get_policy); +DEFINE_PER_CPU(unsigned long, cpufreq_pressure); + +/** + * cpufreq_update_pressure() - Update cpufreq pressure for CPUs + * @policy: cpufreq policy of the CPUs. + * + * Update the value of cpufreq pressure for all @cpus in the policy. + */ +static void cpufreq_update_pressure(struct cpufreq_policy *policy) +{ + unsigned long max_capacity, capped_freq, pressure; + u32 max_freq; + int cpu; + + cpu = cpumask_first(policy->related_cpus); + max_freq = arch_scale_freq_ref(cpu); + capped_freq = policy->max; + + /* + * Handle properly the boost frequencies, which should simply clean + * the cpufreq pressure value. + */ + if (max_freq <= capped_freq) { + pressure = 0; + } else { + max_capacity = arch_scale_cpu_capacity(cpu); + pressure = max_capacity - + mult_frac(max_capacity, capped_freq, max_freq); + } + + for_each_cpu(cpu, policy->related_cpus) + WRITE_ONCE(per_cpu(cpufreq_pressure, cpu), pressure); +} + /** * cpufreq_set_policy - Modify cpufreq policy parameters. * @policy: Policy object to modify. @@ -2618,6 +2652,8 @@ static int cpufreq_set_policy(struct cpufreq_policy *policy, policy->max = __resolve_freq(policy, policy->max, CPUFREQ_RELATION_H); trace_cpu_frequency_limits(policy); + cpufreq_update_pressure(policy); + policy->cached_target_freq = UINT_MAX; pr_debug("new min and max freqs are %u - %u kHz\n", diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h index afda5f24d3dd..b1d97edd3253 100644 --- a/include/linux/cpufreq.h +++ b/include/linux/cpufreq.h @@ -241,6 +241,12 @@ struct kobject *get_governor_parent_kobj(struct cpufreq_policy *policy); void cpufreq_enable_fast_switch(struct cpufreq_policy *policy); void cpufreq_disable_fast_switch(struct cpufreq_policy *policy); bool has_target_index(void); + +DECLARE_PER_CPU(unsigned long, cpufreq_pressure); +static inline unsigned long cpufreq_get_pressure(int cpu) +{ + return per_cpu(cpufreq_pressure, cpu); +} #else static inline unsigned int cpufreq_get(unsigned int cpu) { @@ -263,6 +269,10 @@ static inline bool cpufreq_supports_freq_invariance(void) return false; } static inline void disable_cpufreq(void) { } +static inline unsigned long cpufreq_get_pressure(int cpu) +{ + return 0; +} #endif #ifdef CONFIG_CPU_FREQ_STAT