From patchwork Wed Jan 10 10:20:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13515903 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 90657C47073 for ; Wed, 10 Jan 2024 10:22:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GgJLmIGzX1m+rDyNMyqvDml5boiJI/+ZGkUwtEktgQM=; b=u1QqP1Kxnbb70o sp94GpAxZ7g889J1/F43mCkc0cC6hZlvnlUorp3uLEQAkxCTnaXjcSPcFYaErlF4a2g2usai0GDNK HLh5EouXbctUwmvp1PIrqpK83s3iHq1KyjWSkVyGXhjmKMm3DFK3wrgbigKv6oCVtm/az9pkxSb9v nWk9uvjrXcz994/Uhuzr0/E03D474sRdGDLbduE+X2rOJmOcC2RSa8XzGx+K6iGjEdnR99Vw7kkMD 5bs8rhtfkxnOiDTsM8aJ3Chm57uCaHBry5CFHtTxXrekOitantZsYTykrFE032GVDX/FCUM120ja1 Bg1Q/Fr0MqQkUv2exnAg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rNViP-00B0N6-2i; Wed, 10 Jan 2024 10:21:41 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rNVi2-00B01p-1c for linux-arm-kernel@lists.infradead.org; Wed, 10 Jan 2024 10:21:21 +0000 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-40d8902da73so37762485e9.2 for ; Wed, 10 Jan 2024 02:21:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704882077; x=1705486877; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=X4OrxluJS1Dxt0QsygYV4JA7ss0pHdXLycYpqP8S/nY=; b=uAq2+FbEXIHOVUyP4k5et02ihEVVIQvODYl/g3owpXadq4atM87XmjvhEO57c+DQxu qOPaZ6riChWORfMrYSsx27fxGBH7tpEln7Fr828t0M2AYX8uHToBWvsw0llSb9aWGRo8 Y+HKbhbN0E6R2+RZfchVRBJI0JbFiLMoUpfv9EhhpLEx+eS2+Da4lXwK2h3JdKoDLjcO 8g92I8fHOKYh9hHnQeVZ3TISAyMM9GsA7TPxNPZ5hVs0pZaW0zpuTsFZ/OtHCHoHD8AW dIaVgcDWyE3zx3aVjlnY4a72QbW8EIb/d/+/3b3mtJSZN5AScis9+pWKsbuFPtP61USR OFlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704882077; x=1705486877; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=X4OrxluJS1Dxt0QsygYV4JA7ss0pHdXLycYpqP8S/nY=; b=mtOxJ/liHpQuedzqpPURbuWhGxjk0ziWAatoizut9Pl8eceOvqOnU8ZZ7rNNIewRTt b4s4pdn6aoVfQ7/2ByzUuBCikVq2usdLjOJGIwlacAg8JEXdWmDZxdSJemq+mRHx62aP JUsxatUHkHmyrKzk0lUBF4IxT8Brwd6YIBQLzxYF3IpOcMUU0qccgkqYnpzEP2Qc+ggF VtaqM/uRrkGRzmsAgUQnaQRMGk25XTztARl7ouVaHX5zR27IdpDwcnfg9bj4/ykmEMpu 263YtI1rOq3w/QysjTHkjvCHnzwuUnYPb/XF4YmuQbJywIBQK8fXlfth46xYQF9jxxHP 1avA== X-Gm-Message-State: AOJu0YyJBmS3htfv4Tjpf/AEjnzUdOCXmsCmBRphP4KlZKSlltMhMqSe U7SrzXiSWdOhxyZ5W3y8A/o6RvqZzH7c3A== X-Google-Smtp-Source: AGHT+IH2pHpqQ2IvcL8mLqW4mDIBGBWO/XFWarVigmK91FlJxQn+wyWXYGgkF4J4hdXMLY2WPdpvQQ== X-Received: by 2002:a05:600c:511e:b0:40e:42b4:23b6 with SMTP id o30-20020a05600c511e00b0040e42b423b6mr498393wms.55.1704882077261; Wed, 10 Jan 2024 02:21:17 -0800 (PST) Received: from ta2.c.googlers.com.com (88.140.78.34.bc.googleusercontent.com. [34.78.140.88]) by smtp.gmail.com with ESMTPSA id j7-20020a05600c190700b0040e52cac976sm1625302wmq.29.2024.01.10.02.21.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 02:21:16 -0800 (PST) From: Tudor Ambarus To: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, gregkh@linuxfoundation.org, jirislaby@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH 12/18] tty: serial: samsung: use TIOCSER_TEMT for tx_empty() Date: Wed, 10 Jan 2024 10:20:56 +0000 Message-ID: <20240110102102.61587-13-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog In-Reply-To: <20240110102102.61587-1-tudor.ambarus@linaro.org> References: <20240110102102.61587-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240110_022118_545381_7A17FC3F X-CRM114-Status: GOOD ( 10.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The core expects for tx_empty() either TIOCSER_TEMT when the tx is empty or 0 otherwise. Respect the core and use TIOCSER_TEMT. Signed-off-by: Tudor Ambarus --- drivers/tty/serial/samsung_tty.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c index f2413da14b1d..46fba70f3d77 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -990,11 +990,10 @@ static unsigned int s3c24xx_serial_tx_empty(struct uart_port *port) if (ufcon & S3C2410_UFCON_FIFOMODE) { if ((ufstat & info->tx_fifomask) || (ufstat & info->tx_fifofull)) return 0; - - return 1; + return TIOCSER_TEMT; } - return s3c24xx_serial_txempty_nofifo(port); + return s3c24xx_serial_txempty_nofifo(port) ? TIOCSER_TEMT : 0; } /* no modem control lines */