From patchwork Wed Jan 10 10:20:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13515905 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9044AC3DA6E for ; Wed, 10 Jan 2024 10:22:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MukK1Z3CwrOec6/n4tDuQ3TRfyfzWCG/nL7gbi3CCxs=; b=D2GUgw+X7p5p16 OpS2R8dRiKm8bY5Z8Kngq0aubVibldX1SeI+iuBFQu0FbSlsbvRY7lI7+mQVcrpM8GDWDPV8UTB9h FeDwP2FH3/CnweTf9VWDM4QYbfOdxAXgX3KYE0ERKdEFbVBPBFzCL64AmHqRw7WUHzfwM3htLvngO cjrUexY1Owc0Mvwg90oNMd7gvBw54kURaB6yLFV5bUfJ2QfYKLVfD346nF5AF28oWLNrZrXzAIsz3 cJXoSPIoS13qH8ojzbz30UNEgJAOJIRB29qQxvohaqiTPnnin0DMuWvtNovwyFYG/FXzDLqBS2JqX nnxGOw3WKJpXDZ0r8oEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rNViS-00B0Oy-0a; Wed, 10 Jan 2024 10:21:44 +0000 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rNVi3-00B02g-0X for linux-arm-kernel@lists.infradead.org; Wed, 10 Jan 2024 10:21:21 +0000 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-40d88fff7faso41079165e9.3 for ; Wed, 10 Jan 2024 02:21:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704882078; x=1705486878; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zUZkD3RxZyomRUtnLq1bNhUO9I/uygo4/DAHV/FeOS0=; b=hjXNA63/c7tWlwhjQHafLjAkBgm9ykkoQhzE3QGBYOTA1mMemu95s//LMZR37IGQyq SnI6VdqiI31xFRgqAxs8LcoW9eU4jelJyUD1MpASj86GEVx/EuQViXKW1oozsDPuQ2tu 2eY4P4Tj1sag3K+5yjaKV/GfmtYBotfsQbBIzfmrZ/v0LnyinBxd5DbbloI7pMi5P0V0 kcOhrarqoc76ydLmzjq/6vm7nmURM1ArOsxEdv/cMVO4s5G+/WLRsR+4fsyZuI/LffBM uwnRjMDVU6VY/z6Vxckv33mCOPAMXLldCFPdt4qTafNu0sX4z/Sk5AvuOV5G05lmcwEC l6QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704882078; x=1705486878; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zUZkD3RxZyomRUtnLq1bNhUO9I/uygo4/DAHV/FeOS0=; b=NpuovRUbQmaCjj90gkUWkHuDCTa+SrSgN7KCytxaWnabtncRNzwkWii+JPocLmAIm1 WKQfLJjBf26/6/pGQCIYrEuwMVJ34G7IdDy6YrMDO0e4iZFh8duDE95vlh2ZpQ/KmD3o mnPRwrlcesX6o1S275zJ/BYm7odzFQQ52Ce/GqrW5251ogaB4entbmhcgZxB4uo3gzjw AKSxJN9WEtUNOY5ud7DUt819xYXD4b2vk68BXo0MC7102dKGtHzKCdDzw0fGFJhfIBTL tLpMtcottNU8Spcq2yJRFm72MWBt85ILZ8CzGdeL0wFm3TBAqWLDiZvmYxfY8HdI5k60 /RAQ== X-Gm-Message-State: AOJu0YzQnsV4EWyGCY6UAeXYldlNE1Jlv2OMSFR2sAJQ3hpypN6rS/oG QhbXfAvr4G5HYtA9DjvtJEABifiitq9ygA== X-Google-Smtp-Source: AGHT+IGYLsOFrNdKSYUGQJjzwSLK/RYL6+X1/WFxwE+OfMrXS+TWExfIax6TS45wnteKjsb5eI8ulg== X-Received: by 2002:a05:600c:45d2:b0:40d:7c1a:cce4 with SMTP id s18-20020a05600c45d200b0040d7c1acce4mr208326wmo.213.1704882078025; Wed, 10 Jan 2024 02:21:18 -0800 (PST) Received: from ta2.c.googlers.com.com (88.140.78.34.bc.googleusercontent.com. [34.78.140.88]) by smtp.gmail.com with ESMTPSA id j7-20020a05600c190700b0040e52cac976sm1625302wmq.29.2024.01.10.02.21.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 02:21:17 -0800 (PST) From: Tudor Ambarus To: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, gregkh@linuxfoundation.org, jirislaby@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH 13/18] tty: serial: samsung: return bool for s3c24xx_serial_txempty_nofifo() Date: Wed, 10 Jan 2024 10:20:57 +0000 Message-ID: <20240110102102.61587-14-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog In-Reply-To: <20240110102102.61587-1-tudor.ambarus@linaro.org> References: <20240110102102.61587-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240110_022119_260879_A9770594 X-CRM114-Status: GOOD ( 11.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org s3c24xx_serial_txempty_nofifo() returned either 0 or BIT(2), which is counterintuitive. Make the method return bool, and return true when TX is empty and false otherwise. Signed-off-by: Tudor Ambarus Reviewed-by: Sam Protsenko --- drivers/tty/serial/samsung_tty.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c index 46fba70f3d77..63e993bed296 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -236,9 +236,9 @@ static inline const char *s3c24xx_serial_portname(const struct uart_port *port) return to_platform_device(port->dev)->name; } -static int s3c24xx_serial_txempty_nofifo(const struct uart_port *port) +static bool s3c24xx_serial_txempty_nofifo(const struct uart_port *port) { - return rd_regl(port, S3C2410_UTRSTAT) & S3C2410_UTRSTAT_TXE; + return !!(rd_regl(port, S3C2410_UTRSTAT) & S3C2410_UTRSTAT_TXE); } static void s3c24xx_serial_rx_enable(struct uart_port *port) @@ -782,7 +782,7 @@ static void s3c24xx_serial_rx_drain_fifo(struct s3c24xx_uart_port *ourport) ch = rd_reg(port, S3C2410_URXH); if (port->flags & UPF_CONS_FLOW) { - int txe = s3c24xx_serial_txempty_nofifo(port); + bool txe = s3c24xx_serial_txempty_nofifo(port); if (ourport->rx_enabled) { if (!txe) {