diff mbox series

[1/2] Revert "arm64: dts: imx8mp-dhcom-pdk3: Describe the USB-C connector"

Message ID 20240113224333.2442248-1-festevam@gmail.com (mailing list archive)
State New, archived
Headers show
Series [1/2] Revert "arm64: dts: imx8mp-dhcom-pdk3: Describe the USB-C connector" | expand

Commit Message

Fabio Estevam Jan. 13, 2024, 10:43 p.m. UTC 
From: Fabio Estevam <festevam@denx.de>

This reverts commit a4dca89fe8a1585af73e362f5f4e3189a00abf8e.

Marek reported:

"This patch breaks USB-C port on this board.

If I plug in USB-C storage device, it is not detected. If I revert this
patch, it is detected.

Please drop this patch for now."

Revert it to avoid the regression.

Reported-by: Marek Vasut <marex@denx.de>
Closes: https://lore.kernel.org/linux-arm-kernel/623c294a-5c53-4e01-acbf-104acc180e14@denx.de/T/#u
Fixes: a4dca89fe8a1 ("arm64: dts: imx8mp-dhcom-pdk3: Describe the USB-C connector")
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dts | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

Comments

Shawn Guo Feb. 5, 2024, 9:32 a.m. UTC | #1 
On Sat, Jan 13, 2024 at 07:43:32PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> This reverts commit a4dca89fe8a1585af73e362f5f4e3189a00abf8e.
> 
> Marek reported:
> 
> "This patch breaks USB-C port on this board.
> 
> If I plug in USB-C storage device, it is not detected. If I revert this
> patch, it is detected.
> 
> Please drop this patch for now."
> 
> Revert it to avoid the regression.
> 
> Reported-by: Marek Vasut <marex@denx.de>
> Closes: https://lore.kernel.org/linux-arm-kernel/623c294a-5c53-4e01-acbf-104acc180e14@denx.de/T/#u
> Fixes: a4dca89fe8a1 ("arm64: dts: imx8mp-dhcom-pdk3: Describe the USB-C connector")
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Applied both, thanks!
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dts b/arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dts
index fea67a9282f0..b749e28e5ede 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dts
@@ -175,14 +175,10 @@  typec@3d {
 				pinctrl-names = "default";
 				pinctrl-0 = <&pinctrl_ptn5150>;
 
-				connector {
-					compatible = "usb-c-connector";
-					label = "USB-C";
-
-					port {
-						ptn5150_out_ep: endpoint {
-							remote-endpoint = <&dwc3_0_ep>;
-						};
+				port {
+
+					ptn5150_out_ep: endpoint {
+						remote-endpoint = <&dwc3_0_ep>;
 					};
 				};
 			};