From patchwork Wed Jan 17 14:13:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Singh Tomar X-Patchwork-Id: 13521784 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8A199C47DA2 for ; Wed, 17 Jan 2024 14:16:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=H+LKthzMwvgG5BzsFaBubmahjEK1c2Ca7Ti5ZMw3al4=; b=QeNZ6eIVbU9/W0 ywqqgryoL++ccxcwcSFgKNnE7nKEFIKxOWC5yYffoBqx7ftEYFyAhtT/3nT+RFMdurzcaTEZcjG60 qh3CM4YP6V98LcWV3hQP2sZzL2K2TfatxUubWHaTdfZsRZvDJ6YhuqnjT6IoxB814KEyQT70MhH7m 3u8+XrrAXUAHHLtH7iGBanWgSBNtzHGMCA4hMp+JYvZP6S4xceY5WrWH7mKNV+22ACmYZJqHX9Dni fGeWu8DwCSNN2GJXlGbvYsoI2bwBdNxzolDa5GcozQl/mQVedcs/VwDVUChSRulYRzvGD+XF6pRP0 7wJyKB3pf/U3DFRPK38w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rQ6hS-00GyO3-2k; Wed, 17 Jan 2024 14:15:26 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rQ6hB-00Gy5X-1r for linux-arm-kernel@bombadil.infradead.org; Wed, 17 Jan 2024 14:15:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Type:Content-Transfer-Encoding :MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=ClHK3/wLgAYScaXmKMdx+tz4GzxuqNqE2DlmfLex1Jw=; b=c8+xfGRcbnIQhteoWeQapabtDk mvUwDkdy4k19xZXNqHXooWjVFSyojQjaF2zFnXDH1JNzGOCYk8S1NA+TFM7/Yv9/mo/BMKOiAhsvF xwynI2KVbUt6KJNOZQjyRS6IJhsUXpclKI7jLtutCVSU4LbfSYXBQCjfwAszg9h6OqcvJE2iXOL83 gBdRM4m6DOBRoOoFTT7150NWsvpBB0lVvGisoLYCVcqyAgueU9sH6W9L+52Cl909mRHUliXAAhK+H fdPJCvImwDAACzAi9fCAD6kKUuvDyWwXt17QOBcijET41ZTu5uT4GwlA7wqVO56Pw1gSEqsKWz91z l3Y4aeqQ==; Received: from mx0a-0016f401.pphosted.com ([67.231.148.174] helo=mx0b-0016f401.pphosted.com) by desiato.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rQ6h6-00000000UCo-1LKx for linux-arm-kernel@lists.infradead.org; Wed, 17 Jan 2024 14:15:07 +0000 Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 40H7jROo028480; Wed, 17 Jan 2024 06:14:44 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s= pfpt0220; bh=ClHK3/wLgAYScaXmKMdx+tz4GzxuqNqE2DlmfLex1Jw=; b=hrw D04qp8VwXtDOdngWTYpLQTHAQsAV1lE+nexzfgW0tiHgnzQ9L66kDvYL1KUnbtVR c8+ifAs+OcpvK9rASdZBXXGwmGVUZjZ/i4owr/K2cdsii7lze1v4ctIfja92RLCO yhX/nTLbCmNloAoUCi6hwsQ3geKf/hiF89fAWFlItImiZUGMD73tDggpTdQqG2Fl Zz6R+1SDch+SrU54Llg3TMkdRT0RpWe0IAKaT4MVoWKBrYvQv8F9++6OS85apas2 jhzsR5uItU6N+3QpOo8RFMf4YboKCh4n60SHprynP4npssnOoQimsYRhXU7uuPq4 uEb4eBgLC1wDCiOnwXA== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3vpask9528-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 17 Jan 2024 06:14:44 -0800 (PST) Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Wed, 17 Jan 2024 06:14:42 -0800 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.48 via Frontend Transport; Wed, 17 Jan 2024 06:14:42 -0800 Received: from localhost.localdomain (unknown [10.28.36.167]) by maili.marvell.com (Postfix) with ESMTP id 6DC035B6931; Wed, 17 Jan 2024 06:14:39 -0800 (PST) From: Amit Singh Tomar To: , CC: , , , , , , , , Amit Singh Tomar Subject: [PATCH v1 08/14] fs/resctrl: Extend schemata write for priority partition control Date: Wed, 17 Jan 2024 19:43:59 +0530 Message-ID: <20240117141405.3063506-9-amitsinght@marvell.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240117141405.3063506-1-amitsinght@marvell.com> References: <20240117141405.3063506-1-amitsinght@marvell.com> MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: 6BxRsaXflju6f4cNxs1tIwQfGAIJiaHO X-Proofpoint-GUID: 6BxRsaXflju6f4cNxs1tIwQfGAIJiaHO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-17_08,2024-01-17_01,2023-05-22_02 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240117_141504_949879_2F3AB7AC X-CRM114-Status: GOOD ( 16.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Currently, Users can pass the configurations for CPBM, and MBA through schemata file. For instance, CPBM can be passed using: echo L3:0=ffff > schemata This change allows, users to pass a new configuration for downstream priority. For instance, dspri value of "0xa" can be passed as: echo L3DSPRI:0=a > schemata Signed-off-by: Amit Singh Tomar --- Changes since RFC: * As suggested by Fenghua Yu, Parse for DSPRI is called from parse_line(). * Decluttering code from rdtgroup_schemata_write(). --- fs/resctrl/ctrlmondata.c | 59 ++++++++++++++++++++++++++++++++++++++-- 1 file changed, 56 insertions(+), 3 deletions(-) diff --git a/fs/resctrl/ctrlmondata.c b/fs/resctrl/ctrlmondata.c index 78f9fb1c52fa..f1f57bbfa094 100644 --- a/fs/resctrl/ctrlmondata.c +++ b/fs/resctrl/ctrlmondata.c @@ -30,6 +30,55 @@ typedef int (ctrlval_parser_t)(struct rdt_parse_data *data, struct resctrl_schema *s, struct rdt_domain *d); +static bool dspri_validate(char *buf, unsigned long *data, struct rdt_resource *r) +{ + + unsigned long dspri_val; + bool success = true; + int ret; + + ret = kstrtoul(buf, 16, &dspri_val); + if (ret) { + pr_info("Non-hex character in the mask %s\n", buf); + success = false; + goto out; + } + + if (dspri_val > r->default_dspri_ctrl) { + pr_info("dspri value %ld out of range [%d-%d]\n", dspri_val, + 0, r->default_dspri_ctrl); + success = false; + goto out; + } + + *data = dspri_val; + +out: + return success; +} + +static int parse_dspri(struct rdt_parse_data *data, struct resctrl_schema *s, + struct rdt_domain *d) +{ + struct resctrl_staged_config *cfg; + struct rdt_resource *r = s->res; + unsigned long pri_val; + + cfg = &d->staged_config[s->conf_type]; + if (cfg->have_new_ctrl) { + pr_info("Duplicate domain %d\n", d->id); + return -EINVAL; + } + + if (!dspri_validate(data->buf, &pri_val, r)) + return -EINVAL; + + cfg->new_ctrl = pri_val; + cfg->have_new_ctrl = true; + + return 0; +} + /* * Check whether MBA bandwidth percentage value is correct. The value is * checked against the minimum and max bandwidth values specified by the @@ -201,10 +250,14 @@ static int parse_cbm(struct rdt_parse_data *data, struct resctrl_schema *s, return 0; } -static ctrlval_parser_t *get_parser(struct rdt_resource *res) +static ctrlval_parser_t *get_parser(struct resctrl_schema *s) { - if (res->fflags & RFTYPE_RES_CACHE) + struct rdt_resource *res = s->res; + + if (res->fflags & RFTYPE_RES_CACHE && !s->ctrl_type) return &parse_cbm; + else if (s->ctrl_type == SCHEMA_DSPRI) + return &parse_dspri; else return &parse_bw; } @@ -218,7 +271,7 @@ static ctrlval_parser_t *get_parser(struct rdt_resource *res) static int parse_line(char *line, struct resctrl_schema *s, struct rdtgroup *rdtgrp) { - ctrlval_parser_t *parse_ctrlval = get_parser(s->res); + ctrlval_parser_t *parse_ctrlval = get_parser(s); enum resctrl_conf_type t = s->conf_type; struct resctrl_staged_config *cfg; struct rdt_resource *r = s->res;