| Message ID | 20240119092500.7154-2-quic_jinlmao@quicinc.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: qcom: Add coresight nodes for sm8450 | expand |
On Fri, Jan 19, 2024 at 01:24:57AM -0800, Mao Jinlong wrote: > Remove pattern match of ETE node name. Use ete as the name for ete nodes. > Not saying that you're wrong, but...why? Regards, Bjorn > Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com> > --- > .../bindings/arm/arm,embedded-trace-extension.yaml | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml b/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml > index f725e6940993..a10a570bd9bc 100644 > --- a/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml > +++ b/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml > @@ -22,8 +22,6 @@ description: | > with any optional connection graph as per the coresight bindings. > > properties: > - $nodename: > - pattern: "^ete([0-9a-f]+)$" > compatible: > items: > - const: arm,embedded-trace-extension > @@ -55,13 +53,13 @@ examples: > > # An ETE node without legacy CoreSight connections > - | > - ete0 { > + ete { > compatible = "arm,embedded-trace-extension"; > cpu = <&cpu_0>; > }; > # An ETE node with legacy CoreSight connections > - | > - ete1 { > + ete { > compatible = "arm,embedded-trace-extension"; > cpu = <&cpu_1>; > > -- > 2.41.0 >
On 30/01/2024 23:17, Bjorn Andersson wrote: > On Fri, Jan 19, 2024 at 01:24:57AM -0800, Mao Jinlong wrote: >> Remove pattern match of ETE node name. Use ete as the name for ete nodes. >> > > Not saying that you're wrong, but...why? > I don't expect any meaningful commit msgs anymore, so: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- This is an automated instruction, just in case, because many review tags are being ignored. If you know the process, you can skip it (please do not feel offended by me posting it here - no bad intentions intended). If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions, under or above your Signed-off-by tag. Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply. https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 Best regards, Krzysztof
On Fri, Jan 19, 2024 at 01:24:57AM -0800, Mao Jinlong wrote: > Remove pattern match of ETE node name. Use ete as the name for ete nodes. > > Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com> > --- > .../bindings/arm/arm,embedded-trace-extension.yaml | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml b/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml > index f725e6940993..a10a570bd9bc 100644 > --- a/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml > +++ b/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml > @@ -22,8 +22,6 @@ description: | > with any optional connection graph as per the coresight bindings. > > properties: > - $nodename: > - pattern: "^ete([0-9a-f]+)$" I prefer we keep something here. '^ete-' or '^ete-[0-9]+$'. > compatible: > items: > - const: arm,embedded-trace-extension > @@ -55,13 +53,13 @@ examples: > > # An ETE node without legacy CoreSight connections > - | > - ete0 { > + ete { > compatible = "arm,embedded-trace-extension"; > cpu = <&cpu_0>; > }; > # An ETE node with legacy CoreSight connections > - | > - ete1 { > + ete { > compatible = "arm,embedded-trace-extension"; > cpu = <&cpu_1>; > > -- > 2.41.0 >
diff --git a/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml b/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml index f725e6940993..a10a570bd9bc 100644 --- a/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml +++ b/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml @@ -22,8 +22,6 @@ description: | with any optional connection graph as per the coresight bindings. properties: - $nodename: - pattern: "^ete([0-9a-f]+)$" compatible: items: - const: arm,embedded-trace-extension @@ -55,13 +53,13 @@ examples: # An ETE node without legacy CoreSight connections - | - ete0 { + ete { compatible = "arm,embedded-trace-extension"; cpu = <&cpu_0>; }; # An ETE node with legacy CoreSight connections - | - ete1 { + ete { compatible = "arm,embedded-trace-extension"; cpu = <&cpu_1>;
Remove pattern match of ETE node name. Use ete as the name for ete nodes. Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com> --- .../bindings/arm/arm,embedded-trace-extension.yaml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)