From patchwork Tue Jan 23 14:38:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13527512 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1FB76C47258 for ; Tue, 23 Jan 2024 14:35:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To:In-Reply-To: References:Message-Id:Subject:Date:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=8QLhhSn909PSemIUm10iLpSFyMNmQoOJNJs0EywKrdE=; b=w5QCw90TGOIUNbxpQG/B3kdcXm fSO3eh7bBShgnDe5EZHB8dYXDD6W7h4Abniti3FPU+uGqSkVZxCt9rJp4+Df38jGijBlYqXJ2x2sd 5uLxikxz+gMhqc7vIskbtdLbZPp7qVTULcBE0unwYSU0Jqiz7WVM7PAepelsGW8zO54wh53M7CvrV HxPjyU8emrUegSwxJWDL5WSgZ5T/t8u37SFqX7WB7cbMeZU9HAHRfcEIBnXiVmGMhTBG1vj+3ZjMd F7e73HQpUPyJlh3APawjL1UhZQ9YygObdpQSIMkGPWztLNjCS+cy88MPk5VD7SxUyAw1v5rgSb2PS rx9VrqUg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rSHrS-00GpWK-25; Tue, 23 Jan 2024 14:34:46 +0000 Received: from mail-am7eur03on20601.outbound.protection.outlook.com ([2a01:111:f403:260e::601] helo=EUR03-AM7-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rSHrL-00GpSZ-25 for linux-arm-kernel@lists.infradead.org; Tue, 23 Jan 2024 14:34:40 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c/XEoqfJ4K8CgowLuLA6flobOamrpudz8zNDmmdjuAmIh2F/O1HfTM5+HsUTlMSCS96T35Evqy6WpJ9VegmPzgrmYjvMLt2PA6N8XhJSzwsZazi+2J+bh/zG6a1h6o8ngAe9BKI4fQLDK9lf0vLmzEjMkndk8jENOrI4MB+nQ0J2r1ZCaMKzZ1O9Rehrwj9VcM0RRSWOhr8I3wsdfjjy9v6/o9Hk3e7CW9D1u9AaZAryhiD6Kp6B1VDOcGU+YoQKv5+OYGrgXzXvbuHcmJMR9STZpnRrFpdOGE4xeDBpFPBQXI1Iu44WtiW6gLM7jy2EoRuUSKhjVHYYjkRq8CAx2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lVF+lIifocnKZkWBqalKhcjKGKvD/NfO5sSqA4z8S+g=; b=HeK0JFWxlehyat8N6Eati3Qn65pGs72ONPxg4TXV0LYJ7mPUjJUdeV0h21RwCPhP9skToeHb2qJTwu7WZp1CYOQrLTlKWEKcAahKbjdNj9CtY2qCaaU3Aq4T5r7p6KZzZ1Qm6uZvkKfZZJ0UU98oUWJ7wynvVbvku0oiCWk9ESimJFvwJN4cBP033ZE8R7mxRQKU2mu2EBOciTxU1zChrrueOOSsRJ8GlLfUe7x5O+SOYj9oQQ7Z7UhfhqGXZAo1RdSJAlCO9m1hzBRh0Yz/c4ZNUzz2xTplqgSOquJBi8exDVMXGXAPfFH/iW9mBqjWGL8j0XEP1UzsHaj1QCeVWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lVF+lIifocnKZkWBqalKhcjKGKvD/NfO5sSqA4z8S+g=; b=R8lLILfqPqT1SFKxgfCxRIcZ/Ug7XZ6utrM0t/S8dgBs3UgtRvdExuEQBx6wYaqQpRMspLOJ/yNYSD1oxHe7mpC8CG/C7riBjkKZYuOa2gkhHrrbpw036DghzISK7fhrsttef22m38SLBvJZ2RJikWRlUH+B0WW4KQEmupLh/Kc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by DBAPR04MB7304.eurprd04.prod.outlook.com (2603:10a6:10:1ab::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.36; Tue, 23 Jan 2024 14:34:33 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::c499:8cef:9bb1:ced6]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::c499:8cef:9bb1:ced6%3]) with mapi id 15.20.7202.031; Tue, 23 Jan 2024 14:34:33 +0000 From: "Peng Fan (OSS)" Date: Tue, 23 Jan 2024 22:38:43 +0800 Subject: [PATCH v3 2/4] mailbox: imx: support return value of init Message-Id: <20240123-imx-mailbox-v3-2-ed932945e0bf@nxp.com> References: <20240123-imx-mailbox-v3-0-ed932945e0bf@nxp.com> In-Reply-To: <20240123-imx-mailbox-v3-0-ed932945e0bf@nxp.com> To: Jassi Brar , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dong Aisheng , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Peng Fan X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1706020734; l=3343; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=+Gd+/hMaY4KbnLg+mAxCKcpz6HM1MVsMqwBCKUxGXc0=; b=5O3LBUBookNT8VKge0bq0I+VPLg6GIEYtk4VRy9cu9QXhIqyVEPaLkgYaCoa4B+5wEULmof2T liTlsjuu8pgBynhMx+EbuWxO2p/PBTnjf1U3jZ+1wTZsWQiSf6RaXt2 X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR02CA0125.apcprd02.prod.outlook.com (2603:1096:4:188::13) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|DBAPR04MB7304:EE_ X-MS-Office365-Filtering-Correlation-Id: b029d009-942a-465b-77a4-08dc1c206a88 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LxlJl92cpFpU6b5kcWcYp1mzc+mN++YuCquE7CHSNRcJkonVFk5wAei5otaS2nzqpa213hQRVYtlCVMxUWJxrdFJpO4h9zcwnykXPv93Mo+ek5+p5J7Xz2OcHYrKy13BjJcsS6VQfcG4ukmwr3an0KJzLX3Hg3m5T6frHnnB5ZiXD27909BBqc4EUhbpA2rIFfJsd/A511FK6rkBWcMUSqQ6LDVcLFn5++xhgJWoboW4ASsxVflF0SQmBNYswpxmC3K4fSFWZjjb0AanFvW4BVO7w4+FQC/UKxhxq91BmYhFQ5y8LkIcIugab0fiQ7clR2vf+h1lmkgh92QIEf3WQLESwizVl369HSY5avTTc6LnzW2QmYhJxFw1j11L7J0BAnVDAn78N+XYnOFihgAVKq2gVm7qC68Cj/w0kAQ6MFTWlFcTBNrgTjO9wbClSrsbCVNGlWMwbMpj5VtPV2hVWih+uacn3jpMQWa1XyqDPLLP2KZtnSR4DrZr8fpP63hk3OslZtM1cPNW8jtmFQnwOZ8f3hUxod+FFuoel8X0HPLdn3ta4SMOxrxxOxSzLCgemeYbQeD5ZlNMY1yILEr2kxQOimlM+a/c7E7om5nXh1iKhiLAv6tnN10/4eFC+kcm X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376002)(396003)(366004)(346002)(39860400002)(136003)(230922051799003)(1800799012)(64100799003)(186009)(451199024)(5660300002)(66946007)(66476007)(66556008)(110136005)(316002)(26005)(6486002)(6512007)(6506007)(6666004)(9686003)(52116002)(478600001)(83380400001)(4326008)(2906002)(36756003)(86362001)(38100700002)(41300700001)(15650500001)(38350700005)(8936002)(8676002)(921011)(7416002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?6edQka++5Q0OJX/w6Xo96bqUYguu?= =?utf-8?q?zY5phKyxxaS9Ux+nsFkKaCx9z/EoFXirCS3D+UapINRhsPDfeE2+nkWdX0QgjpRiJ?= =?utf-8?q?rI005WpWWIvcNDqNkR7NVRBD2w3WH/Mlh9DQbh+aG4FWQW/uCxVgoOaVqgQSL+jK4?= =?utf-8?q?mqYR8oaFJc+ylJX3UtekVkYcvqXcDSprRq3FN3bpXG5uhEl+QxS7iTrxpgkLVdLzf?= =?utf-8?q?AThhv3sjIf4OaY1kByy/hASFxv2SFMSgRtHHpo8EB34lPW8gwPpBv/dLUUwd1WjcV?= =?utf-8?q?egxVbcL+7TPjNQFJjGXrrYQCM3Mo+M2T90pnozkv4BYmOryA6QxAiUvG3f+20X5/d?= =?utf-8?q?7VG/ZI/TNseNOpdzTsn/IGmNSKRvDr4Ck0+ZyvFpPy8ooHzB4PZX1pFDDtpa8VKGO?= =?utf-8?q?jitEzxkr4xf0SuW4Y9rS1lyeJOGGVjGATUzRD1o2G/bC6rEuDUSA2hiNKsNYTNBFw?= =?utf-8?q?lmyb5KXGWQcukLa+79epqGx8ml6/cj4ctq7t8/Tgux8wk2Nt0QZwI0BD2AgBJ5s8A?= =?utf-8?q?VSf5JEV0IGDxMXJoiwuA4U5WG+ZUV1+tEr40j9meY0wR2hg1QX9QXEOy2l51fOjIn?= =?utf-8?q?DgxazrFJ/OkwdAnNa/HtuwVvPk1i/ETMZniqC2uspsDUjOxMRYXyV+OWvnqfnm6In?= =?utf-8?q?IqesdbhGu33PkBfoIvLu8l6l0zRrtE3D+OCgoRJRIOnwhBy9pydDDXfpk2RM5b5Zm?= =?utf-8?q?20M8LD4lbn888RrUhZXJXjF1rRbJHPRRreaAcmDEDkU9KmlaT5wewv6va4X3YywRL?= =?utf-8?q?2OI3WxuhdUXwOashfnSBW3we1GwxaSwv2VbEY101zDwoZWJsADcMsCIa7+8zYq0M2?= =?utf-8?q?EMu2AfU7SjRaFId0B/m/Es6yf0rDA4EIAZQR9HojjQb4iRdW9ldeDHCkyxMQF83g3?= =?utf-8?q?hciMSAx3S6ouqseNuoyp0v3dXuwOZigd8GKsxrlZpPiT7/DyZwRUSYXqrgh/+jsWt?= =?utf-8?q?qXn/BdRQfEIJMdnV90eHXGK3IrVJaoWZJym9vM+FuV65XqL8eqvj43MDr/ExOb7Sn?= =?utf-8?q?DrjE3FW3JKrbbfeRvKm4seNhb/u+7FbltxqCEQf2rcm+WIEWWpaM+a9nH47llAf4v?= =?utf-8?q?fy0B33sm0I4mbilZKDfv/nvODBh0rXiOQ/1Wv0fqHiVBpV0GtGvQ/J0hDD2cESMU4?= =?utf-8?q?tWn+KMu6W760dRtL24I5AF5dYQe41oQMg4Uc9vfNuYkOcVnu80WzbgG1nX/UsttdR?= =?utf-8?q?QBucStLgm3rVTs+eCAcI6Z1cqiaqZsX5C7SVXRE+BY9RjTA2IfPIqoxETnLAw7tCm?= =?utf-8?q?6LtYn4b8Yel1A3jCAqFEMURaC2bL9kkHacbVEAPXAqetzE6ALPVATx9trwgpPyUYr?= =?utf-8?q?1rDsmr6xLqFmyrRKXXCsNjimP+GPds42qmkADyo+0XQIFXgVipfvyB13IYHWnD8G4?= =?utf-8?q?vVTcl2Wrs9D4WPTrxEswRhDgcU4bvCUxklBtqLU+nIRRopvej7jIM0/+EGHXVMZd3?= =?utf-8?q?fOoY9Ot2XWDOgB+10G41YpdPTPjAd3eWpaSX4+EkusmAYuMpU8+1r/X7ncCVt1QWQ?= =?utf-8?q?UUQ+/QvaKo8/?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b029d009-942a-465b-77a4-08dc1c206a88 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2024 14:34:33.2903 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: umuEQoWJ9Ef/0q8LbmvLze1mRa1FwXnHhbAzEUZg0UfRmArLoHWytncbdTXZUk6sdeLrHlcvvbUD7AxHyEGLFQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7304 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240123_063439_685760_6CB836BD X-CRM114-Status: GOOD ( 15.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Peng Fan There will be changes that init may fail, so adding return value for init function. Signed-off-by: Peng Fan --- drivers/mailbox/imx-mailbox.c | 35 ++++++++++++++++++++++++----------- 1 file changed, 24 insertions(+), 11 deletions(-) diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c index 656171362fe9..dced4614065f 100644 --- a/drivers/mailbox/imx-mailbox.c +++ b/drivers/mailbox/imx-mailbox.c @@ -110,7 +110,7 @@ struct imx_mu_dcfg { int (*tx)(struct imx_mu_priv *priv, struct imx_mu_con_priv *cp, void *data); int (*rx)(struct imx_mu_priv *priv, struct imx_mu_con_priv *cp); int (*rxdb)(struct imx_mu_priv *priv, struct imx_mu_con_priv *cp); - void (*init)(struct imx_mu_priv *priv); + int (*init)(struct imx_mu_priv *priv); enum imx_mu_type type; u32 xTR; /* Transmit Register0 */ u32 xRR; /* Receive Register0 */ @@ -737,7 +737,7 @@ static struct mbox_chan *imx_mu_seco_xlate(struct mbox_controller *mbox, return imx_mu_xlate(mbox, sp); } -static void imx_mu_init_generic(struct imx_mu_priv *priv) +static int imx_mu_init_generic(struct imx_mu_priv *priv) { unsigned int i; unsigned int val; @@ -757,7 +757,7 @@ static void imx_mu_init_generic(struct imx_mu_priv *priv) priv->mbox.of_xlate = imx_mu_xlate; if (priv->side_b) - return; + return 0; /* Set default MU configuration */ for (i = 0; i < IMX_MU_xCR_MAX; i++) @@ -770,9 +770,11 @@ static void imx_mu_init_generic(struct imx_mu_priv *priv) /* Clear any pending RSR */ for (i = 0; i < IMX_MU_NUM_RR; i++) imx_mu_read(priv, priv->dcfg->xRR + (i % 4) * 4); + + return 0; } -static void imx_mu_init_specific(struct imx_mu_priv *priv) +static int imx_mu_init_specific(struct imx_mu_priv *priv) { unsigned int i; int num_chans = priv->dcfg->type & IMX_MU_V2_S4 ? IMX_MU_S4_CHANS : IMX_MU_SCU_CHANS; @@ -794,12 +796,20 @@ static void imx_mu_init_specific(struct imx_mu_priv *priv) /* Set default MU configuration */ for (i = 0; i < IMX_MU_xCR_MAX; i++) imx_mu_write(priv, 0, priv->dcfg->xCR[i]); + + return 0; } -static void imx_mu_init_seco(struct imx_mu_priv *priv) +static int imx_mu_init_seco(struct imx_mu_priv *priv) { - imx_mu_init_generic(priv); + int ret; + + ret = imx_mu_init_generic(priv); + if (ret) + return ret; priv->mbox.of_xlate = imx_mu_seco_xlate; + + return 0; } static int imx_mu_probe(struct platform_device *pdev) @@ -866,7 +876,11 @@ static int imx_mu_probe(struct platform_device *pdev) priv->side_b = of_property_read_bool(np, "fsl,mu-side-b"); - priv->dcfg->init(priv); + ret = priv->dcfg->init(priv); + if (ret) { + dev_err(dev, "Failed to init MU\n"); + goto disable_clk; + } spin_lock_init(&priv->xcr_lock); @@ -878,10 +892,8 @@ static int imx_mu_probe(struct platform_device *pdev) platform_set_drvdata(pdev, priv); ret = devm_mbox_controller_register(dev, &priv->mbox); - if (ret) { - clk_disable_unprepare(priv->clk); - return ret; - } + if (ret) + goto disable_clk; pm_runtime_enable(dev); @@ -899,6 +911,7 @@ static int imx_mu_probe(struct platform_device *pdev) disable_runtime_pm: pm_runtime_disable(dev); +disable_clk: clk_disable_unprepare(priv->clk); return ret; }