diff mbox series

ARM: fault: Add "cut here" line for prefetch aborts

Message ID 20240123011211.work.227-kees@kernel.org (mailing list archive)
State New, archived
Headers show
Series ARM: fault: Add "cut here" line for prefetch aborts | expand

Commit Message

Kees Cook Jan. 23, 2024, 1:12 a.m. UTC 
The common pattern in arm is to emit a "8<--- cut here ---" line for
faults, but it was missing for do_PrefetchAbort(). Add it.

Cc: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
Cc: Ard Biesheuvel <ardb@kernel.org>
Cc: Wang Kefeng <wangkefeng.wang@huawei.com>
Cc: Ben Hutchings <ben@decadent.org.uk>
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Kees Cook <keescook@chromium.org>
---
 arch/arm/mm/fault.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Ard Biesheuvel Jan. 23, 2024, 1:46 p.m. UTC | #1 
On Tue, 23 Jan 2024 at 02:12, Kees Cook <keescook@chromium.org> wrote:
>
> The common pattern in arm is to emit a "8<--- cut here ---" line for
> faults, but it was missing for do_PrefetchAbort(). Add it.
>
> Cc: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
> Cc: Ard Biesheuvel <ardb@kernel.org>
> Cc: Wang Kefeng <wangkefeng.wang@huawei.com>
> Cc: Ben Hutchings <ben@decadent.org.uk>
> Cc: linux-arm-kernel@lists.infradead.org
> Signed-off-by: Kees Cook <keescook@chromium.org>

Acked-by: Ard Biesheuvel <ardb@kernel.org>

> ---
>  arch/arm/mm/fault.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mm/fault.c b/arch/arm/mm/fault.c
> index e96fb40b9cc3..e804432e905e 100644
> --- a/arch/arm/mm/fault.c
> +++ b/arch/arm/mm/fault.c
> @@ -586,6 +586,7 @@ do_PrefetchAbort(unsigned long addr, unsigned int ifsr, struct pt_regs *regs)
>         if (!inf->fn(addr, ifsr | FSR_LNX_PF, regs))
>                 return;
>
> +       pr_alert("8<--- cut here ---\n");
>         pr_alert("Unhandled prefetch abort: %s (0x%03x) at 0x%08lx\n",
>                 inf->name, ifsr, addr);
>
> --
> 2.34.1
>
diff mbox series

Patch

diff --git a/arch/arm/mm/fault.c b/arch/arm/mm/fault.c
index e96fb40b9cc3..e804432e905e 100644
--- a/arch/arm/mm/fault.c
+++ b/arch/arm/mm/fault.c
@@ -586,6 +586,7 @@  do_PrefetchAbort(unsigned long addr, unsigned int ifsr, struct pt_regs *regs)
 	if (!inf->fn(addr, ifsr | FSR_LNX_PF, regs))
 		return;
 
+	pr_alert("8<--- cut here ---\n");
 	pr_alert("Unhandled prefetch abort: %s (0x%03x) at 0x%08lx\n",
 		inf->name, ifsr, addr);