| Message ID | 20240205-ltdc_mp13-v1-4-072d24bf1b36@foss.st.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add display support for stm32mp135f-dk board | expand |
On 05/02/2024 10:06, Raphael Gallais-Pou wrote: > DISPLAY_FLAGS_SYNC_POSEDGE is missing in the flags on the default > timings. When overriding the default mode with one described in the > device tree, the mode does not get acked because of this missing flag. > Moreover since the panel is driven by the positive edge it makes sense > to add it here. > > Signed-off-by: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com> > --- > drivers/gpu/drm/panel/panel-simple.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 2214cb09678c..7b286382ffb4 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -3523,7 +3523,8 @@ static const struct display_timing rocktech_rk043fn48h_timing = { > .vfront_porch = { 1, 4, 4 }, > .vsync_len = { 1, 10, 10 }, > .flags = DISPLAY_FLAGS_VSYNC_LOW | DISPLAY_FLAGS_HSYNC_LOW | > - DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_PIXDATA_POSEDGE, > + DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_PIXDATA_POSEDGE | > + DISPLAY_FLAGS_SYNC_POSEDGE, > }; > > static const struct panel_desc rocktech_rk043fn48h = { > Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
On 2/5/2024 1:06 AM, Raphael Gallais-Pou wrote: > DISPLAY_FLAGS_SYNC_POSEDGE is missing in the flags on the default > timings. When overriding the default mode with one described in the > device tree, the mode does not get acked because of this missing flag. > Moreover since the panel is driven by the positive edge it makes sense > to add it here. > > Signed-off-by: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com> Hi Raphael, Reviewed-by: Jessica Zhang <quic_jesszhan@quicinc.com> Thanks, Jessica Zhang > --- > drivers/gpu/drm/panel/panel-simple.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 2214cb09678c..7b286382ffb4 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -3523,7 +3523,8 @@ static const struct display_timing rocktech_rk043fn48h_timing = { > .vfront_porch = { 1, 4, 4 }, > .vsync_len = { 1, 10, 10 }, > .flags = DISPLAY_FLAGS_VSYNC_LOW | DISPLAY_FLAGS_HSYNC_LOW | > - DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_PIXDATA_POSEDGE, > + DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_PIXDATA_POSEDGE | > + DISPLAY_FLAGS_SYNC_POSEDGE, > }; > > static const struct panel_desc rocktech_rk043fn48h = { > > -- > 2.25.1 >
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 2214cb09678c..7b286382ffb4 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -3523,7 +3523,8 @@ static const struct display_timing rocktech_rk043fn48h_timing = { .vfront_porch = { 1, 4, 4 }, .vsync_len = { 1, 10, 10 }, .flags = DISPLAY_FLAGS_VSYNC_LOW | DISPLAY_FLAGS_HSYNC_LOW | - DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_PIXDATA_POSEDGE, + DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_PIXDATA_POSEDGE | + DISPLAY_FLAGS_SYNC_POSEDGE, }; static const struct panel_desc rocktech_rk043fn48h = {
DISPLAY_FLAGS_SYNC_POSEDGE is missing in the flags on the default timings. When overriding the default mode with one described in the device tree, the mode does not get acked because of this missing flag. Moreover since the panel is driven by the positive edge it makes sense to add it here. Signed-off-by: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com> --- drivers/gpu/drm/panel/panel-simple.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)