From patchwork Thu Feb 8 10:35:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kurt Kanzenbach X-Patchwork-Id: 13549689 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48589C48260 for ; Thu, 8 Feb 2024 11:46:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Message-Id:MIME-Version:Subject: Date:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=h+kBxj0Nx2KWAxxZd5VKAE3HbCyNU4i5qhL8akFvD1g=; b=WCDttPZ6Wsxq8l tz0+Ucjt6p/GkDKUZOxpXzwhgmdCykrr89rlLEhysxpx3EpieQLeG0y2flRPvyO2s6+Z5XcMXJUM8 Vej3lHc+OIWY2FzmzNy2WMqjUm0JbAZmV0U4sOnZpfaehBKEkXclt6jkThF3RtkpHHEj1C45Wi+uv W9BhhkFWxZZa0T1i9+kHOediv6f6koPLDH8ICATLwYO3a8JRlBUE3Gy70vOkwsDWtZthrvv9KqANH V/nR1DW1YDH3n/+PAVCp8D7Jc49MrApki+Yf7yGOieaJphQ/S1XRy2H7vCTfw2AijHV0ilVLt5KPT fSS4G1xzE47dZ/QW3zcw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rY2rX-0000000Dcax-2qbp; Thu, 08 Feb 2024 11:46:41 +0000 Received: from galois.linutronix.de ([193.142.43.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rY1kz-0000000DNkn-00XO for linux-arm-kernel@lists.infradead.org; Thu, 08 Feb 2024 10:35:51 +0000 From: Kurt Kanzenbach DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1707388545; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=O8FbyMLRAf0MPPkiZw7u/45AM7lfLrYJ9PmRTbq1LVE=; b=i1R6VbZadJXN4evezJU3+AfnzMNV8Ufv037Ye1lMlAU9W4BqV73Bl3olyJhF/UfVyyYm6i AzvxBaW9KTA23MIUOn/NPVJwTv6qyNIbM5GkDnOZN58ZDzhFka16o0mD6quoKyJddMEwr5 EgLxYUwWxj9BZJ5nunC0tC8jxNuyUFEM+iAhE/CKiQBBxy07+/B3iID+Q5OEeufDLVljee pIJv8Z0FU08xpDSjfABqFuCITnCZpwrSo1/F81WPlK69tYSnmTKbnGXSrZisfwSrLXSnDc JGFzfsjYKIOdYEcjBPWcDb+BlK0elp9oqI44Mfl/f3grZAVn2a6ImzpVb8rRrg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1707388545; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=O8FbyMLRAf0MPPkiZw7u/45AM7lfLrYJ9PmRTbq1LVE=; b=rVNmJZsoRL/7zc5amA+WEs/jUMej37PPpGOnmELL1OLBfqFWEzbFhYOwpGRrZZ/G8yTA83 nLpKpS9US8okTlAQ== Date: Thu, 08 Feb 2024 11:35:25 +0100 Subject: [PATCH net-next] net: stmmac: Simplify mtl IRQ status checking MIME-Version: 1.0 Message-Id: <20240208-stmmac_irq-v1-1-8bab236026d4@linutronix.de> X-B4-Tracking: v=1; b=H4sIAGyuxGUC/x2N0QrCMAwAf2Xk2UItzlZ/RUSymrk8NGpSZDD27 +t8PI7jFjBSJoNrt4DSj43f0uB46CBPKC9y/GwMwYeTDz45q6VgfrB+XR/PKYwYY8oXaMGARm5 QlDztSUGrpLv4KI08/y83EKpOaK5wX9cNWvkro38AAAA= To: Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin Cc: Yannick Vignon , Sebastian Andrzej Siewior , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Kurt Kanzenbach X-Developer-Signature: v=1; a=openpgp-sha256; l=1321; i=kurt@linutronix.de; h=from:subject:message-id; bh=XYU8UThxyVM/BmRkaWbkfJ/UUWs7MkJRNJWR7CTFe+g=; b=owEBbQKS/ZANAwAKAcGT0fKqRnOCAcsmYgBlxK6Atb08JaTdEHu7F+d5W5Op9N65/uLVyQhBt IlsR7kKKRaJAjMEAAEKAB0WIQS8ub+yyMN909/bWZLBk9HyqkZzggUCZcSugAAKCRDBk9HyqkZz gm5XD/43iUUdoU4KgOL+dc14oqp3MKYJwu278fwqFSQWR8q9etX6XukXKnNp3QFfDet2+nwrCk/ vjO93JpRiaL3UBsxrw6pljF1hAPwdfPHFOsk1WAXFRXvc4V5/RSjskdxOTbuBOexmPhvTph+gpg p19k8FVIEwnao1Zw/MVpslZNGW5DbLCwNIxnqVvoKjXkd/3WUrMEvWdCj/Lg3gIYjewXJbx9jxB 9SnDFqMHN8diP4ybcS7xsnt3drAOiKaLsdhu8O8ID7VaMyj2j8UfJSZ/lUgAr6TgmFN/dJ1w3Q/ PVWOH2blV0Md9Pf45U0Hivc632odzpInvaMOv1eHtrGeIHWM/7vVsNZXWW3BgYZDjAqrH1emM/Q 8s7IzXLytvKO2DOMxCjgewx5OXOo5UW5KGQHN5XDXmqGGmpT/RiowcQBZUHrob6sbbl0je/x4T/ VMKeZk97xA4z7xI03rEvsobCWDuSe67eTBA8W9+9PfN3xqTom8f2ImjasCQ0GRj/ZswRyEP70Om qBDrd6+Ss1mXosZu9kNYNkX1jtZ9PTaMnVGEgBSYoV2Rg7TcwjByMMDZGLC9qQkGwfbHKYrZXhZ kTSBuR8RTMpi1CLXy9MuJTPSf8+pU5XJPqtUkN1O4qekO+WwtZYY4HWnmjKWGeYCqITAtCNQoI1 BlWB4xJLbkdMK0g== X-Developer-Key: i=kurt@linutronix.de; a=openpgp; fpr=BCB9BFB2C8C37DD3DFDB5992C193D1F2AA467382 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240208_023549_252271_2A9287C2 X-CRM114-Status: UNSURE ( 8.26 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Commit 8a7cb245cf28 ("net: stmmac: Do not enable RX FIFO overflow interrupts") disabled the RX FIFO overflow interrupts. However, it left the status variable around, but never checks it. As stmmac_host_mtl_irq_status() returns only 0 now, the code can be simplified. Signed-off-by: Kurt Kanzenbach --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) --- base-commit: 006e89649fa913e285b931f1b8dfd6485d153ca7 change-id: 20240208-stmmac_irq-57682fa778c9 Best regards, diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 04d817dc5899..10ce2f272b62 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -6036,10 +6036,8 @@ static void stmmac_common_interrupt(struct stmmac_priv *priv) priv->tx_path_in_lpi_mode = false; } - for (queue = 0; queue < queues_count; queue++) { - status = stmmac_host_mtl_irq_status(priv, priv->hw, - queue); - } + for (queue = 0; queue < queues_count; queue++) + stmmac_host_mtl_irq_status(priv, priv->hw, queue); /* PCS link status */ if (priv->hw->pcs &&