| Message ID | 20240209171146.307465-1-romain.naour@smile.fr (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/2] arm64: dts: ti: k3-am69-sk: fix PMIC interrupt number | expand |
Hi Romain On 09/02/24 22:41, Romain Naour wrote: > The tps659413 node set WKUP_GPIO0_83 (AA37) pin as input to be used as > PMIC interrupt but uses 39 (WKUP_GPIO0_39) as "interrupts" property. > > Replace 39 by 83 after checking in the board schematic [1]. > > [1] https://www.ti.com/tool/SK-AM69 > > Fixes: 865a1593bf99 ("arm64: dts: ti: k3-am69-sk: Add support for TPS6594 PMIC") > Cc: Neha Malcom Francis <n-francis@ti.com> > Signed-off-by: Romain Naour <romain.naour@smile.fr> > --- > arch/arm64/boot/dts/ti/k3-am69-sk.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-am69-sk.dts b/arch/arm64/boot/dts/ti/k3-am69-sk.dts > index 8da591579868..95c9d3da59d3 100644 > --- a/arch/arm64/boot/dts/ti/k3-am69-sk.dts > +++ b/arch/arm64/boot/dts/ti/k3-am69-sk.dts > @@ -646,7 +646,7 @@ tps659413: pmic@48 { > pinctrl-names = "default"; > pinctrl-0 = <&pmic_irq_pins_default>; > interrupt-parent = <&wkup_gpio0>; > - interrupts = <39 IRQ_TYPE_EDGE_FALLING>; > + interrupts = <83 IRQ_TYPE_EDGE_FALLING>; > gpio-controller; > #gpio-cells = <2>; > ti,primary-pmic; Thanks for catching this! Reviewed-by: Neha Malcom Francis <n-francis@ti.com>
Hi Romain Naour, On Fri, 09 Feb 2024 18:11:45 +0100, Romain Naour wrote: > The tps659413 node set WKUP_GPIO0_83 (AA37) pin as input to be used as > PMIC interrupt but uses 39 (WKUP_GPIO0_39) as "interrupts" property. > > Replace 39 by 83 after checking in the board schematic [1]. > > [1] https://www.ti.com/tool/SK-AM69 > > [...] I have applied the following to branch ti-k3-dts-next on [1]. Thank you! [1/2] arm64: dts: ti: k3-am69-sk: fix PMIC interrupt number commit: 9673acae37ce06bebfe75b38c15952cab05da896 [2/2] arm64: dts: ti: k3-j721e-sk: fix PMIC interrupt number commit: 59974c38ded179cac63a3fa1a8adaaa1048cdc41 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent up the chain during the next merge window (or sooner if it is a relevant bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. [1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git -- Vignesh
diff --git a/arch/arm64/boot/dts/ti/k3-am69-sk.dts b/arch/arm64/boot/dts/ti/k3-am69-sk.dts index 8da591579868..95c9d3da59d3 100644 --- a/arch/arm64/boot/dts/ti/k3-am69-sk.dts +++ b/arch/arm64/boot/dts/ti/k3-am69-sk.dts @@ -646,7 +646,7 @@ tps659413: pmic@48 { pinctrl-names = "default"; pinctrl-0 = <&pmic_irq_pins_default>; interrupt-parent = <&wkup_gpio0>; - interrupts = <39 IRQ_TYPE_EDGE_FALLING>; + interrupts = <83 IRQ_TYPE_EDGE_FALLING>; gpio-controller; #gpio-cells = <2>; ti,primary-pmic;
The tps659413 node set WKUP_GPIO0_83 (AA37) pin as input to be used as PMIC interrupt but uses 39 (WKUP_GPIO0_39) as "interrupts" property. Replace 39 by 83 after checking in the board schematic [1]. [1] https://www.ti.com/tool/SK-AM69 Fixes: 865a1593bf99 ("arm64: dts: ti: k3-am69-sk: Add support for TPS6594 PMIC") Cc: Neha Malcom Francis <n-francis@ti.com> Signed-off-by: Romain Naour <romain.naour@smile.fr> --- arch/arm64/boot/dts/ti/k3-am69-sk.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)