| Message ID | 20240211-bus_cleanup-arm-v1-1-5c0102bda0bd@marliere.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM: s3c64xx: make s3c6410_subsys const | expand |
On 11/02/2024 16:41, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
This "Now" was confusing last time and is still... There is often no
"Now" in multi-tree-repo-approach. If the patch allows it went through
different tree, this is still false. If this was already merged into
mainline, just say since which commit or which release.
I raised my concerns last time, so please fix all your future patches
after receiving such feedback.
Best regards,
Krzysztof
Hi Krzysztof, On 11 Feb 16:45, Krzysztof Kozlowski wrote: > On 11/02/2024 16:41, Ricardo B. Marliere wrote: > > Now that the driver core can properly handle constant struct bus_type, > > This "Now" was confusing last time and is still... There is often no > "Now" in multi-tree-repo-approach. If the patch allows it went through > different tree, this is still false. If this was already merged into > mainline, just say since which commit or which release. > > I raised my concerns last time, so please fix all your future patches > after receiving such feedback. You're right, I'll keep this in mind. Will send a v2. Thanks for reviewing, - Ricardo. > > > > Best regards, > Krzysztof >
diff --git a/arch/arm/mach-s3c/cpu.h b/arch/arm/mach-s3c/cpu.h index d0adc9b40e25..a0187606b999 100644 --- a/arch/arm/mach-s3c/cpu.h +++ b/arch/arm/mach-s3c/cpu.h @@ -76,6 +76,6 @@ extern void s3c24xx_init_uartdevs(char *name, struct s3c24xx_uart_resources *res, struct s3c2410_uartcfg *cfg, int no); -extern struct bus_type s3c6410_subsys; +extern const struct bus_type s3c6410_subsys; #endif diff --git a/arch/arm/mach-s3c/s3c6410.c b/arch/arm/mach-s3c/s3c6410.c index e79f18d0ca81..a29276a4fde5 100644 --- a/arch/arm/mach-s3c/s3c6410.c +++ b/arch/arm/mach-s3c/s3c6410.c @@ -57,7 +57,7 @@ void __init s3c6410_init_irq(void) s3c64xx_init_irq(~0 & ~(1 << 7), ~0); } -struct bus_type s3c6410_subsys = { +const struct bus_type s3c6410_subsys = { .name = "s3c6410-core", .dev_name = "s3c6410-core", };
Now that the driver core can properly handle constant struct bus_type, move the s3c6410_subsys variable to be a constant structure as well, placing it into read-only memory which can not be modified at runtime. Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net> --- arch/arm/mach-s3c/cpu.h | 2 +- arch/arm/mach-s3c/s3c6410.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) --- base-commit: fee3a71dc8d26629e5d87e20cff08763f522633f change-id: 20240211-bus_cleanup-arm-da0f2550ca48 Best regards,