| Message ID | 20240211081739.395-2-jszhang@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: allwinner: h618: Add Sipeed Longan SoM 3H and Pi 3H board | expand |
On 11/02/2024 09:17, Jisheng Zhang wrote: > Add name & compatible for the Sipeed Longan Module 3H and Longan PI 3H > board. > > Signed-off-by: Jisheng Zhang <jszhang@kernel.org> > Reviewed-by: Andre Przywara <andre.przywara@arm.com> > --- This is a friendly reminder during the review process. It looks like you received a tag and forgot to add it. If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions, under or above your Signed-off-by tag. Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply. https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 If a tag was not added on purpose, please state why and what changed. Best regards, Krzysztof
On Sun, Feb 11, 2024 at 05:29:32PM +0100, Krzysztof Kozlowski wrote: > On 11/02/2024 09:17, Jisheng Zhang wrote: > > Add name & compatible for the Sipeed Longan Module 3H and Longan PI 3H > > board. > > > > Signed-off-by: Jisheng Zhang <jszhang@kernel.org> > > Reviewed-by: Andre Przywara <andre.przywara@arm.com> > > --- > > This is a friendly reminder during the review process. Oops, I forgot to add Conor's ack... > > It looks like you received a tag and forgot to add it. > > If you do not know the process, here is a short explanation: > Please add Acked-by/Reviewed-by/Tested-by tags when posting new > versions, under or above your Signed-off-by tag. Tag is "received", when > provided in a message replied to you on the mailing list. Tools like b4 > can help here. However, there's no need to repost patches *only* to add > the tags. The upstream maintainer will do that for tags received on the > version they apply. IIRC, the b4 can only help on the latest version. If I missed the ack in v3, the ack tag will be lost. So how to handle this case? repost or Conor gave an ack to v3 again? Thanks for your information. > > https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 > > If a tag was not added on purpose, please state why and what changed. > Best regards, > Krzysztof >
On Mon, Feb 12, 2024 at 06:34:36PM +0800, Jisheng Zhang wrote: > On Sun, Feb 11, 2024 at 05:29:32PM +0100, Krzysztof Kozlowski wrote: > > On 11/02/2024 09:17, Jisheng Zhang wrote: > > > Add name & compatible for the Sipeed Longan Module 3H and Longan PI 3H > > > board. > > > > > > Signed-off-by: Jisheng Zhang <jszhang@kernel.org> > > > Reviewed-by: Andre Przywara <andre.przywara@arm.com> > > > --- > > > > This is a friendly reminder during the review process. > > Oops, I forgot to add Conor's ack... > > > > It looks like you received a tag and forgot to add it. > > > > If you do not know the process, here is a short explanation: > > Please add Acked-by/Reviewed-by/Tested-by tags when posting new > > versions, under or above your Signed-off-by tag. Tag is "received", when > > provided in a message replied to you on the mailing list. Tools like b4 > > can help here. However, there's no need to repost patches *only* to add > > the tags. The upstream maintainer will do that for tags received on the > > version they apply. > > IIRC, the b4 can only help on the latest version. If I missed the ack > in v3, the ack tag will be lost. So how to handle this case? repost or > Conor gave an ack to v3 again? I think what the form letter means is that b4 could've been used to update the tags before you sent out this version. Acked-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor.
diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml index a9d8e85565b8..a97d44ba10ac 100644 --- a/Documentation/devicetree/bindings/arm/sunxi.yaml +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml @@ -835,6 +835,12 @@ properties: - const: sinlinx,sina33 - const: allwinner,sun8i-a33 + - description: Sipeed Longan Pi 3H board for the Sipeed Longan Module 3H + items: + - const: sipeed,longan-pi-3h + - const: sipeed,longan-module-3h + - const: allwinner,sun50i-h618 + - description: SourceParts PopStick v1.1 items: - const: sourceparts,popstick-v1.1