diff mbox series

[net-next,v2] net: ti: icssg-prueth: Remove duplicate cleanup calls in emac_ndo_stop()

Message ID 20240215152203.431268-1-diogo.ivo@siemens.com (mailing list archive)
State New, archived
Headers show
Series [net-next,v2] net: ti: icssg-prueth: Remove duplicate cleanup calls in emac_ndo_stop() | expand

Commit Message

Diogo Ivo Feb. 15, 2024, 3:22 p.m. UTC 
Remove the duplicate calls to prueth_emac_stop() and
prueth_cleanup_tx_chns() in emac_ndo_stop().

Signed-off-by: Diogo Ivo <diogo.ivo@siemens.com>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
Reviewed-by: MD Danish Anwar <danishanwar@ti.com>
---
Changes in v2:
 - Removed Fixes: tags
 - Added Reviewed-by's

 drivers/net/ethernet/ti/icssg/icssg_prueth.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Dan Carpenter Feb. 15, 2024, 4:52 p.m. UTC | #1 
On Thu, Feb 15, 2024 at 03:22:01PM +0000, Diogo Ivo wrote:
> Remove the duplicate calls to prueth_emac_stop() and
> prueth_cleanup_tx_chns() in emac_ndo_stop().
> 
> Signed-off-by: Diogo Ivo <diogo.ivo@siemens.com>
> Reviewed-by: Roger Quadros <rogerq@kernel.org>
> Reviewed-by: MD Danish Anwar <danishanwar@ti.com>
> ---
> Changes in v2:
>  - Removed Fixes: tags
>  - Added Reviewed-by's

Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>

regards,
dan carpenter
patchwork-bot+netdevbpf@kernel.org Feb. 16, 2024, noon UTC | #2 
Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Thu, 15 Feb 2024 15:22:01 +0000 you wrote:
> Remove the duplicate calls to prueth_emac_stop() and
> prueth_cleanup_tx_chns() in emac_ndo_stop().
> 
> Signed-off-by: Diogo Ivo <diogo.ivo@siemens.com>
> Reviewed-by: Roger Quadros <rogerq@kernel.org>
> Reviewed-by: MD Danish Anwar <danishanwar@ti.com>
> 
> [...]

Here is the summary with links:
  - [net-next,v2] net: ti: icssg-prueth: Remove duplicate cleanup calls in emac_ndo_stop()
    https://git.kernel.org/netdev/net-next/c/1d085e9ce384

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth.c b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
index 411898a4f38c..cf7b73f8f450 100644
--- a/drivers/net/ethernet/ti/icssg/icssg_prueth.c
+++ b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
@@ -1489,9 +1489,6 @@  static int emac_ndo_stop(struct net_device *ndev)
 	/* Destroying the queued work in ndo_stop() */
 	cancel_delayed_work_sync(&emac->stats_work);
 
-	/* stop PRUs */
-	prueth_emac_stop(emac);
-
 	if (prueth->emacs_initialized == 1)
 		icss_iep_exit(emac->iep);
 
@@ -1502,7 +1499,6 @@  static int emac_ndo_stop(struct net_device *ndev)
 
 	free_irq(emac->rx_chns.irq[rx_flow], emac);
 	prueth_ndev_del_tx_napi(emac, emac->tx_ch_num);
-	prueth_cleanup_tx_chns(emac);
 
 	prueth_cleanup_rx_chns(emac, &emac->rx_chns, max_rx_flows);
 	prueth_cleanup_tx_chns(emac);