From patchwork Thu Feb 15 15:22:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Diogo Ivo X-Patchwork-Id: 13558672 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69A34C4829E for ; Thu, 15 Feb 2024 15:23:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=nPwEMTTX+r3nJLBdjOm5ynOMJ6G4IM6TMvV7b7WjvUg=; b=5AWwdhuTYj229w WCD7aOiwaueI8T25SQd4X8I1qOY6rX4/wQUXeO1OPhPplmxl5STesF8UgtWFJxr6gSFnPi98PdUDZ vEr0fOItVO5IntqbqBE6f8sTkUM9qB2kZ//VmJQdYuMJkp9ltK+2WdAE4snR9GVABelOuJOOHC/YS YWZOBCUjRj9QEzo35SrTaloAqXxGvDFDfNLqcJ9tOMoMGD3RvA0qFLj+1+nVDMciD9ZlbIDE3zZaa uK+uzRReBb1UT4T/fO7NPVAQFlkL1VXDzP+O9uBqq6QwL1e9S+dsn1+bHPic3eQgVmONJttUyFt3p G310P10/fhx7FUwKsB6Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1radZb-0000000Giku-3wQX; Thu, 15 Feb 2024 15:22:51 +0000 Received: from mta-64-225.siemens.flowmailer.net ([185.136.64.225]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1radZY-0000000GijZ-14XD for linux-arm-kernel@lists.infradead.org; Thu, 15 Feb 2024 15:22:50 +0000 Received: by mta-64-225.siemens.flowmailer.net with ESMTPSA id 20240215152243e80611b0d3920f1efc for ; Thu, 15 Feb 2024 16:22:43 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=fm1; d=siemens.com; i=diogo.ivo@siemens.com; h=Date:From:Subject:To:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Cc; bh=nuPT01weBKXw5lY3LWl5ewOYMWR86hkUe5K2ujILz3M=; b=WSFCdqFkdPSyf+CjiQLHiiidUlTGuRay8ha8SX2t903CHQ46BgNrhbhaw6UuE4YfmmO4+d PDH9bSM135kPuc0DZGbffXIfqyySQTjHJo4CwEv92g7EAq0HROIYM0Ar8hMqZbmtRMTVkXJW PH+Ij0JsMoNSZoE0LI8f3HN0q607A=; From: Diogo Ivo To: danishanwar@ti.com, rogerq@kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew@lunn.ch, jan.kiszka@siemens.com, dan.carpenter@linaro.org, robh@kernel.org Cc: Diogo Ivo , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: [PATCH net-next v2] net: ti: icssg-prueth: Remove duplicate cleanup calls in emac_ndo_stop() Date: Thu, 15 Feb 2024 15:22:01 +0000 Message-ID: <20240215152203.431268-1-diogo.ivo@siemens.com> MIME-Version: 1.0 X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-1320519:519-21489:flowmailer X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240215_072248_794862_B7739945 X-CRM114-Status: UNSURE ( 7.09 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Remove the duplicate calls to prueth_emac_stop() and prueth_cleanup_tx_chns() in emac_ndo_stop(). Signed-off-by: Diogo Ivo Reviewed-by: Roger Quadros Reviewed-by: MD Danish Anwar Reviewed-by: Dan Carpenter --- Changes in v2: - Removed Fixes: tags - Added Reviewed-by's drivers/net/ethernet/ti/icssg/icssg_prueth.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth.c b/drivers/net/ethernet/ti/icssg/icssg_prueth.c index 411898a4f38c..cf7b73f8f450 100644 --- a/drivers/net/ethernet/ti/icssg/icssg_prueth.c +++ b/drivers/net/ethernet/ti/icssg/icssg_prueth.c @@ -1489,9 +1489,6 @@ static int emac_ndo_stop(struct net_device *ndev) /* Destroying the queued work in ndo_stop() */ cancel_delayed_work_sync(&emac->stats_work); - /* stop PRUs */ - prueth_emac_stop(emac); - if (prueth->emacs_initialized == 1) icss_iep_exit(emac->iep); @@ -1502,7 +1499,6 @@ static int emac_ndo_stop(struct net_device *ndev) free_irq(emac->rx_chns.irq[rx_flow], emac); prueth_ndev_del_tx_napi(emac, emac->tx_ch_num); - prueth_cleanup_tx_chns(emac); prueth_cleanup_rx_chns(emac, &emac->rx_chns, max_rx_flows); prueth_cleanup_tx_chns(emac);