From patchwork Tue Feb 20 14:59:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vincent Guittot X-Patchwork-Id: 13564123 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D6FDDC5475B for ; Tue, 20 Feb 2024 15:00:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YcRKL2zi5Ay+lWAC3Zw42MbBBNKbBwE9chpDVwDxdGA=; b=2x/dXfCn1f0LsE NSJ5gHbbGXZ5TU09T+g4nlbof7wFHrZ2bzfgTYCvFFp2M/SzEZO/6Jzkwg/5PWSnOz0gYOswlgT9C 1RPbcAG9pOy0MDmftJSZwWDCWDOBZeUzMGwQ3dD7g5xUMylWH1YrzohVxgQMRo3hnCzTb4BR9Xa1M L9P+t7Qpqy8nMVOS1eoTIiXLd8ChkzwIt31S65AqTBYsrAjXU9qioNTaG3Fhg2BkLdtPmJguTepuH gOteRzgooL9JRynulA0DQl2XaRnrabKG6MYIDuL/j/8IJBIi7H26313glQAMesCVGz5Mpru4T8iwL yhczLAf6Fr2U5TDpCX8A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcRbe-0000000FAjq-2Xi7; Tue, 20 Feb 2024 15:00:26 +0000 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcRbF-0000000FAVX-0xIi for linux-arm-kernel@lists.infradead.org; Tue, 20 Feb 2024 15:00:03 +0000 Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-33d118a181fso2766048f8f.1 for ; Tue, 20 Feb 2024 07:00:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708441199; x=1709045999; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OJN21V1bop2AoQQK03hl+NSFZtBSAxp4abYemrkmzIE=; b=XmZZRjt5RSrv4VVI58kKawn43u82nTUtfVYOWLT56fwawnw23ynG5V27hMGZQm4oQW LQFRtCLeTASgFg7D2qPpnfEltkkKrGA5pDNAvt5zjtXUrgYQXMEHw/Cn8/w/LKOoQau7 E8Jgn0hYWXRC6Q4G4syf2BMAxv/5xv9w+F3UsWNQWOQf/F6ufI0mHUyuq3QRpRdNLvwn 6SmpwEAHH3I/QC5IbFQkxaw0MF5GVr/N1JFijpBNBfArKq1fWL2GwzkJnNPIfvo9M6xQ y4xfHzFezkBg5H/Y1+di5HL/uv3K+0sGVo2USZt0XdhkQg/kRINe8aLz/h6xU+6nETyv Csbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708441199; x=1709045999; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OJN21V1bop2AoQQK03hl+NSFZtBSAxp4abYemrkmzIE=; b=QMngRCsfwTo2eIMLPaxkzT/TLfirNTYkvaIvQkmjvJGB5USdbcMDmRWwd8afcTEGV1 hi5G/tA8AeJ/f8ILKuHjgVfKDO8Hrg112dh0o6ZOCFB4SDgq41pqHlfxUYZYUmGSYPXN XN24MhXobjmrJ026+I9+/ooIhwns2VqK6rjkP9C9yadwMUUW21tmWxThL1MJqmc2jmz1 a/bxEZigXxAEIitTPuUe56wdZMIUablhKoVtMfojQgJEfbx1ojHyaCwuELxksOQ2Xsk8 fzNnJGGSxjLiodr2JFGcQ363iteRrlbicNqcRxAKq5OzXw/bw6UBBkwC6Sfec2mhyUru sJ6g== X-Forwarded-Encrypted: i=1; AJvYcCV2NYwfdmcwmFnSuG9ext9OmCQlxiLdrrDlGkUP926vpRRl/isHwPCBLRZT1Pq9qwguJyMqRFXLyfbEseAded6K+tbN87x5H6h97frZI4+IxH8cxFY= X-Gm-Message-State: AOJu0YxW4R44c53kF5zVSLnha0CHg/6l1AWF5N31YVh8fqU1Smeg6Bgf BwvLA5mTMJcazPJUERI2TjU0NXoZGyKQRfO5TkBSsHeTMIVZsvRM/rWCM8IXR7U= X-Google-Smtp-Source: AGHT+IF9tJG6cYo5kMgHAyXSW6LLub4Cy4QdsaVLmULHXyA1+3Ik6b0caALozs4YQUihhJTnKqZHLg== X-Received: by 2002:a5d:64a7:0:b0:33d:ed4:5c86 with SMTP id m7-20020a5d64a7000000b0033d0ed45c86mr13698111wrp.63.1708441199370; Tue, 20 Feb 2024 06:59:59 -0800 (PST) Received: from vingu-book.. ([2a01:e0a:f:6020:8deb:bfb9:b028:6d5c]) by smtp.gmail.com with ESMTPSA id v4-20020a5d6784000000b0033d39626c27sm9304405wru.76.2024.02.20.06.59.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Feb 2024 06:59:58 -0800 (PST) From: Vincent Guittot To: linux@armlinux.org.uk, catalin.marinas@arm.com, will@kernel.org, sudeep.holla@arm.com, rafael@kernel.org, viresh.kumar@linaro.org, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, lukasz.luba@arm.com, rui.zhang@intel.com, mhiramat@kernel.org, daniel.lezcano@linaro.org, amit.kachhap@gmail.com, corbet@lwn.net, gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org Cc: Vincent Guittot Subject: [PATCH v5 3/5] thermal/cpufreq: Remove arch_update_thermal_pressure() Date: Tue, 20 Feb 2024 15:59:45 +0100 Message-Id: <20240220145947.1107937-4-vincent.guittot@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240220145947.1107937-1-vincent.guittot@linaro.org> References: <20240220145947.1107937-1-vincent.guittot@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240220_070001_563787_29AA2B03 X-CRM114-Status: GOOD ( 11.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org arch_update_thermal_pressure() aims to update fast changing signal which should be averaged using PELT filtering before being provided to the scheduler which can't make smart use of fast changing signal. cpufreq now provides the maximum freq_qos pressure on the capacity to the scheduler, which includes cpufreq cooling device. Remove the call to arch_update_thermal_pressure() in cpufreq cooling device as this is handled by cpufreq_get_pressure(). Signed-off-by: Vincent Guittot Reviewed-by: Lukasz Luba Acked-by: Viresh Kumar --- drivers/thermal/cpufreq_cooling.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/thermal/cpufreq_cooling.c b/drivers/thermal/cpufreq_cooling.c index e2cc7bd30862..e77d3b44903e 100644 --- a/drivers/thermal/cpufreq_cooling.c +++ b/drivers/thermal/cpufreq_cooling.c @@ -448,7 +448,6 @@ static int cpufreq_set_cur_state(struct thermal_cooling_device *cdev, unsigned long state) { struct cpufreq_cooling_device *cpufreq_cdev = cdev->devdata; - struct cpumask *cpus; unsigned int frequency; int ret; @@ -465,8 +464,6 @@ static int cpufreq_set_cur_state(struct thermal_cooling_device *cdev, ret = freq_qos_update_request(&cpufreq_cdev->qos_req, frequency); if (ret >= 0) { cpufreq_cdev->cpufreq_state = state; - cpus = cpufreq_cdev->policy->related_cpus; - arch_update_thermal_pressure(cpus, frequency); ret = 0; }