diff mbox series

[2/2] arm64: dts: imx8mn: tqma8mqnl-mba8mx: Add missing USB PHY vbus supply

Message ID 20240220153334.2624873-2-alexander.stein@ew.tq-group.com (mailing list archive)
State New, archived
Headers show
Series [1/2] arm64: dts: imx8mq: tqma8mq-mba8mx: Add missing USB vbus supply | expand

Commit Message

Alexander Stein Feb. 20, 2024, 3:33 p.m. UTC 
VBUS 5V is statically provided to both USB host and on-bard USB-hub.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 arch/arm64/boot/dts/freescale/imx8mn-tqma8mqnl-mba8mx.dts | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Alexander Stein Feb. 21, 2024, 8:38 a.m. UTC | #1 
Am Dienstag, 20. Februar 2024, 16:33:34 CET schrieb Alexander Stein:
> VBUS 5V is statically provided to both USB host and on-bard USB-hub.
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8mn-tqma8mqnl-mba8mx.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-tqma8mqnl-mba8mx.dts b/arch/arm64/boot/dts/freescale/imx8mn-tqma8mqnl-mba8mx.dts
> index c07d59147ab55..5b682dd907578 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn-tqma8mqnl-mba8mx.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mn-tqma8mqnl-mba8mx.dts
> @@ -86,6 +86,10 @@ &usbotg1 {
>  	status = "okay";
>  };
>  
> +&usbphynop1 {
> +	vbus-supply = <&reg_hub_vbus>;
> +};
> +

Okay, this is kinda confusing. While checking imx8mm platform as well, it turns out
vbus-supply in drivers/usb/phy/phy-generic.c is not used at all, because i.MX
chipidea host doesn't use PHY vbus control at all.

Please drop this, thanks.
Alexander

>  &iomuxc {
>  	pinctrl_ecspi1: ecspi1grp {
>  		fsl,pins = <MX8MN_IOMUXC_ECSPI1_SCLK_ECSPI1_SCLK	0x00000146>,
>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx8mn-tqma8mqnl-mba8mx.dts b/arch/arm64/boot/dts/freescale/imx8mn-tqma8mqnl-mba8mx.dts
index c07d59147ab55..5b682dd907578 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn-tqma8mqnl-mba8mx.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mn-tqma8mqnl-mba8mx.dts
@@ -86,6 +86,10 @@  &usbotg1 {
 	status = "okay";
 };
 
+&usbphynop1 {
+	vbus-supply = <&reg_hub_vbus>;
+};
+
 &iomuxc {
 	pinctrl_ecspi1: ecspi1grp {
 		fsl,pins = <MX8MN_IOMUXC_ECSPI1_SCLK_ECSPI1_SCLK	0x00000146>,