From patchwork Thu Feb 22 18:12:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Serge Semin X-Patchwork-Id: 13567947 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7432AC48BF8 for ; Thu, 22 Feb 2024 18:40:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2SuKPTi6W2O8u+CCLrtaBK1XlWOk9pKId1dUghkWF4g=; b=x22IZ769MZmfs5 fZVog8Vskf3cX3726wFcLNTx1nxtkTOqDNfSliLE1wMTZ/xSB/z/I07l8Mwju5KBiCCpDboVcQhD5 YRqh6aB/y0X6rQN8qrFAWE/HuL5j1FMZMHQS+kkRsU5bT/4tWRdpHkBlvxFljSxK3x4tUb79cxXOx gfkhZ1OIApGbKVmTPGyWC5S2ZZdf1Kz0/RFfi/Rlm5vP5HuDKxN0Df5tcvXGCRfBSEHHUD3Ws05EN kEZscXhop1hXSNywAx/ci6mRVTnMyqULqtgu6EDeb9LIuaFGUTDQjGR3SxkDQ91QEEqFXv4f7q/fO ntaMaciBB6cybQPDAb4w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdDzX-000000069QF-3adz; Thu, 22 Feb 2024 18:40:19 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdDzE-0000000699O-218x for linux-arm-kernel@bombadil.infradead.org; Thu, 22 Feb 2024 18:40:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=Oj2Zk+yOX3iTlO1YnU+dJlP9WROVQ6dXGrz5dId9J7c=; b=nGeoCGBC4W9KBl8TkpfmFjewoS Z46MbEltUG5ksNQctob/0JV0oGVzU8/rFtZv/KYyuMOE0qBBxz1fguIArodP9FAtjyfEsvG+eGYWm +VGQiyO7ux/ogAg8F4Rb69n/j6q1orBMLVJGgVO7/XO37PcjwIYM0PojbswoFy7MwPeqoYe29TLKU BmrcyjaWYBplrfsaR9ViI7PJMoTZ/1kDAY2daRbeyIz6X4uihZiIxiOCKfl0pD0m+kcPrPrYZo93w qre7qidmnINNJf7668AJjbWalVfy1MuN9yxfIOjrv4bFRTLR2dT3ZAdeZknskrtHvjEM78PoTJGGn MwZd/RgQ==; Received: from mail-lj1-x230.google.com ([2a00:1450:4864:20::230]) by casper.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdDc5-00000004IxG-36AV for linux-arm-kernel@lists.infradead.org; Thu, 22 Feb 2024 18:16:08 +0000 Received: by mail-lj1-x230.google.com with SMTP id 38308e7fff4ca-2d22b8801b9so1475031fa.0 for ; Thu, 22 Feb 2024 10:16:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708625703; x=1709230503; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Oj2Zk+yOX3iTlO1YnU+dJlP9WROVQ6dXGrz5dId9J7c=; b=BZDDMYvNcEW22HKLmX52t3Z50+Lzfjx/Z+Jwt60ny0jOUmy+5K3fu4eUs5fHvuzE1c Rjudq4gncMt0FE7gMK9NfNpfGIUlzUvlgYbWC5WHYG2vUbIw/+y90PIWI9+iw8vZU1M9 rUWZlq524UNUGS5mmyGPqzygvNREr6geO7t7DQr0VmhwYzF7q+XeRtfnF78/hOux6oOT xAWFlD162OnzLKVZZXUELyfXg70zwd/kV+citFJVPaLif4uVp1p0F69lgSprn07HdsbS 0kYom3CWIrMvCc+rCgkOxNA4pOydjvPJPIBDKPypr9G8qqnhuX7ChgGESNSrnZv6XTAa il1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708625703; x=1709230503; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Oj2Zk+yOX3iTlO1YnU+dJlP9WROVQ6dXGrz5dId9J7c=; b=AR5LQj0EF3yaj0SprI1Ypv1avcOdI9GULQRXDtz6Sb5+RQ+2aLqYMQlNhA25R6XtQl drJmdZGezKyWwHV/NC0ZrO5MnCm8NCsW78vdLBDAOsoEGo2jE++6K7THc6/mKZ1WKygr 3ErdDkFm2CLsREzAZfSlvg0+12LAzdo+dKjjuOb9axpclE3Gh+ZWRkNQCMU/AjQcnIUt k+DcFjzAEAEYX5Ll+O4tp2IikSOzR/Zyl6H5Cft42P5/VcCmhyWO7xXaRUelo58GxyhW qLcm0oxZHReUPwSIpSDhWyK6JZ3O7UktaXDfOQrUMV67JNhoQi9W3tcBYm6HvUkpuYSn P+KA== X-Forwarded-Encrypted: i=1; AJvYcCWR1ek1FLZOe8OoCwJ14JZxuL/nTRvOi6JHRRmU9/A4ELRQhIfbuM49khrzirFUB8mAH1fZeTY2DLSoOwe/am+DXwUI9hCpfeYcj8bcUhrPq0j2/aA= X-Gm-Message-State: AOJu0Ywq0utbco/cnjXio4B0A2DpeS7NoNMRVoOoy805VFHyGtD1udzF pHjUFW2tn20MG9l7AJ9nMm2GoBMfeZ9PEEO8N3aFFX3J+oEuikEnmDNBLoW4rh8= X-Google-Smtp-Source: AGHT+IFOFkHys1bH4WkLHPGQ3V9fUh1P0YVQPkq70kk/yd9g6H865FEq3BXbnYj7ckxtOrhkoU1gaQ== X-Received: by 2002:a05:6512:15a7:b0:512:a6cd:b37c with SMTP id bp39-20020a05651215a700b00512a6cdb37cmr11450521lfb.47.1708625681964; Thu, 22 Feb 2024 10:14:41 -0800 (PST) Received: from localhost ([178.176.56.174]) by smtp.gmail.com with ESMTPSA id x7-20020ac25dc7000000b00512dbd9cf32sm348778lfq.54.2024.02.22.10.14.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 10:14:41 -0800 (PST) From: Serge Semin To: Michal Simek , Alexander Stein , Borislav Petkov , Tony Luck , James Morse , Mauro Carvalho Chehab , Robert Richter Cc: Serge Semin , Punnaiah Choudary Kalluri , Dinh Nguyen , Arnd Bergmann , Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 12/20] EDAC/synopsys: Drop redundant info from the error messages Date: Thu, 22 Feb 2024 21:12:57 +0300 Message-ID: <20240222181324.28242-13-fancer.lancer@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240222181324.28242-1-fancer.lancer@gmail.com> References: <20240222181324.28242-1-fancer.lancer@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240222_181605_845817_F874EFB2 X-CRM114-Status: GOOD ( 12.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Currently the custom error messages are needlessly long so the logged text gets to be printed in several lines in console. There is some duplicated/redundant information which can be freely removed from it: drop the message prefix "DDR ECC error type:%s" since the resultant text printed to the log by the edac_mc_printk() method will contain the error type and the memory controller id referring to the device detected the error anyway; with no harm to readability shorten out the phrase "Bit Position" to being just "Bit". Signed-off-by: Serge Semin --- drivers/edac/synopsys_edac.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/edac/synopsys_edac.c b/drivers/edac/synopsys_edac.c index b0ff831287f5..dfe1abe7c86c 100644 --- a/drivers/edac/synopsys_edac.c +++ b/drivers/edac/synopsys_edac.c @@ -478,13 +478,13 @@ static void handle_error(struct mem_ctl_info *mci, struct synps_ecc_status *p) pinf = &p->ceinfo; if (priv->p_data->quirks & DDR_ECC_INTR_SUPPORT) { snprintf(priv->message, SYNPS_EDAC_MSG_SIZE, - "DDR ECC error type:%s Row %d Col %d Bank %d Bank Group %d Bit Position: %d Data: 0x%08x", - "CE", pinf->row, pinf->col, pinf->bank, - pinf->bankgrp, pinf->bitpos, pinf->data); + "Row %d Col %d Bank %d Bank Group %d Bit %d Data 0x%08x", + pinf->row, pinf->col, pinf->bank, pinf->bankgrp, + pinf->bitpos, pinf->data); } else { snprintf(priv->message, SYNPS_EDAC_MSG_SIZE, - "DDR ECC error type:%s Row %d Bank %d Col %d Bit Position: %d Data: 0x%08x", - "CE", pinf->row, pinf->bank, pinf->col, + "Row %d Bank %d Col %d Bit: %d Data: 0x%08x", + pinf->row, pinf->bank, pinf->col, pinf->bitpos, pinf->data); } @@ -497,13 +497,12 @@ static void handle_error(struct mem_ctl_info *mci, struct synps_ecc_status *p) pinf = &p->ueinfo; if (priv->p_data->quirks & DDR_ECC_INTR_SUPPORT) { snprintf(priv->message, SYNPS_EDAC_MSG_SIZE, - "DDR ECC error type :%s Row %d Col %d Bank %d Bank Group %d", - "UE", pinf->row, pinf->col, pinf->bank, - pinf->bankgrp); + "Row %d Col %d Bank %d Bank Group %d", + pinf->row, pinf->col, pinf->bank, pinf->bankgrp); } else { snprintf(priv->message, SYNPS_EDAC_MSG_SIZE, - "DDR ECC error type :%s Row %d Bank %d Col %d ", - "UE", pinf->row, pinf->bank, pinf->col); + "Row %d Bank %d Col %d", + pinf->row, pinf->bank, pinf->col); } edac_mc_handle_error(HW_EVENT_ERR_UNCORRECTED, mci,