From patchwork Thu Feb 22 18:12:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Serge Semin X-Patchwork-Id: 13567987 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A8D61C5478C for ; Thu, 22 Feb 2024 19:16:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8bsj+Oi4138CtPzqLeUjAh8gvGekjgS7D7udGW9qBPU=; b=247H6ohbG3COR0 W1ROJg4kur5caUvNwwurTe2Iq9beVlLNS+gXn45niTF7Fb4GltBUUMBBxodyCk1bT378KeNjcjao8 Ml8jG0JsweVQxovjmFwEaEh7AeOm+N/E2hkLpEJWs/UDHVO7OgJXP5joMoKIj4m2lUPwv2jjA9e3t rBSPaQ46WO0Ctl2Wihu6XNB0Ykl2JvYceL9bmgbT5ZtKmEZ68OARCp1nIbZFfJ7fMutiL3V8TH+da psdqnb204t7Ja7d7nm7B1o6w+m0QhxZ9ucbGJzAw65iDrFn3TlI+HjHB8zO4sjqBwxx+uGZn05nJw 9weHjkxmZ4FOhkc2lYsg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdEYM-00000006I2N-3p3K; Thu, 22 Feb 2024 19:16:18 +0000 Received: from mail-lj1-x234.google.com ([2a00:1450:4864:20::234]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdDaY-00000005x3k-0Vi3 for linux-arm-kernel@lists.infradead.org; Thu, 22 Feb 2024 18:14:41 +0000 Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-2d2509c66daso815261fa.3 for ; Thu, 22 Feb 2024 10:14:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708625666; x=1709230466; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=s0PkFM1zHHNODsMfc/INZSKS8pmA7KHQoUde1CaCg/A=; b=ajq+9F8/EOSncgMkaIavHG15QXrS7aApDuCB69P4qQL3D9DHA3shLYds9ah3u4AoQO ADYr2yfYdpE879fWz2Cd2TQifT9xbEL1meW9sHAHQxy00+CCtYIzYfNreN+mN6fgJhW4 ppuBCT0xpXze3nvrunXx7nyIyHa60kLsGqVeQTv8svjdYddTKhCBqwMS+JVUGjZ5VbD3 40bLhi3b43R9mXoYZMwZD6p2IT/v1e74h8sfuu+CUN1dD8amnawNCmRJBahMNGTBZ9Lr FJIE6OfePRzAZFDOqi+BKom7/tEz2Uxsgnu1X7AXatDfQ+IrPVNHASWbC0kgUEX6DJmJ Z06Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708625666; x=1709230466; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=s0PkFM1zHHNODsMfc/INZSKS8pmA7KHQoUde1CaCg/A=; b=FcnsEKanwgapXBhGn7iwaeMe5wKHHWLFTDBJ55M8kjCfk+9sdqHlxAZpd8SBXQ0zr6 9LJHzi6olrvER3bYpwTAH4O1WAsJNMXquLQ5JOhtKNatoYZCnLMwxuMFleLEGIMY2vhA acUEmquXhnPWGOxnLkyWtnbz+65Qygp+CC3Y6KtiCLQXNQszlHyEiB8q9XLQmaKcAQO4 XEM9/J3dThYhLJgumR1GqrBQ5ScLHiuGDHz5e26Imf/wuvTxS2fDsuCSuMTWqwZ5n169 qf+odZVoxGI0Xpf+a/mjw7V9muAzFIVoAvqGBiN+H/fpPNXMQ56MR42EZp8vs5RQhL6D cQGQ== X-Forwarded-Encrypted: i=1; AJvYcCVshvvbVtkgUC32ggZToWMgGl5eqDagGbg2TvAR7lKlaFZoEIXVWMHVPV4gXQmeTFPnnydrnSd4hCeHm4vwR2TApsXrOQijiIBaxINLYQAqRNIkEkw= X-Gm-Message-State: AOJu0YxmEGjPi/EbrBTMlrPof8QmQ2pNhZrIvWhpKp6pkGb9z/SbyHbu I5e5cDV+KePuCkPljSle+5JU1fgFH5QJc+nKnqiv1GRoEKxOFpMm X-Google-Smtp-Source: AGHT+IHahT0a07aFA2OedK8mTZdnaBkfS3CSGBF+9vHiELIFN8mrf5vJu/bEAFsJ399T8e/mgXYx1Q== X-Received: by 2002:ac2:593b:0:b0:512:b366:6c42 with SMTP id v27-20020ac2593b000000b00512b3666c42mr8072382lfi.32.1708625666512; Thu, 22 Feb 2024 10:14:26 -0800 (PST) Received: from localhost ([178.176.56.174]) by smtp.gmail.com with ESMTPSA id q2-20020ac25a02000000b00512daaef13bsm398124lfn.102.2024.02.22.10.14.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 10:14:26 -0800 (PST) From: Serge Semin To: Michal Simek , Alexander Stein , Borislav Petkov , Tony Luck , James Morse , Mauro Carvalho Chehab , Robert Richter , Punnaiah Choudary Kalluri Cc: Serge Semin , Dinh Nguyen , Arnd Bergmann , Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Borislav Petkov Subject: [PATCH v5 03/20] EDAC/synopsys: Fix mci->scrub_cap field setting Date: Thu, 22 Feb 2024 21:12:48 +0300 Message-ID: <20240222181324.28242-4-fancer.lancer@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240222181324.28242-1-fancer.lancer@gmail.com> References: <20240222181324.28242-1-fancer.lancer@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240222_101432_563800_16AB2AFC X-CRM114-Status: GOOD ( 15.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The mem_ctl_info.scrub_cap field is supposed to be set with the ECC scrub-related flags. Instead the driver erroneously initializes it with the SCRUB_HW_SRC flag ID. It's definitely wrong, though it hasn't caused any problem so far since the structure field isn't used by the EDAC core. Fix it anyway by using the SCRUB_FLAG_HW_SRC macro to initialize the field. Fixes: ae9b56e3996d ("EDAC, synps: Add EDAC support for zynq ddr ecc controller") Signed-off-by: Serge Semin --- drivers/edac/synopsys_edac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/edac/synopsys_edac.c b/drivers/edac/synopsys_edac.c index 455d2fcfd8c1..7c57c43b4d31 100644 --- a/drivers/edac/synopsys_edac.c +++ b/drivers/edac/synopsys_edac.c @@ -855,7 +855,7 @@ static void mc_init(struct mem_ctl_info *mci, struct platform_device *pdev) /* Initialize controller capabilities and configuration */ mci->mtype_cap = MEM_FLAG_DDR3 | MEM_FLAG_DDR2; mci->edac_ctl_cap = EDAC_FLAG_NONE | EDAC_FLAG_SECDED; - mci->scrub_cap = SCRUB_HW_SRC; + mci->scrub_cap = SCRUB_FLAG_HW_SRC; mci->scrub_mode = SCRUB_NONE; mci->edac_cap = EDAC_FLAG_SECDED;