From patchwork Thu Feb 22 18:12:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Serge Semin X-Patchwork-Id: 13567904 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E0F1C5478C for ; Thu, 22 Feb 2024 18:22:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4BBH61gm4Gj5i5Y+Z7wp4mD3w5EKF+NksH8JVjJnSxo=; b=eqkjLm9SIBnLj4 iRcO+/1w15IGoxq1LCL2N8k0mOQ0QIN7jqaDuuOebFXvgbgyKQ+VWYLu+3tmyOUywWTgbGVF+2kx0 pINHXFGg5+I6zS6YZs+IIS9WU3kcVlwfmkWwrlJyDSJSebjfSYcQF5S8UAH8ARUaRBglxzFrITs4/ 6dwcf5mfo0P+/SOo4z2Q8TzIvcqQgql499mqxBr3G2YFDEUdQC8ODa99l9pNj0qu+h3K0pHeYiWTW fpuFzrpZ62MeRc2f62Ptf3P7pTbdPEG5ydCH3Lo/HM1sUASAPKWRX9uR5YjRzvQYeKdrEBrZpzE+k jSpGUGHqleAbpRyx2A/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdDi2-000000060mr-2STe; Thu, 22 Feb 2024 18:22:14 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdDbj-00000005xeB-1Cwr for linux-arm-kernel@bombadil.infradead.org; Thu, 22 Feb 2024 18:16:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=75JkZwTsL4Dcbz0CcBW0plC9VrJj9UCwkyPRaMtpo4c=; b=hRGzzth/4yT0pFjrdF1S2aDPO3 X64qhYHPZMaUWNozxdIf5hQmh7gVZJJFT1sqvblJyQEylXomSGm3hBDpkMfwcL1k63G0DFGZ0U1+v avg1k16Pemye5+x4POoZZFG5ta85BcSpCvsksq/0mJAwfWdrrP4Hfimo4L0ed582v/Ml/riJdIP2X 0DTLkkYUKz3KNClfmxlrY8HvxAz5v72Z9FRyWaAikpllMZrM9jarOIiUqry4cFuFhLKWlRM0zeXkH xuGS2CjME+8vdRWLOwABTW/LRRbYK40XOSWhOo8CYycSJwwWcYlp2+Bag+9Ft3y1Vf2fQ+NqUmlj5 Zrs2OFCg==; Received: from mail-lf1-x12a.google.com ([2a00:1450:4864:20::12a]) by casper.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdDbg-00000004Il2-1ZNn for linux-arm-kernel@lists.infradead.org; Thu, 22 Feb 2024 18:15:42 +0000 Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-512b29f82d1so105216e87.1 for ; Thu, 22 Feb 2024 10:15:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708625675; x=1709230475; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=75JkZwTsL4Dcbz0CcBW0plC9VrJj9UCwkyPRaMtpo4c=; b=Grr6G+yX+jhyuZJqrz8NNLxupSaVyvWL05tBYg7jkuE3Y04Ma46Vis34jkf55Bj3cl d/wLwmEUKn8XzTAnRqKWY/UtJTVIzPWOJvC1MSORxFkk4fxGvMRviUvKz90lclx2oSqf x9rYn2GCklZ2MkzpccLMpCA4oe/2hIPV98Eqs7IpMx7vNyNaPq6sROsUNc86WTszysMr 5pmloNXA5dnkphtMDIFCkirxwX7Cf61kMV3csg4BXntFfdbYK1ycicPQnOZqr1KZHZUv KAIxuaafXBiO/sams0sTsBzADTPotgIFTw0983J+uitpwjMxseGm4ArOwDg7f0qB6Qs3 MZdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708625675; x=1709230475; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=75JkZwTsL4Dcbz0CcBW0plC9VrJj9UCwkyPRaMtpo4c=; b=gjCTAdX0BNSetN2uAlYwPiqPTQvKzF0amVrICSvqFglY2hEx6fcBLPotCPGy03vEYG axn9SvH2JvFal4MGwvZALUTUDaWdDSOKpJ6GeQtlnOfdYLJSkhqBmmNXQY+p0C0t9mzB tFpWJyD6IM3sMHutnM7P6rwUL7HsnCni8DHrftuR0dZrHXsUdtnQSZGYAolhByGIzRhW KVlrA5yhWjUFN4xEGupMrK8z9PF3Wc72P57bMs59TP27AUi1sewTGpZlqdlM6mbZB640 KZWkvkG/1o17hAuZ1WuwjBM19GhqyIjXaD7YGo0U38ZuEervXsUPKUGQO/6usrwdX7P3 o1wg== X-Forwarded-Encrypted: i=1; AJvYcCW/7iSkZN8noJQjbWc0ivXUBo9MRo2Gxiq9OO4ZpkZbxJUejyFxePAXnnR4RkaWh/TRutQR58ghDZj+1bzOdPVle0TdtS18AIwu/gblREcLdeXgduQ= X-Gm-Message-State: AOJu0YwbwAm6+8lgB+ONx4y67q6t2F3EpTcbnReqTdUMrp2fhZsDwQto c9Hg0mF9YMj/x1tOG7MnSNWd5SYqSkt9hHJvPZ1AzRAJIv5B0Em8 X-Google-Smtp-Source: AGHT+IHL5/hu6VK7d3WPOWjLHTAPQ0FqlAB/KtPSK88tLkHZmTgfAUxJRAjJ8Q5xs1zpJYKDO1R7kg== X-Received: by 2002:a19:5e42:0:b0:512:aa57:f38b with SMTP id z2-20020a195e42000000b00512aa57f38bmr10450667lfi.53.1708625675351; Thu, 22 Feb 2024 10:14:35 -0800 (PST) Received: from localhost ([178.176.56.174]) by smtp.gmail.com with ESMTPSA id x18-20020a056512047200b00512a62a176bsm2030675lfd.26.2024.02.22.10.14.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 10:14:35 -0800 (PST) From: Serge Semin To: Michal Simek , Alexander Stein , Borislav Petkov , Tony Luck , James Morse , Mauro Carvalho Chehab , Robert Richter Cc: Serge Semin , Punnaiah Choudary Kalluri , Dinh Nguyen , Arnd Bergmann , Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 08/20] EDAC/synopsys: Drop internal CE and UE counters Date: Thu, 22 Feb 2024 21:12:53 +0300 Message-ID: <20240222181324.28242-9-fancer.lancer@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240222181324.28242-1-fancer.lancer@gmail.com> References: <20240222181324.28242-1-fancer.lancer@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240222_181540_429322_4E19013F X-CRM114-Status: GOOD ( 10.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org First of all these counters aren't exposed anyhow from the driver. Secondly the EDAC core already tracks the total amount of the correctable and uncorrectable errors (see mem_ctl_info.{ce_mc,ue_mc} fields usage). Drop the useless internal counters then for good. Signed-off-by: Serge Semin --- Changelog v4: - Drop redundant empty line. - Drop private counters access from the check_errors() method too. --- drivers/edac/synopsys_edac.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/drivers/edac/synopsys_edac.c b/drivers/edac/synopsys_edac.c index 6976ef84e952..5099246db90e 100644 --- a/drivers/edac/synopsys_edac.c +++ b/drivers/edac/synopsys_edac.c @@ -304,8 +304,6 @@ struct synps_ecc_status { * @message: Buffer for framing the event specific info. * @stat: ECC status information. * @p_data: Platform data. - * @ce_cnt: Correctable Error count. - * @ue_cnt: Uncorrectable Error count. * @poison_addr: Data poison address. * @row_shift: Bit shifts for row bit. * @col_shift: Bit shifts for column bit. @@ -319,8 +317,6 @@ struct synps_edac_priv { char message[SYNPS_EDAC_MSG_SIZE]; struct synps_ecc_status stat; const struct synps_platform_data *p_data; - u32 ce_cnt; - u32 ue_cnt; #ifdef CONFIG_EDAC_DEBUG ulong poison_addr; u32 row_shift[18]; @@ -592,13 +588,8 @@ static irqreturn_t intr_handler(int irq, void *dev_id) if (status) return IRQ_NONE; - priv->ce_cnt += priv->stat.ce_cnt; - priv->ue_cnt += priv->stat.ue_cnt; handle_error(mci, &priv->stat); - edac_dbg(3, "Total error count CE %d UE %d\n", - priv->ce_cnt, priv->ue_cnt); - if (priv->p_data->quirks & SYNPS_ZYNQMP_IRQ_REGS) writel(regval, priv->baseaddr + DDR_QOS_IRQ_STAT_OFST); @@ -624,12 +615,7 @@ static void check_errors(struct mem_ctl_info *mci) if (status) return; - priv->ce_cnt += priv->stat.ce_cnt; - priv->ue_cnt += priv->stat.ue_cnt; handle_error(mci, &priv->stat); - - edac_dbg(3, "Total error count CE %d UE %d\n", - priv->ce_cnt, priv->ue_cnt); } /**