| Message ID | 20240223015219.3618111-2-megi@xff.cz (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add support for jack detection to codec present in A64 SoC | expand |
On 23/02/2024 02:52, Ondřej Jirman wrote: > From: Ondrej Jirman <megi@xff.cz> > > The codec driver needs to know what jack connector is connected to > on the board. Add proprty to describe the type of connector. > > Signed-off-by: Ondrej Jirman <megi@xff.cz> > --- Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline), work on fork of kernel (don't, instead use mainline) or you ignore some maintainers (really don't). Just use b4 and everything should be fine, although remember about `b4 prep --auto-to-cc` if you added new patches to the patchset. You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time, thus I will skip this patch entirely till you follow the process allowing the patch to be tested. Please kindly resend and include all necessary To/Cc entries. Best regards, Krzysztof
On Sat, Feb 24, 2024 at 11:31:07AM +0100, Krzysztof Kozlowski wrote: > On 23/02/2024 02:52, Ondřej Jirman wrote: > > From: Ondrej Jirman <megi@xff.cz> > > > > The codec driver needs to know what jack connector is connected to > > on the board. Add proprty to describe the type of connector. > > > > Signed-off-by: Ondrej Jirman <megi@xff.cz> > > --- > > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC. It might happen, that command when run on an older > kernel, gives you outdated entries. Therefore please be sure you base > your patches on recent Linux kernel. > > Tools like b4 or scripts/get_maintainer.pl provide you proper list of > people, so fix your workflow. Tools might also fail if you work on some > ancient tree (don't, instead use mainline), work on fork of kernel > (don't, instead use mainline) or you ignore some maintainers (really > don't). Just use b4 and everything should be fine, although remember > about `b4 prep --auto-to-cc` if you added new patches to the patchset. > > You missed at least devicetree list (maybe more), so this won't be > tested by automated tooling. Performing review on untested code might be > a waste of time, thus I will skip this patch entirely till you follow > the process allowing the patch to be tested. > > Please kindly resend and include all necessary To/Cc entries. Yeah, I did run the script on v3 where this patch was not present, and forgot to re-run it on the new version. I'll resend. In any case I did run DT tests on the patch. kind regards, o. > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml b/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml index 63eadc4200ac..399fc00ad3f4 100644 --- a/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml +++ b/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml @@ -44,6 +44,15 @@ properties: - const: bus - const: mod + jack-type: + enum: + - headset + - headphone + description: + Type of jack connector connected to the codec. This can be either + a 3-pin headphone connector or 4-pin headset connector. If not + specified, jack detection is disabled. + required: - "#sound-dai-cells" - compatible