From patchwork Mon Feb 26 17:32:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 13572570 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5FE69C5478C for ; Mon, 26 Feb 2024 17:33:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YEXtO9nTlmKAeAccUiG/6PP0NKI+7T63CKILZTv+7Lg=; b=HGN/014AQC38Mg RGb7WeNs9bpxP0QjkO5Qhls2gYamWz3XX8uNCDlZk9+3iGLDrqSoRQAl9kZez78PlG3wUCn4W38wq AusV/RQhz2I2Fq7aesmHZyS2AgMr9CgBv8iiXHDqgqcoUkEY0Lj72z91XuXR7qUH+ZvlJitHb/ani IEZUAVkGw5sVOF9NcY5BoriSye5i11ze3khCL07a93OG8THd+rAk7BwigiX26sgth1QA9JVYeP2lc iCnE5zgmVCCL9OVmt9V/9XzNUT3bwQHHfXzcP7BdubaNofRyHZgy+x8P4NMLEhT9TprQIZIREVtdZ uzUaBoSWumRrDy1Gmjpw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1reer4-00000001zwI-2zTi; Mon, 26 Feb 2024 17:33:30 +0000 Received: from mail-qk1-x730.google.com ([2607:f8b0:4864:20::730]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1reeqT-00000001zZ9-21w4 for linux-arm-kernel@lists.infradead.org; Mon, 26 Feb 2024 17:32:56 +0000 Received: by mail-qk1-x730.google.com with SMTP id af79cd13be357-787bc854a77so195666085a.3 for ; Mon, 26 Feb 2024 09:32:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1708968770; x=1709573570; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ZotKd2o47/oKAtdV1I26QivtjRepugTGHOJDDp/ZM4g=; b=XHvLVG5KcdLR++bTT70XlA07bxTFT7gb0mxQ1Vb+cZ5ql8IxJ/zGEgPdGWCGkP236T 7hhPrErA3TnK2B1r8K16clLIdDaBXdjldN27E/hk2Zl4B2kCJQUAjgW+jY2PPT/G08Vl HzIxD5lsn09/0dB6gD2xRp2TM1avVqsF9HT/E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708968770; x=1709573570; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZotKd2o47/oKAtdV1I26QivtjRepugTGHOJDDp/ZM4g=; b=K1bCVk1hVsWqmJKD1rjrsuqkjY2M5/eTlkregpAZ56o+voCMHFWXJIfnLX2reqaQB0 Rz1VeKmXbXlR5Uw1edcyBkKyC9CmKoTxIKvoUgQNiAtlzBMARgGI6+7+yoPo/nO8NBA3 cFNv+zWbzcaACB6A76+HMbVXnxwKFDo4bEq0mVxgEmno3zlpHN+fyeX+hD1mrHUjiFk/ fdHfQKg/F19ByAxX9q6TuBKEM+cqXOJuwHfiPqI5N7+My9zGRg7tq4FtO3AtEFrrCVad vtZ7nBdsjoLVtat1dtPXjEQm4qPJx6PwUlGw7rVvYX1eavZHy0F2F/cKcAz1/gfPLxqt qW3Q== X-Forwarded-Encrypted: i=1; AJvYcCXpJfH48I8+AUyHPaDbq4Z2G8H19vTywQblE4UNF3I9w5VbayXAVmaHKGU3Gku70OPNRIsP87wHOm/3y3eEc5C+Nmj4TDE6S2WscwLqpNs5oz4WdMA= X-Gm-Message-State: AOJu0Yz0Q3oXlHK2VqR6aKTZLc0BUTspK7Fg+wH7QrrufnZOwEqk+uas D4JYEVC4IaStph9xcuh2ekkcsnF6s8mLVBDlFuOsLDUbVkJZIhGr0JLIFF4bhQ== X-Google-Smtp-Source: AGHT+IH3rAwgd0NXJq8G/TBWJ93nsJy2+AmuJ1+7I538QjgTdtVQQDhSqF/spxCAW7zvWaoaCpSjOA== X-Received: by 2002:a05:620a:9d7:b0:787:9a1c:fb32 with SMTP id y23-20020a05620a09d700b007879a1cfb32mr8021996qky.2.1708968769789; Mon, 26 Feb 2024 09:32:49 -0800 (PST) Received: from denia.c.googlers.com (115.25.199.35.bc.googleusercontent.com. [35.199.25.115]) by smtp.gmail.com with ESMTPSA id b11-20020a05620a04eb00b0078725d0345dsm2672669qkh.2.2024.02.26.09.32.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 09:32:49 -0800 (PST) From: Ricardo Ribalda Date: Mon, 26 Feb 2024 17:32:44 +0000 Subject: [PATCH v2 1/3] media: pci: sta2x11: Fix Wcast-function-type-strict warnings MIME-Version: 1.0 Message-Id: <20240226-fix-clang-warnings-v2-1-fa1bc931d17e@chromium.org> References: <20240226-fix-clang-warnings-v2-0-fa1bc931d17e@chromium.org> In-Reply-To: <20240226-fix-clang-warnings-v2-0-fa1bc931d17e@chromium.org> To: Mauro Carvalho Chehab , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Mike Isely , Tiffany Lin , Andrew-CT Chen , Yunfei Dong , Matthias Brugger , AngeloGioacchino Del Regno , Bjorn Andersson , Mathieu Poirier Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-remoteproc@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240226_093253_577620_2FB88DFD X-CRM114-Status: GOOD ( 13.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Building with LLVM=1 throws the following warning: drivers/media/pci/sta2x11/sta2x11_vip.c:1057:6: warning: cast from 'irqreturn_t (*)(int, struct sta2x11_vip *)' (aka 'enum irqreturn (*)(int, struct sta2x11_vip *)') to 'irq_handler_t' (aka 'enum irqreturn (*)(int, void *)') converts to incompatible function type [-Wcast-function-type-strict] Reviewed-by: Nathan Chancellor Signed-off-by: Ricardo Ribalda --- drivers/media/pci/sta2x11/sta2x11_vip.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/pci/sta2x11/sta2x11_vip.c b/drivers/media/pci/sta2x11/sta2x11_vip.c index e4cf9d63e926d..a6456673be3f6 100644 --- a/drivers/media/pci/sta2x11/sta2x11_vip.c +++ b/drivers/media/pci/sta2x11/sta2x11_vip.c @@ -757,7 +757,7 @@ static const struct video_device video_dev_template = { /** * vip_irq - interrupt routine * @irq: Number of interrupt ( not used, correct number is assumed ) - * @vip: local data structure containing all information + * @data: local data structure containing all information * * check for both frame interrupts set ( top and bottom ). * check FIFO overflow, but limit number of log messages after open. @@ -767,8 +767,9 @@ static const struct video_device video_dev_template = { * * IRQ_HANDLED, interrupt done. */ -static irqreturn_t vip_irq(int irq, struct sta2x11_vip *vip) +static irqreturn_t vip_irq(int irq, void *data) { + struct sta2x11_vip *vip = data; unsigned int status; status = reg_read(vip, DVP_ITS);