From patchwork Fri Mar 8 07:35:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tony Lindgren X-Patchwork-Id: 13586520 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6042AC54E4A for ; Fri, 8 Mar 2024 07:35:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=EN2hpH6ri57hfs73kcieFiQbgrye6Vr0mX52xT+VB3k=; b=zHFLi3dCpmGQrK tZnmd/dR2LCqwUnrJNJhPjPsMTzWDKdNR4znt2tOmBa/zHg8afO8L5DMi186jSBs1BXSbo41o2rr0 vzqnQDRSOe84vUeJ0ia0fjr/o5i36gTJmzNury0sUT2tBY734R9u4mySV9AIED82bETqIT59cBLTk FgYIC5f5wV5NwKfxKaqgHMgrxaKjb29B97WJ3jULzBXnd5gFDQ5iqsqTvQn2u5BZyMKzViZCxWL/9 Sb6L/ORbtgoNM0nxfwBYdbebjfHXgWJy3N/9LBJQictzsofyFMGPAglSg0usXhMTekuidVv4gR+x9 7nx2G0FwzhoV2wWKVFuA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1riUlJ-000000089zJ-045V; Fri, 08 Mar 2024 07:35:25 +0000 Received: from mail5.25mail.st ([74.50.62.9]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1riUlG-000000089y2-19aP for linux-arm-kernel@lists.infradead.org; Fri, 08 Mar 2024 07:35:24 +0000 Received: from localhost (91-158-86-216.elisa-laajakaista.fi [91.158.86.216]) by mail5.25mail.st (Postfix) with ESMTPSA id 86CFF60540; Fri, 8 Mar 2024 07:35:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=atomide.com; s=25mailst; t=1709883317; bh=gnPbyhN/avmBLR1//LMZdeqyYtsYkkl4WXb8r3MEd/M=; h=From:To:Cc:Subject:Date:From; b=twiXQSWeNc9M2pG/a8Bo8tHZ8RXvWcsJPSO6my7Eg/75zpcsXEuy2hj2FR3wu+J+0 HJNqPEdF3DBrnb5xvGmzpbj1+guj4MlWAzldDNbhgcEbGaSMmqfY7JoV4tpnX+fgz7 cyycdkMoG8iXkTTAakRGnIE/LRamtHLVGPR0dXO+4p/F1sPYrNn5i0r376Z5+wwHCp NbN8hLcF4FXDyd5qtV7PF8IEvMGIwmiZOiE28nyr8ef79AHanuQ2nV/XDnDdimdn98 Cd7nzHqmMTf/GUBQkiUvBuefFYrPJkcvasSNAm4Qe+bik4YqzBRZr2uAcu6EPW5rkQ JSRz036+7O4dw== From: Tony Lindgren To: linux-omap@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, Alexander Sverdlin , Matthias Michel , Randy Dunlap Subject: [PATCH] ARM: OMAP2+: prm33xx.c: Fix kerneldoc warnings Date: Fri, 8 Mar 2024 09:35:00 +0200 Message-ID: <20240308073501.3699-1-tony@atomide.com> X-Mailer: git-send-email 2.43.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240307_233522_672077_688C7491 X-CRM114-Status: GOOD ( 14.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Commit 6521f6a195c7 ("ARM: AM33xx: PRM: Implement REBOOT_COLD") added a new kerneldoc warning as the function name changed: warning: expecting prototype for am33xx_prm_global_warm_sw_reset(). Prototype was for am33xx_prm_global_sw_reset() instead Turns out prm33xx.c produces a few other kerneldoc warnings so let's fix them all. Fixes: 6521f6a195c7 ("ARM: AM33xx: PRM: Implement REBOOT_COLD") Cc: Alexander Sverdlin Cc: Matthias Michel Cc: Randy Dunlap Signed-off-by: Tony Lindgren Reviewed-by: Alexander Sverdlin --- arch/arm/mach-omap2/prm33xx.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/arch/arm/mach-omap2/prm33xx.c b/arch/arm/mach-omap2/prm33xx.c --- a/arch/arm/mach-omap2/prm33xx.c +++ b/arch/arm/mach-omap2/prm33xx.c @@ -48,8 +48,7 @@ static u32 am33xx_prm_rmw_reg_bits(u32 mask, u32 bits, s16 inst, s16 idx) * @part: PRM partition, ignored for AM33xx * @inst: CM instance register offset (*_INST macro) * @rstctrl_offs: RM_RSTCTRL register address offset for this module - * - * Returns 1 if the (sub)module hardreset line is currently asserted, + * @return: 1 if the (sub)module hardreset line is currently asserted, * 0 if the (sub)module hardreset line is not currently asserted, or * -EINVAL upon parameter error. */ @@ -70,14 +69,14 @@ static int am33xx_prm_is_hardreset_asserted(u8 shift, u8 part, s16 inst, * @shift: register bit shift corresponding to the reset line to assert * @part: CM partition, ignored for AM33xx * @inst: CM instance register offset (*_INST macro) - * @rstctrl_reg: RM_RSTCTRL register address for this module + * @rstctrl_offs: RM_RSTCTRL register address offset for this module + * @return: Returns 0 upon success or -EINVAL upon an argument error * * Some IPs like dsp, ipu or iva contain processors that require an HW * reset line to be asserted / deasserted in order to fully enable the * IP. These modules may have multiple hard-reset lines that reset * different 'submodules' inside the IP block. This function will - * place the submodule into reset. Returns 0 upon success or -EINVAL - * upon an argument error. + * place the submodule into reset. */ static int am33xx_prm_assert_hardreset(u8 shift, u8 part, s16 inst, u16 rstctrl_offs) @@ -96,17 +95,18 @@ static int am33xx_prm_assert_hardreset(u8 shift, u8 part, s16 inst, * @st_shift: reset status register bit shift corresponding to the reset line * @part: PRM partition, not used for AM33xx * @inst: CM instance register offset (*_INST macro) - * @rstctrl_reg: RM_RSTCTRL register address for this module - * @rstst_reg: RM_RSTST register address for this module + * @rstctrl_offs: RM_RSTCTRL register address offset for this module + * @rstst_offs: RM_RSTST register address offset for this module + * @return: Returns 0 upon success or -EINVAL upon an argument error, + * -EEXIST if the submodule was already out of reset, or -EBUSY if the + * submodule did not exit reset promptly * * Some IPs like dsp, ipu or iva contain processors that require an HW * reset line to be asserted / deasserted in order to fully enable the * IP. These modules may have multiple hard-reset lines that reset * different 'submodules' inside the IP block. This function will * take the submodule out of reset and wait until the PRCM indicates - * that the reset has completed before returning. Returns 0 upon success or - * -EINVAL upon an argument error, -EEXIST if the submodule was already out - * of reset, or -EBUSY if the submodule did not exit reset promptly. + * that the reset has completed before returning. */ static int am33xx_prm_deassert_hardreset(u8 shift, u8 st_shift, u8 part, s16 inst, u16 rstctrl_offs, @@ -315,7 +315,7 @@ static int am33xx_check_vcvp(void) } /** - * am33xx_prm_global_warm_sw_reset - reboot the device via warm reset + * am33xx_prm_global_sw_reset - reboot the device via warm reset * * Immediately reboots the device through warm reset. */