From patchwork Fri Mar 22 08:05:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13599705 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5D90FC54E71 for ; Fri, 22 Mar 2024 07:57:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=+O0cuN/xNEbFpI+PNU26EXz9UEXuBsaWSZWFztO7IfQ=; b=JB7FTyIlNOPBeh 8a8cTcVOXewF9b0ZRS7GdBe2H1jHvxO1wdrQ54wLcjXSMaJOigkVAXXYUFGrCyq6HBhsleX2Nvwhr se+dzRf4wEriyK492FkikYcsfac2kUk5MMthefgTkH2NqujY9ohXZPeLZ8E89vMVDPk7UwAX1odLm wxvJQZJHTMcG/dxWn5MWLvQQnbqzvc1c+BNUKNNVgj3tC3Fi1ziZIBSgX/8yvOzSDXSItF3DbsUkT NB/pSYYrNbRaK1LvDsVgd3Gf90o4wvpBliif2ALqLx9xNk8FUnAV8XeBu0hLSEDamBSg15nNs4PuL VAxXl0NZ7uzYQJL/8YzA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnZmX-00000006GnH-0rx9; Fri, 22 Mar 2024 07:57:41 +0000 Received: from mail-db3eur04on0618.outbound.protection.outlook.com ([2a01:111:f400:fe0c::618] helo=EUR04-DB3-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnZmU-00000006GmL-2Sfh for linux-arm-kernel@lists.infradead.org; Fri, 22 Mar 2024 07:57:39 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DVL8Ye4p08nIG1xFS+lK0R39JV6znwKQji0DVJ380kHV4xC+i5Lsn8ZaXV+c0nzPG6vTWdBcoKg/EO1VPhRqr8nWy+e4oZcoiR8DO1zysvQFm0FoiAQZd8W9VNmohF16m63q6M6YPmGI7BFL4ZVXSwAIAhYR/jEXK5uRxy2lfx/nRvlqxByIkeL1QTrpT9H0BlzGfvpOjsbaUFqxfiBdDw8g/o8QPAGX6pp8VuQawiPymqPytA5bCI/ASC1gizEPn/oBzfTVR6WZx+aY2F59YYE/y/PcAzqBTATB1Ab2651EHNfduIAtVUxAc3itFJPm1q0WktS1baEIDKuBlOpilA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xin5drCagYKLbxMIgU7D4plJfzTAfC3fvkeyo+7txss=; b=fZh/86KtqIiDx1jOqIkhjcwBj1IWQUt2AmsUdsTSaTOJM9J8K2BcojxcArfWU7XnKCRUHLqCdKhC13ppZ0ULbnUH3/fdFK60/s0psciSjRgTe7wev83i3+SOlw3+PRtc9ZTxppqd2f1O0NOzxee+5/v/iCORMleGfS3rEsjMCTmsQCKyEa+IceAvFf2Gs+hBHt2H1n72bo8SiwdTKXQAqTRlQw+BT28y5v5aXQpVjAZC4i7k3pMQ5vZ2/tUCEcg9K2qWC9sXX4shMUgHyHs8xsTujkC2hWXPzwaNK+4TkGuC9a6HisYx4FUp5lfV7nbM0NOD3HEGTGXd2SuhgkUypw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xin5drCagYKLbxMIgU7D4plJfzTAfC3fvkeyo+7txss=; b=WSbhSn1Dw6ETisYU+GdtDqMXeoDXikfq3XOIuwRFv/7KlZRKUsueSJo5qduxi9TiHfSDRrblD6KDZ/1AUSXCmUaf5VWRanaY8MIldXSSqjVh0derE2fEaWQznG8GofEo8tI1PwZMX/Ctkf+fpnrgTZWeylBq72qvHD78ehahRoU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by AS4PR04MB9290.eurprd04.prod.outlook.com (2603:10a6:20b:4e5::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.24; Fri, 22 Mar 2024 07:57:28 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d%4]) with mapi id 15.20.7386.017; Fri, 22 Mar 2024 07:57:28 +0000 From: "Peng Fan (OSS)" To: sudeep.holla@arm.com, cristian.marussi@arm.com Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan Subject: [PATCH V2] firmware: arm_scmi: perf: print domain name in error path Date: Fri, 22 Mar 2024 16:05:31 +0800 Message-Id: <20240322080531.3365016-1-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.37.1 X-ClientProxiedBy: SG2PR02CA0016.apcprd02.prod.outlook.com (2603:1096:3:17::28) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|AS4PR04MB9290:EE_ X-MS-Office365-Filtering-Correlation-Id: 41bb6156-0563-4890-126e-08dc4a45b7fb X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0YHRRDPECya2YkWeKwF+a+x4QTQkrZ8j5Za6krvLTQZk1DbypkoqQWg4WbzOvZ45iWjypL372QSrYHmR1bdpOyaNpCLtL2QgLiL0vdtMPGMokrfDRr2YHIdm8CvPZnKt+Qqp1yqJQhfflKZfe0X7rMU/SjN+x/h/7hdO/aCC7b6A6glOGfSEC2RSFmjcjVMNYOxsKy40No24xTx0fvBhmpnCQJehVK5Qljcww/KbsXUQw/ODqaMMXyX/P/q9x00lfBxSQgjzzetcwuqLFgOS6H4BxngdNn/dnukZURyTr5jUPrl08H9Q3OqgwQ4NgsOaUo7CwK6KpbguA3IX3yWgpsxhaSX6OVPFPLjdG4rpNSBgeLIZu4all5oleeEQNTjc7pFIqhq6j3MoehCoXx8FENkmDuiee6jp8LL1s3EYC4Yzh+3fDXfJueCweqYX1RmYIuwfRSoaAgJfqXBhiiAHV9jWCiznU5tc9aKPlj/J/PrJmJ8C2MMOB+VylxrjYm54sVcXm6ll2CuTch7MXcmRbewlbu6U0BOSo2bPJnl5eToQRQKUotO+JvRA2Dlab0K3UOfySDkrXj1czawE/9mQtcvJTI2o7tyHv8tbTTIKeGCzlSbMFlQALtmCnCnw4EWnEIcQQyUlqiyVyTPkNvjUHhjbzVCMgzL5evITzAJq12hC0I/m38rwKavWhgkyiP+lEmZjJUqen5jFLPscYXdIdioOqfA9kMegHgRSKBJzASQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(366007)(52116005)(1800799015)(38350700005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: kvl7Yd4YdE46D1/zzC/uda42oRVv9fFC5tLkNG9ODcAYY9hYT2Fn7JZMakRndQOVWtyQfYNGwKLngGXLoOhyYpdlIO12202iU8zEMTx/ed2JnBg0WK0eK25gkh/vus8JNpTMovdtAdMNil1XylZARi+a6p1pvf7BUo+XU3JVrEC9r1wtGJCp5RkbAGHApjYYXd1yRGGO1U6WSKivuufrMDFVrMOAXTlX0EE0w/sLwOnZYpKg7hJJtJUU9iRwUGo3h5haYSdOl0OtKAyphR7uwmltMjgLLDTAxtxQ2kz5JG1hSyAkPvfy2ZqnQqFoHmqrL2LbfT6J5eSDwzgYq8vFBcFs8dKonwAcC2Q+1oqzzC3I7opAEqeD6NBXm0B0dhfN/LqNdM69IzTXX/TqyKCkdG1qh1nVl4+j0i7Xg5aOEa1636LGbOwJGM27cni6PtP9OhK9HolMV4aN/R1rIhOhS12EZeMazm2LDtfD7emdA/I760UJpZN0wJu3yCO6UGKXp0TdbTSsZt0z/Q80NMp0WiLf62iMnJnSs60kOTjwBQHQ5xcRzjNqKfAMH2c2LUfhGGPyJYcsQ5th3oUD6pERloYskrM7Ksm7J3jhfjA0tq6h97yJTJhfk71d0PQ/tWCMc7dRZX14W+H6NXRSBpNfH1GgeWBNar7+5efV8Nyed/SgNpPG4PCZZENvr9KR1FiNV0IFEO2AJD/pdjN1GY/rspQgeqASpne+RRk0UgEql89lzbKIWeIhGUWcOY876xFiAMu96MAx5iu8eVLT4oH9/yAOsRzoTlJY0egqrWn5/3RZOPUsSHdsjqFOByI70G8XrCMMjlVhH5LEj5+s2jyweXlre1Z926Dsc+vFo1U8PfZsraV0TEAJqgVcpU3GVaK9FOJZRtSrmZP6q8qXbOmyW+JWQH3qPlkV9ivZspAPAZ54A6tdEniXGC+vyxQrzWborXGgg29TIRzrksiWK3dIv+Eu979TDSsxluT6/hGOWBY0gcxE2vadCmXLlPrvwjxSAfMmIQZSbBAxaHYLQzVvwQQtadFwskbf5PunPIzCIS8SZIX+ODTgcD85z9TgyyK91MPyJAynXLsuMOZPv+O1yNKwPdmrg/gi7+hpUGf3a4HPgXap81XDiv77WMX/NmjSc7CQkw+bis2f+lIhYNPj3agnC0V/gpen6L1Q4nu6EjP3Q5ff94VHcJ0HtvdEUE0Y2Zm8DOrlugTL9Dnk2OkzRuJnTlxBVs1mtzjYYfkyr7aD3K2aiTPA004IwMOx5KORoy5q7U0R9Mi00IjysLw7dQYafa8xvPQA8XYL7cJhBrNb0L3wKmVgGgMm3xe5UkOF6eY+rKy/4EPFg6RxkSt/FC8jZCZinoL4W5mbGgoTMFe0vfUAauMjUrqIjJozQh5x3PxQUHgsJQw4yYLT2k+UYz3UZF3Tdkb7Vrl1u7DCSjTySi2QvX2UCowhhZXzjlLRziq1RnbrAn1chmyIKoOJtrRPmEZb1yHsvmnzl7g6jV/CSyoRwLWa/woVIqs+VcD0Eehncv2JW4SCyzp+a2+ZIscrs1SQPMHYT05ifr3/mG48H9jr0ECfUmeQ6j20tUiP X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 41bb6156-0563-4890-126e-08dc4a45b7fb X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2024 07:57:28.2305 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aX9jIgylARyPDDGwVGdpvSlmaJntPeWGkipar7l0ZyYld3TzVvxl4kznlTFhkTyNwxddtDq5dDrPOWDDH/UoEA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9290 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240322_005738_658764_B6164B71 X-CRM114-Status: GOOD ( 10.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Peng Fan It would be easier to locate the problem if domain name is printed out. Signed-off-by: Peng Fan --- V2: Update extra two places drivers/firmware/arm_scmi/perf.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/firmware/arm_scmi/perf.c b/drivers/firmware/arm_scmi/perf.c index 345fff167b52..c36a390bba60 100644 --- a/drivers/firmware/arm_scmi/perf.c +++ b/drivers/firmware/arm_scmi/perf.c @@ -387,8 +387,8 @@ process_response_opp(struct device *dev, struct perf_dom_info *dom, ret = xa_insert(&dom->opps_by_lvl, opp->perf, opp, GFP_KERNEL); if (ret) - dev_warn(dev, "Failed to add opps_by_lvl at %d - ret:%d\n", - opp->perf, ret); + dev_warn(dev, "Failed to add opps_by_lvl at %d for %s- ret:%d\n", + opp->perf, dom->info.name, ret); } static inline void @@ -405,8 +405,8 @@ process_response_opp_v4(struct device *dev, struct perf_dom_info *dom, ret = xa_insert(&dom->opps_by_lvl, opp->perf, opp, GFP_KERNEL); if (ret) - dev_warn(dev, "Failed to add opps_by_lvl at %d - ret:%d\n", - opp->perf, ret); + dev_warn(dev, "Failed to add opps_by_lvl at %d for %s - ret:%d\n", + opp->perf, dom->info.name, ret); /* Note that PERF v4 reports always five 32-bit words */ opp->indicative_freq = le32_to_cpu(r->opp[loop_idx].indicative_freq); @@ -417,8 +417,8 @@ process_response_opp_v4(struct device *dev, struct perf_dom_info *dom, GFP_KERNEL); if (ret) dev_warn(dev, - "Failed to add opps_by_idx at %d - ret:%d\n", - opp->level_index, ret); + "Failed to add opps_by_idx at %d for %s - ret:%d\n", + opp->level_index, dom->info.name, ret); hash_add(dom->opps_by_freq, &opp->hash, opp->indicative_freq); } @@ -879,7 +879,8 @@ static int scmi_dvfs_device_opps_add(const struct scmi_protocol_handle *ph, ret = dev_pm_opp_add_dynamic(dev, &data); if (ret) { - dev_warn(dev, "failed to add opp %luHz\n", freq); + dev_warn(dev, "[%d][%s]: Failed to add OPP[%d] %lu\n", + domain, dom->info.name, idx, freq); dev_pm_opp_remove_all_dynamic(dev); return ret; }