diff mbox series

ARM: dts: imx7s-warp: Fix OV2680 supply names

Message ID 20240323125327.1398102-1-festevam@gmail.com (mailing list archive)
State New, archived
Headers show
Series ARM: dts: imx7s-warp: Fix OV2680 supply names | expand

Commit Message

Fabio Estevam March 23, 2024, 12:53 p.m. UTC 
From: Fabio Estevam <festevam@denx.de>

Fix the OV2680 supply names according to ovti,ov2680.yaml.

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm/boot/dts/nxp/imx/imx7s-warp.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Shawn Guo April 2, 2024, 10:58 a.m. UTC | #1 
On Sat, Mar 23, 2024 at 09:53:27AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Fix the OV2680 supply names according to ovti,ov2680.yaml.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Do we want to have a Fixes tag for it?

Shawn

> ---
>  arch/arm/boot/dts/nxp/imx/imx7s-warp.dts | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/nxp/imx/imx7s-warp.dts b/arch/arm/boot/dts/nxp/imx/imx7s-warp.dts
> index ba7231b364bb..c26888b7af3f 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx7s-warp.dts
> +++ b/arch/arm/boot/dts/nxp/imx/imx7s-warp.dts
> @@ -201,9 +201,9 @@ ov2680: camera@36 {
>  		clocks = <&osc>;
>  		clock-names = "xvclk";
>  		reset-gpios = <&gpio1 3 GPIO_ACTIVE_LOW>;
> -		DOVDD-supply = <&sw2_reg>;
> -		DVDD-supply = <&sw2_reg>;
> -		AVDD-supply = <&reg_peri_3p15v>;
> +		dovdd-supply = <&sw2_reg>;
> +		dvdd-supply = <&sw2_reg>;
> +		avdd-supply = <&reg_peri_3p15v>;
>  
>  		port {
>  			ov2680_to_mipi: endpoint {
> -- 
> 2.34.1
>
Fabio Estevam April 2, 2024, 11:11 a.m. UTC | #2 
Hi Shawn,

On Tue, Apr 2, 2024 at 7:58 AM Shawn Guo <shawnguo2@yeah.net> wrote:
>
> On Sat, Mar 23, 2024 at 09:53:27AM -0300, Fabio Estevam wrote:
> > From: Fabio Estevam <festevam@denx.de>
> >
> > Fix the OV2680 supply names according to ovti,ov2680.yaml.
> >
> > Signed-off-by: Fabio Estevam <festevam@denx.de>
>
> Do we want to have a Fixes tag for it?

Please discard this patch.

I noticed that the driver uses DOVDD, DVDD, and AVDD as supply names.

The regulators uses on imx7s-warp are marked as 'regulator-always-on'
so we don't see the issue in practice.

I will update the bindings instead.

Thanks.
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/nxp/imx/imx7s-warp.dts b/arch/arm/boot/dts/nxp/imx/imx7s-warp.dts
index ba7231b364bb..c26888b7af3f 100644
--- a/arch/arm/boot/dts/nxp/imx/imx7s-warp.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx7s-warp.dts
@@ -201,9 +201,9 @@  ov2680: camera@36 {
 		clocks = <&osc>;
 		clock-names = "xvclk";
 		reset-gpios = <&gpio1 3 GPIO_ACTIVE_LOW>;
-		DOVDD-supply = <&sw2_reg>;
-		DVDD-supply = <&sw2_reg>;
-		AVDD-supply = <&reg_peri_3p15v>;
+		dovdd-supply = <&sw2_reg>;
+		dvdd-supply = <&sw2_reg>;
+		avdd-supply = <&reg_peri_3p15v>;
 
 		port {
 			ov2680_to_mipi: endpoint {