diff mbox series

ARM: dts: stm32: add heartbeat led for stm32mp157c-ed1

Message ID 20240325170656.2829600-1-patrice.chotard@foss.st.com (mailing list archive)
State New, archived
Headers show
Series ARM: dts: stm32: add heartbeat led for stm32mp157c-ed1 | expand

Commit Message

Patrice CHOTARD March 25, 2024, 5:06 p.m. UTC 
From: Patrice Chotard <patrice.chotard@foss.st.com>

Add heartbeat led for stm32mp157c-ed1.

Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---
 arch/arm/boot/dts/st/stm32mp157c-ed1.dts | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Krzysztof Kozlowski March 25, 2024, 6:29 p.m. UTC | #1 
On 25/03/2024 18:06, patrice.chotard@foss.st.com wrote:
> From: Patrice Chotard <patrice.chotard@foss.st.com>
> 
> Add heartbeat led for stm32mp157c-ed1.
> 
> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
> ---
>  arch/arm/boot/dts/st/stm32mp157c-ed1.dts | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/st/stm32mp157c-ed1.dts b/arch/arm/boot/dts/st/stm32mp157c-ed1.dts
> index 66ed5f9921ba..bd727455a7e4 100644
> --- a/arch/arm/boot/dts/st/stm32mp157c-ed1.dts
> +++ b/arch/arm/boot/dts/st/stm32mp157c-ed1.dts
> @@ -24,6 +24,15 @@ chosen {
>  		stdout-path = "serial0:115200n8";
>  	};
>  
> +	led {
> +		compatible = "gpio-leds";
> +		led-blue {
> +			gpios = <&gpiod 9 GPIO_ACTIVE_HIGH>;
> +			linux,default-trigger = "heartbeat";
> +			default-state = "off";

Please add function and color properties.

Best regards,
Krzysztof
Patrice CHOTARD March 26, 2024, 7:29 a.m. UTC | #2 
On 3/25/24 19:29, Krzysztof Kozlowski wrote:
> On 25/03/2024 18:06, patrice.chotard@foss.st.com wrote:
>> From: Patrice Chotard <patrice.chotard@foss.st.com>
>>
>> Add heartbeat led for stm32mp157c-ed1.
>>
>> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
>> ---
>>  arch/arm/boot/dts/st/stm32mp157c-ed1.dts | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/st/stm32mp157c-ed1.dts b/arch/arm/boot/dts/st/stm32mp157c-ed1.dts
>> index 66ed5f9921ba..bd727455a7e4 100644
>> --- a/arch/arm/boot/dts/st/stm32mp157c-ed1.dts
>> +++ b/arch/arm/boot/dts/st/stm32mp157c-ed1.dts
>> @@ -24,6 +24,15 @@ chosen {
>>  		stdout-path = "serial0:115200n8";
>>  	};
>>  
>> +	led {
>> +		compatible = "gpio-leds";
>> +		led-blue {
>> +			gpios = <&gpiod 9 GPIO_ACTIVE_HIGH>;
>> +			linux,default-trigger = "heartbeat";
>> +			default-state = "off";
> 
> Please add function and color properties.
Hi Krzysztof

OK i will send a v2

Thanks
Patrice

> 
> Best regards,
> Krzysztof
>
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/st/stm32mp157c-ed1.dts b/arch/arm/boot/dts/st/stm32mp157c-ed1.dts
index 66ed5f9921ba..bd727455a7e4 100644
--- a/arch/arm/boot/dts/st/stm32mp157c-ed1.dts
+++ b/arch/arm/boot/dts/st/stm32mp157c-ed1.dts
@@ -24,6 +24,15 @@  chosen {
 		stdout-path = "serial0:115200n8";
 	};
 
+	led {
+		compatible = "gpio-leds";
+		led-blue {
+			gpios = <&gpiod 9 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "heartbeat";
+			default-state = "off";
+		};
+	};
+
 	memory@c0000000 {
 		device_type = "memory";
 		reg = <0xC0000000 0x40000000>;