From patchwork Tue Mar 26 09:16:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vincent Guittot X-Patchwork-Id: 13603717 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F418CD11DC for ; Tue, 26 Mar 2024 09:17:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/TPLF+QpR53+eLu4MzigKGQpeEqgWATN5SGGAAi4uyI=; b=nZ659t0OYzg43U zJhEAQDkpoacz1J+etuvbwPZF/nEz0qko8ftKjQWzmJL6NtklnkOgwWKMQCvTduTCXmgc4ftQbK4i bW2dL0BcvXF8Mf0yfpdxIC4yzadX1oPapXmGcBeCz0CGo5jmOGw7wxsBIzGvGakTgNBlY5gJd8Xt3 k8nKJeu62vQVXMHEEhNONUhArGdoUaxTSEEIHela7X1rOjU2QeLYZtBzFhX9KhhOlXtfS1U96yNfE fiMj+RR+Ko1nrXCW3LLhhaOgzlnJvdRsSk7S7fzQt2u4I8un6ogvl2TyljV8JavxTtCsMV7Ena8YE P5a/gTvEs3BjwHhhWM8Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rp2vS-00000003ls0-3reS; Tue, 26 Mar 2024 09:16:59 +0000 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rp2uw-00000003ldZ-1YNM for linux-arm-kernel@lists.infradead.org; Tue, 26 Mar 2024 09:16:29 +0000 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-4148c2a3a3fso7636395e9.3 for ; Tue, 26 Mar 2024 02:16:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711444585; x=1712049385; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ammHs6vW1OsPJVQNMpuIMjJitue7UK+ZVRA8E34u8K0=; b=oFmeEgs47JyH0WpdtxtsuVujfPPN8I3kTpRYxdQ44KAOn8diGyKcvmp4X5lyyszubh 4fgVQ9Axp1nk6+PctJWCRsaJPe0/lziWBoETLk81WR+vHsBmf+wDP9okm7WUpnAAdWci woQ6G96rb5yJYnSl1kFF9YDkNYCM3+GGE7KjmR+25SImSx4SvQVg9wafi6C38gYyuZ7e neyuHZG+UHPGjA/njriBn0Kx2pZIja0BGjBiS1RI9CvXWR0WGXFjilXl/+vI5pELUg9T OtMo4ateKEj3CGS8Pww8IXDYVqBEl1Q1YnAIth+qPvllGYiBBpReo0/Ach9sOjYfi25A jJEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711444585; x=1712049385; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ammHs6vW1OsPJVQNMpuIMjJitue7UK+ZVRA8E34u8K0=; b=lBYH+o9dkMa3Ik66wsrc1+kWQxM2rZYoO5hQxEafKfKr7kAJNRPO2A54ykwobE8bYo 1f3d6hsg7DncRzzbRkkncYoH+ct9xRlbjECPM+/IadCvlKic/ZfeFFCkN5zRYhH/hODk k6I7/fobiOendGhVgKWN5HFzlstjwJ3DySooAkwiPkkEQ1z2kuvZs0E0blA6HdysbaAc 3Y3/r3TGuSIrhcrZd9GYV3Gt+FTNH8A0gJmzxJ1kDcmDfgR9fxI5bshzSmKJEvsOIlXl hyqpdHZI9+Fowg9lyhZqI5P1zlL/qvTGCuVMmdkQ4UXePB83G5LnzG+k0P7m7uossBp5 JmWg== X-Forwarded-Encrypted: i=1; AJvYcCXATHFtAx0D4IE8ZnyKSBY3ksjpwG5jsPn3/I1oZRgXhA3mRaoFb2lexOKO2ufgNVYdp0sqcwxQ2DFI5sOanHXe+eJ3+VTw7jRxwpuyDSVvwNp+tv4= X-Gm-Message-State: AOJu0Yw0Pke6cW5ypKfrd9WvEoYOR3DzBsZtXVs1V70IDqnH0qE7aA2B BEoDo4oZBpHAS+RYkTye6vK9asVjot1TDHuAOh54zW6tfKJUp8gmfWPo37WMGk0= X-Google-Smtp-Source: AGHT+IEtDqvTrp3LQMqivjk1kFcHLuxSotNAE9cJSHtwNsbpF6i2yUL7nqRFZLu7OjM8PT7RKYqlyQ== X-Received: by 2002:a05:600c:474d:b0:414:9048:40ba with SMTP id w13-20020a05600c474d00b00414904840bamr317033wmo.0.1711444585096; Tue, 26 Mar 2024 02:16:25 -0700 (PDT) Received: from localhost.localdomain ([2a01:e0a:f:6020:e6b6:c92e:43ff:71d7]) by smtp.gmail.com with ESMTPSA id m15-20020adffe4f000000b0033e5c54d0d9sm11647606wrs.38.2024.03.26.02.16.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Mar 2024 02:16:24 -0700 (PDT) From: Vincent Guittot To: linux@armlinux.org.uk, catalin.marinas@arm.com, will@kernel.org, sudeep.holla@arm.com, rafael@kernel.org, viresh.kumar@linaro.org, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, lukasz.luba@arm.com, rui.zhang@intel.com, mhiramat@kernel.org, daniel.lezcano@linaro.org, amit.kachhap@gmail.com, corbet@lwn.net, gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org Cc: Vincent Guittot Subject: [PATCH v6 3/5] thermal/cpufreq: Remove arch_update_thermal_pressure() Date: Tue, 26 Mar 2024 10:16:14 +0100 Message-Id: <20240326091616.3696851-4-vincent.guittot@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240326091616.3696851-1-vincent.guittot@linaro.org> References: <20240326091616.3696851-1-vincent.guittot@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240326_021627_555494_4DF66183 X-CRM114-Status: GOOD ( 11.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org arch_update_thermal_pressure() aims to update fast changing signal which should be averaged using PELT filtering before being provided to the scheduler which can't make smart use of fast changing signal. cpufreq now provides the maximum freq_qos pressure on the capacity to the scheduler, which includes cpufreq cooling device. Remove the call to arch_update_thermal_pressure() in cpufreq cooling device as this is handled by cpufreq_get_pressure(). Signed-off-by: Vincent Guittot Reviewed-by: Lukasz Luba Acked-by: Viresh Kumar Tested-by: Lukasz Luba Reviewed-by: Dhruva Gole --- drivers/thermal/cpufreq_cooling.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/thermal/cpufreq_cooling.c b/drivers/thermal/cpufreq_cooling.c index 9d1b1459700d..280071be30b1 100644 --- a/drivers/thermal/cpufreq_cooling.c +++ b/drivers/thermal/cpufreq_cooling.c @@ -477,7 +477,6 @@ static int cpufreq_set_cur_state(struct thermal_cooling_device *cdev, unsigned long state) { struct cpufreq_cooling_device *cpufreq_cdev = cdev->devdata; - struct cpumask *cpus; unsigned int frequency; int ret; @@ -494,8 +493,6 @@ static int cpufreq_set_cur_state(struct thermal_cooling_device *cdev, ret = freq_qos_update_request(&cpufreq_cdev->qos_req, frequency); if (ret >= 0) { cpufreq_cdev->cpufreq_state = state; - cpus = cpufreq_cdev->policy->related_cpus; - arch_update_thermal_pressure(cpus, frequency); ret = 0; }